Re: [External] : [PATCH net-next v5 3/4] net: renesas: rswitch: add offloading for L2 switching

[ALOK TIWARI <alok.a.tiwari@oracle.com>]

Hi Michael,

On 9/1/2025 10:28 AM, Michael Dege wrote:
> +static void rswitch_update_offload_brdev(struct rswitch_private *priv)
> +{
> +	struct net_device *offload_brdev = NULL;
> +	struct rswitch_device *rdev, *rdev2;
> +
> +	rswitch_for_all_ports(priv, rdev) {
> +		if (!rdev->brdev)
> +			continue;
> +		rswitch_for_all_ports(priv, rdev2) {
> +			if (rdev2 == rdev)
> +				break;
> +			if (rdev2->brdev == rdev->brdev) {
> +				offload_brdev = rdev->brdev;
> +				break;
> +			}
> +		}
> +		if (offload_brdev)
> +			break;
> +	}
> +
> +	if (offload_brdev == priv->offload_brdev)
> +		dev_dbg(&priv->pdev->dev,
> +			"changing l2 offload from %s to %s\n",

condition does not match the actual intent
it seems, offload_brdev != priv->offload_brdev more suitable.
I understand this code already has been merged in upstream 6.18.

> +			netdev_name(priv->offload_brdev),
> +			netdev_name(offload_brdev));
> +	else if (offload_brdev)
> +		dev_dbg(&priv->pdev->dev, "starting l2 offload for %s\n",
> +			netdev_name(offload_brdev));
> +	else if (!offload_brdev)
> +		dev_dbg(&priv->pdev->dev, "stopping l2 offload for %s\n",
> +			netdev_name(priv->offload_brdev));
> +
> +	priv->offload_brdev = offload_brdev;
> +
> +	rswitch_update_l2_offload(priv);
> +}

Thanks,
Alok