From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1502D8003D for ; Sat, 14 Mar 2026 09:33:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773480807; cv=none; b=ox0wXqAIKnUiIOJylvgPX244dy3JTsYFjczKtOLvZPtf8XYJLuTHaWL5+yVYe6MfELKAsLFurxqJaA3QS74WhxHTgPw0TG8z80ibZ2vTsPnBjCJ/MlI3RobE+FlPrrL0+IvEHYtjzvagW6CnEk7XmPPVhsLp0SFyD+IRVWsXtVs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773480807; c=relaxed/simple; bh=ib8seA0g2PtzjPipXOSyi0qCKs3NiqTO75CZZBotfmw=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=Ge093npEfhYzNym5HCNjwZD0XmpEy1MQlPRrBy6BjIKwUrACJSIEibmgk5+sYNRXFp66cxCf3cWuJxR6KC/zPJl34uiTfujADk2/8g9Efp5dyjs6G6jbAVNEApp7Sgtu2NPozWQJEH5ifRqAudR10ShqAsCnIEw40gl0KgDKBOA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=YN/a4jXN; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=DrM/WRPr; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="YN/a4jXN"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="DrM/WRPr" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62E5UPOg3143747 for ; Sat, 14 Mar 2026 09:33:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= yaMwFAS+Gg2koBcg2Kz91VQgclbp+hdxDTu4+qgo8Mw=; b=YN/a4jXNBd0+GpZy sU4h1QLhTkEGoUS0AM8czhOulw/nNl4pqwpNAWSm531fhgyve7t5PZK8JYvUZicj Ni8jBi9GauWeLDfQle+nShoKB/y7LIpT5f8Qk59XtfZ/cmqitIgnDXZKeQzgLbIA TECzFmoDdr7O1IZjq3FA8psW3nca+JTwWP52H9iv2sLsl4r1r9QcZcWco4CB4I5Z bnfwWAqRXqctFfrgG9RU7sfrNnWLFNQZIDr6xb0QZK7Rwq7vOGozODnHFugzJp7B dw3hHSZGqgxHYOOdpnqDiqJOt4wEDXnsIk/3bC6xsNfIc9xquRXmVvOtzB/M6gn0 9cFkYg== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cw00b8gkt-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sat, 14 Mar 2026 09:33:19 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-35641c14663so3327371a91.2 for ; Sat, 14 Mar 2026 02:33:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773480798; x=1774085598; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=yaMwFAS+Gg2koBcg2Kz91VQgclbp+hdxDTu4+qgo8Mw=; b=DrM/WRPr4eUSs8E/ZdUevS5oF4/qic50sqKCaSrr9QIJwICO13B4ehMiJ6shScvxcs o43BCl5S4TF9a5yGffWNCLQD5YXZxQzF5iBXi2//58Rqze83AA8k71vzG5FU8aUUkGSW w8ZxG2fQAhXBqnqbwrnztiQhugAjdzg9KFN3UAQeXPFvaPL5FiHNJZOjmtFG4iWL16Cm lMEz2Prxxr6VcjMymX8os/FCgP/Iv0fyWTfWGv76kJB8RpHM3JyCaAixS2J0reFqtZfU NqKA/mw0e63aUlfIdercjv9lhjxCj9/x27kOR1RKtkKB2Ykp6qPCFsA0hd16pYNa8war sjdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773480798; x=1774085598; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yaMwFAS+Gg2koBcg2Kz91VQgclbp+hdxDTu4+qgo8Mw=; b=LQGJQSaaEYUoSvlO39mAQMPJWJocuocB6/GeZi1eG/7Fn3TFN1kDJZrJCwEctXukqY KdxdS2Cpfu3gqM0KpR9peg1yyyx9SwK8HczMM7BQdW0hlUnjd2umbkAY7LpcBeOugvAZ APBXPLavPxIvMaoTrfi6F4q4Ap5zqOp/Tw/knw0AwYSAr85ds4sj/WYx67kDU/kynjB4 Pg2A7wWxQLGo1sp5FO6qQtRIXnp1/OxyDTHxpuo9x9Mdq80ibVwGQmPgDmvFk+5xadPK SgyxaqcgmwZhEhVgFwAaneaDdmfOtLZu1cHMFk59siQBhoBojGea+VjTLyFTFi4VKxBz hEzQ== X-Forwarded-Encrypted: i=1; AJvYcCV1jbd+asMaLUa9CIljibuHhJWcas66uYdT9SyxdTQ0G9ZVrTuqetlZAnPkaX2p9qnG7rwbrodEVVd64DY=@vger.kernel.org X-Gm-Message-State: AOJu0YwvYkp08tFfujGLeSghuS19Pw5EEV2w2Bd9B2zJtBxICW+b37uc foPzVDetAF0IIBQqrkje0vuLAuOFuSC6S+eJAV5iaOvG1YtwcnC2nwKvYkv8b4LVT3O9/O2WF8a DqiL7dUU6TxfnijGVNDEuoIAYcFLd2FeWKWGwPZjiJNMN0O/AOwl5VuaFZ30kewmZ1Us= X-Gm-Gg: ATEYQzxubgz9w2EnxhJ0juopaazBWA4AcwLA61baqWmrNBqkv7z1z4y52IRlIfVw9zy 9BuL0UohawXAiS69tKXBNyRBEx9e66THdrvaD+zZY9sAwPi+N080kRf2yANSAwSVn/a1EUFYNE8 Rsedk4q4X168ulL59vgVvNSKIZhe4tTdyxDCufg0arKvEjWWposNgSO5V76fJUjkJBAqJMGoYhr XsGR2IdGbsIe/ZDHaIR8iAPqAe0XlNS/CIlSVC3Ci07CAN6oIwhd1VVAc1u4Dsb+Xmk9+V33y+s harh7Q+NCNzPsjh+WcBxbDFir9ny0IAcQyl/M22TtO+u7mF9lbC926GkhcN6VbkxHE6tjh0K3Bx yCASZHFAYikfjm98jXcXhxzlvk2Q94czhKUGLRY0N/dAnrGsPn+JMBwDY2mYs4FSjPigDT43N6o 0hGs7g8iHsiw== X-Received: by 2002:a17:90b:4c4c:b0:359:8f7e:d34a with SMTP id 98e67ed59e1d1-35a21e4650bmr6181561a91.9.1773480797962; Sat, 14 Mar 2026 02:33:17 -0700 (PDT) X-Received: by 2002:a17:90b:4c4c:b0:359:8f7e:d34a with SMTP id 98e67ed59e1d1-35a21e4650bmr6181528a91.9.1773480797493; Sat, 14 Mar 2026 02:33:17 -0700 (PDT) Received: from [10.133.33.24] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35a1c34fa3esm6955088a91.4.2026.03.14.02.33.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 14 Mar 2026 02:33:17 -0700 (PDT) Message-ID: <6e07208c-a94b-44dc-8f7e-ccbb0ff8840e@oss.qualcomm.com> Date: Sat, 14 Mar 2026 17:33:10 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 04/12] scsi: ufs: core: Add support for TX Equalization From: Can Guo To: Bart Van Assche , avri.altman@wdc.com, beanhuo@micron.com, martin.petersen@oracle.com, mani@kernel.org Cc: linux-scsi@vger.kernel.org, Alim Akhtar , "James E.J. Bottomley" , Peter Wang , "Bao D. Nguyen" , Adrian Hunter , open list References: <20260308151409.3779137-1-can.guo@oss.qualcomm.com> <20260308151409.3779137-5-can.guo@oss.qualcomm.com> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=IsATsb/g c=1 sm=1 tr=0 ts=69b52b5f cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=3GuXBLcyPA-KnW9U8h4A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzE0MDA3MyBTYWx0ZWRfX+Tp6ZqS3Q0TI /pGcUX0yaUGE8Rjd7+33v/63unt5LgtSoflCTIjvPw4TSj5pcnastJBvx3DKobMieEIXcvWPduq Lsn8Zyjp+/bw2PhsceuzaguVxsi6Yi15syAclijxz836ya+wuKhSIY9DaGfxhSLe9dtbZNwgS9a GICZyBi+b36+3ijR7+TvOt1QKW1cZCXmX9kJfzjI75KbtW4BBDAKbnguJZbwgYJG2MPmC55Ze0O HSmWUvMR9xOVtDoyoW+jWA1k8/pJD16sek7+4IQpoPhFksW4JbG62OYizEirIzPq78YV/j/yawy KErahIyKz6/c4N7C2X+U0+b9bgBBhqWJGgP6gm80YCdubCHlaljVH+Bh2mWq2WH5X9U5uighYuo erJdVqDWpADtT+hRu9fJpXt5IxPta5XcbF3fY21DogA4nlrBwl5+A3WJiI8fSBoeDqafLkDXrl3 IwZvPxvM39zXxx+inwA== X-Proofpoint-GUID: nZ5zQdGURST7mdGZjsWIl3ndy3Nq8xBM X-Proofpoint-ORIG-GUID: nZ5zQdGURST7mdGZjsWIl3ndy3Nq8xBM X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-14_03,2026-03-13_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 adultscore=0 priorityscore=1501 bulkscore=0 malwarescore=0 lowpriorityscore=0 impostorscore=0 phishscore=0 suspectscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603140073 On 3/14/2026 4:19 PM, Can Guo wrote: > > > On 3/14/2026 6:19 AM, Bart Van Assche wrote: >> On 3/8/26 8:14 AM, Can Guo wrote: >>> +static int txeq_gear_set(const char *val, const struct kernel_param >>> *kp) >>> +{ >>> +    return param_set_uint_minmax(val, kp, UFS_HS_G1, UFS_HS_G6); >>> +} >> >> Why UFS_HS_G6 instead of UFS_HS_GEAR_MAX? > I will use 'UFS_HS_GEAR_MAX - 1' in next version. On second thought, to make the code more readable and scalable, I will use UFS_HS_GEAR_MAX here. To achieve so, I am going to tweak the code like below: enum ufs_hs_gear_tag {         UFS_HS_DONT_CHANGE,     /* Don't change Gear */         UFS_HS_G1,              /* HS Gear 1 (default for reset) */         UFS_HS_G2,              /* HS Gear 2 */         UFS_HS_G3,              /* HS Gear 3 */         UFS_HS_G4,              /* HS Gear 4 */         UFS_HS_G5,              /* HS Gear 5 */ +      UFS_HS_G6,              /* HS Gear 6 */ +      UFS_HS_GEAR_MAX_INVALID, }; + + #define UFS_HS_GEAR_MAX         UFS_HS_GEAR_MAX_INVALID - 1 Thanks, Can Guo. >> >>> @@ -955,6 +1045,11 @@ enum ufshcd_mcq_opr { >>> + * @host_preshoot_cap: host TX PreShoot capability >>> + * @host_deemphasis_cap: host TX DeEmphasis capability >>> + * @device_preshoot_cap: device TX PreShoot capability >>> + * @device_deemphasis_cap: device TX DeEmphasis capability >> >> Please either explain the meaning of the bits in the above four new >> member variables or add a reference to the standard that defines the >> meaning of the bits in these member variables. > OK. >> >>> +#define UFS_HS_RATE_STRING(rate) \ >>> +    ((rate) == PA_HS_MODE_A ? "A" : \ >>> +     (rate) == PA_HS_MODE_B ? "B" : \ >>> +     "Unknown") >> >> Why a #define instead of an inline function? Aren't inline functions >> preferred over preprocessor macros? > Let me change to inline function in next version. > > Thanks, > Can Guo. >> >> Thanks, >> >> Bart. >