From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81913C6FD1E for ; Fri, 10 Mar 2023 09:47:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229521AbjCJJrY (ORCPT ); Fri, 10 Mar 2023 04:47:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41284 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230319AbjCJJrB (ORCPT ); Fri, 10 Mar 2023 04:47:01 -0500 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ED6FD1ABE2; Fri, 10 Mar 2023 01:46:42 -0800 (PST) Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id AEC9A660305B; Fri, 10 Mar 2023 09:46:40 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1678441601; bh=HxvEW4kpMKirQlHHWsuDOAOqCEYgv8lxN0TWIGQVEBI=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=XDf5AC/d8cr83nZOhzyatXkW6DXH384345+3/ZzDL+5wV2e/PdrnNN2LCohdjxJue 62Uw0St/zP2zuK4cxGc1LE04Lt35HYs1gS3tfJFKKJDJ6zP2Y4UhdEsIVCz9UYz67F +5tdlpNmGZmJD3n5zsRqjOvrUlgtlSOcl1ac+dIJoyEBAEM2uwLrOB09DKVjv4qgDk Yr4A/wnahZ9uzdt1hxtclCbXLwjOUDptreNjD4rvFVCdeVQ3nRvwc2L5DkweAu5jNB 19WukUduzdVF92Qo6P13+5YR5y2gf6YQPcrUo6q9s8CR/oMdJtH9YCDp5txEz2pWmn d7o+3AWce9KQw== Message-ID: <6e08d78f-ef4c-b228-f7d2-d63767ea87b8@collabora.com> Date: Fri, 10 Mar 2023 10:46:37 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v2 03/18] dt-bindings: pinctrl: mediatek,mt8365-pinctrl: add drive strength property Content-Language: en-US To: Krzysztof Kozlowski , Alexandre Mergnat , Zhiyong Tao , Guenter Roeck , Linus Walleij , =?UTF-8?Q?Bernhard_Rosenkr=c3=a4nzer?= , Ulf Hansson , Wim Van Sebroeck , Krzysztof Kozlowski , Chaotian Jing , Rob Herring , Wenbin Mei , Matthias Brugger Cc: linux-mmc@vger.kernel.org, Alexandre Bailon , devicetree@vger.kernel.org, Amjad Ouled-Ameur , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-mediatek@lists.infradead.org, Fabien Parent References: <20230203-evk-board-support-v2-0-6ec7cdb10ccf@baylibre.com> <20230203-evk-board-support-v2-3-6ec7cdb10ccf@baylibre.com> <3b7c6f28-57bd-33de-5531-8c4eae8cf6eb@linaro.org> From: AngeloGioacchino Del Regno In-Reply-To: <3b7c6f28-57bd-33de-5531-8c4eae8cf6eb@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 10/03/23 09:32, Krzysztof Kozlowski ha scritto: > On 07/03/2023 14:17, Alexandre Mergnat wrote: >> This SoC is able to drive the following output current: >> - 2 mA >> - 4 mA >> - 6 mA >> - 8 mA >> - 10 mA >> - 12 mA >> - 14 mA >> - 16 mA >> >> Then drive-strength property is set with enum to reflect its HW capability. >> >> Signed-off-by: Alexandre Mergnat >> --- >> Documentation/devicetree/bindings/pinctrl/mediatek,mt8365-pinctrl.yaml | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/pinctrl/mediatek,mt8365-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/mediatek,mt8365-pinctrl.yaml >> index 4b96884a1afc..101871ec6693 100644 >> --- a/Documentation/devicetree/bindings/pinctrl/mediatek,mt8365-pinctrl.yaml >> +++ b/Documentation/devicetree/bindings/pinctrl/mediatek,mt8365-pinctrl.yaml >> @@ -79,6 +79,9 @@ patternProperties: >> >> bias-pull-down: true >> >> + drive-strength: >> + enum: [2, 4, 6, 8, 10, 12, 14, 16] > > Isn't this conflicting with mediatek,drive-strength-adv? Your commit msg > suggests you add a missing property, but I would say nothing was missing > here. > > You need review from (pinctrl) Mediatek maintainers how the bindings for > all Mediateks are organized. Hello Krzysztof, mediatek,drive-strength-adv *shall not exist*, that was an unnecessary property that leaked upstream from downstream kernels and there's no reason to use it. Upstream, we have drive-strength-microamp and mediatek,rsel-resistance-in-si-unit. Since mediatek,mt8365-pinctrl.yaml got picked with that property already, I have nothing to complain about this specific commit... drive-strength does not conflict with the mediatek,drive-strength-adv property, as the "adv" is for microamp adjustments. You can pick it, it's fine. Anyway, Alexandre: can you please perform a cleanup to the MT8365 pinctrl binding? The cleanup means you're setting mediatek,drive-strength-adv as deprecated and adding the right properties (...and possibly changing the devicetrees to use it). For more information, you can look at commit history for the (unfortunately, named incorrectly) MT8195 pinctrl documentation: bindings/pinctrl/pinctrl-mt8195.yaml where we performed the same cleanup that I'm asking you to do, except we didn't have to set any property as deprecated because there was *no devicetree upstream* that was actually using that property (hence not an ABI breakage). Cheers! Angelo