From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792486522; b=KfzxbQj+ASCFRXqSRh9+KTyTM+Ziy6ueV3jFsMNp4o38v9cd0+qttBBojxDbtaRsaBbc tQRvP5QnrQZunYX7zJw4mlFojKzas68EQpe1wKE5gBUrpZMafl7E10WJUwXwE/Mz7qveI p2AfdHJHcxf41eJh7/GBUUWMiy447LdGlwcnve3i4h6gk/fVQ+sz7oST0EZkr9PXejTxp o/Ks4NIuMx4EyVbQ+f7hJe1kui6O4lZyMk5v0YotJBVvbkW5NadmYMZAOQIm/pjyDAhcz h5X/SOX6QvW3uHML3tt63qgKo1WJTlCQBAnIh3uMuBtO5Xb/w6lNZ2iLSxYYllNo5og== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792486522; h=DMARC-Filter:Received:DKIM-Signature:DKIM-Signature:DKIM-Signature: DKIM-Signature:Received:Received:Date:From:To:Cc:Subject:Message-ID: References:MIME-Version:Content-Type:Content-Disposition:In-Reply-To: X-Spam-Flag:X-Spam-Score:X-Spam-Level:X-Spamd-Result; bh=s0rKbjF/Y9G+VhQ22dzUsW8sQ6QduMv5ejx2RtBN2mU=; b=2sR1lQAeQdp1OLRDkb8pdzaOP5KgVdCkaVAMKBX0H0B/4rI6Rblf0rwMxrlfTMBOqDOS SmyTVtIwbyUXKH3oaFWfsREUCgcyJuRggr+Ms3HfVRRhBbP2JXkQk/mmn6BVWpGljH/jC DQpA+6A5lHX4HzqjfW+LxrAvSOVd17YBdFxWWZ9Nov35JSMl7edUrdFYn3+YT/pNha4wa xoKjv5nEIibhofXnZ0MYKQCjFAVCQh71aRCrRx2YWOOnl92UjKwHoN0Rq2+3ytj07sCWW EkFNCuyZeAOmRfCXJhKX1DKqG5r2Yb7U3x4bl1s6fLv7/+Egzy727TUYbRnY5/hjjiQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=p1grDgPR; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=5Dw2sKmE; dkim=pass header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=p1grDgPR; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=5Dw2sKmE; arc=none smtp.remote-ip=195.135.223.130 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 70A5B606A31D for ; Tue, 20 Oct 2026 08:55:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 70A5B606A31D Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=p1grDgPR; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=5Dw2sKmE; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=p1grDgPR; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=5Dw2sKmE Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id A996721DC3; Tue, 20 Oct 2026 08:55:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1792486519; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=s0rKbjF/Y9G+VhQ22dzUsW8sQ6QduMv5ejx2RtBN2mU=; b=p1grDgPRHf6OGuugOk7QiucIuC4RfCbaERlfhTQFC6a7M0AIAheBKfW5+UvJhCg3uGULuS QvfbrmZDYgopPwdgr4ldzTo5htvB+tBte7Nv43DEoIDxuQ6vtjT8Jrh+PkFN9JoG5GjNvN Ucu+shMVk6azF6ywbs7WAGZqirTAbRQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1792486519; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=s0rKbjF/Y9G+VhQ22dzUsW8sQ6QduMv5ejx2RtBN2mU=; b=5Dw2sKmE4wG4Eqs9tVzOAf4Uo704s9sOdLZuP34fIl8NI8/fovnx+8hJ30OktwvSgKsahX Ju1t60C5tFWeprCg== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1792486519; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=s0rKbjF/Y9G+VhQ22dzUsW8sQ6QduMv5ejx2RtBN2mU=; b=p1grDgPRHf6OGuugOk7QiucIuC4RfCbaERlfhTQFC6a7M0AIAheBKfW5+UvJhCg3uGULuS QvfbrmZDYgopPwdgr4ldzTo5htvB+tBte7Nv43DEoIDxuQ6vtjT8Jrh+PkFN9JoG5GjNvN Ucu+shMVk6azF6ywbs7WAGZqirTAbRQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1792486519; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=s0rKbjF/Y9G+VhQ22dzUsW8sQ6QduMv5ejx2RtBN2mU=; b=5Dw2sKmE4wG4Eqs9tVzOAf4Uo704s9sOdLZuP34fIl8NI8/fovnx+8hJ30OktwvSgKsahX Ju1t60C5tFWeprCg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 79B7E136CC; Tue, 20 Oct 2026 08:55:19 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 48OwF3cs12oUWQAAD6G6ig (envelope-from ); Tue, 20 Oct 2026 08:55:19 +0000 Date: Tue, 20 Oct 2026 10:55:10 +0200 From: Daniel Wagner To: Mohamed Khalfella Cc: Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg , Justin Tee , Naresh Gottumukkala , Paul Ely , Hannes Reinecke , Chaitanya Kulkarni , James Smart , Randy Jennings , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 08/18] nvme: Implement cross-controller reset recovery Message-ID: <6e0b4de0-b030-47cc-84ce-3f021a5c75b0@flourine.local> References: <20260920182936.2317916-1-mkhalfella@purestorage.com> <20260920182936.2317916-9-mkhalfella@purestorage.com> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260920182936.2317916-9-mkhalfella@purestorage.com> X-Spam-Flag: NO X-Spam-Score: -4.30 X-Spam-Level: X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; ARC_NA(0.00)[]; MISSING_XM_UA(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_TWELVE(0.00)[14]; RCVD_TLS_ALL(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_HAS_DN(0.00)[]; FREEMAIL_CC(0.00)[kernel.org,kernel.dk,lst.de,grimberg.me,broadcom.com,gmail.com,nvidia.com,purestorage.com,lists.infradead.org,vger.kernel.org]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo] > +static int nvme_issue_wait_ccr(struct nvme_ctrl *sctrl, struct nvme_ctrl *ictrl, > + unsigned long deadline) > +{ > + struct nvme_ccr_entry ccr = { }; > + union nvme_result res = { 0 }; > + struct nvme_command c = { }; > + unsigned long flags, now, tmo = 0; > + bool completed = false; > + int ret = 0; > + u32 result; > + > + init_completion(&ccr.complete); > + ccr.ictrl = ictrl; > + > + spin_lock_irqsave(&sctrl->lock, flags); > + list_add_tail(&ccr.list, &sctrl->ccr_list); > + spin_unlock_irqrestore(&sctrl->lock, flags); > + > + c.ccr.opcode = nvme_admin_cross_ctrl_reset; > + c.ccr.ciu = ictrl->ciu; > + c.ccr.icid = cpu_to_le16(ictrl->cntlid); > + c.ccr.cirn = cpu_to_le64(ictrl->cirn); > + ret = __nvme_submit_sync_cmd(sctrl->admin_q, &c, &res, > + NULL, 0, NVME_QID_ANY, 0); > + if (ret) { > + ret = -EIO; > + goto out; > + } > + > + result = le32_to_cpu(res.u32); > + if (result & 0x01) /* Immediate Reset Successful */ > + goto out; > + > + now = jiffies; > + if (time_before(now, deadline)) > + tmo = min_t(unsigned long, > + secs_to_jiffies(ictrl->kato), deadline - now); > + > + if (!wait_for_completion_timeout(&ccr.complete, tmo)) { > + ret = -ETIMEDOUT; > + goto out; > + } > + > + completed = true; > + > +out: > + spin_lock_irqsave(&sctrl->lock, flags); > + list_del(&ccr.list); > + spin_unlock_irqrestore(&sctrl->lock, flags); > + if (completed) { > + if (ccr.ccrs == NVME_CCR_STATUS_SUCCESS) > + return 0; > + return -EREMOTEIO; > + } > + return ret; This part could be made a bit simpler and there is no need for the local completed variable: [...] if (!wait_for_completion_timeout(&ccr.complete, tmo)) ret = -ETIMEDOUT; out: spin_lock_irqsave(&sctrl->lock, flags); list_del(&ccr.list); spin_unlock_irqrestore(&sctrl->lock, flags); if (ret || !completion_done(&ccr.complete)) return ret; if (ccr.ccrs == NVME_CCR_STATUS_SUCCESS) return 0; return -EREMOTEIO; }