From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from meesny.iki.fi (meesny.iki.fi [195.140.195.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 272BA26738C; Wed, 30 Sep 2026 05:55:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=195.140.195.201 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790747727; cv=pass; b=h8tyBdzHW3wdoQxj/6hZU150J0h4TDKWXOj3enA/HCQPv9bCkSgwNQsFyCuC6urNZL2EWoPcbcwMC7Ij1yQkcLQTbOjGXPbmAbFYYeeYK6ml7Xb3Cv6hFmzU2LTDsDxAsyqveiIuThnWN0AlpzML+rJC2ySeWkIR1N+dYSn/Rv0= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790747727; c=relaxed/simple; bh=8+ULgEZIWHVVxMrr1CIYY1TqDZ+KOILZsisC6lP8WRo=; h=MIME-Version:Date:From:To:Cc:Message-Id:In-Reply-To:References: Subject:Content-Type; b=d8q/t/gH0aon2TWacuLm6uIL+PV1jxnBoGwWitXErPqfivpq13ToIPduKJ8a5LB259TpuJ7dKYdwZFKdnLVOaTO+KNcHHv3hP3zy4tQiY6N+9TLU0CcoUWL70obBAqW/NTwbwbkAFZO3UgntruadQSrNuw/PPhqNNbYTnFViRyY= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iki.fi; spf=pass smtp.mailfrom=iki.fi; dkim=pass (1024-bit key) header.d=iki.fi header.i=@iki.fi header.b=mi89WtC1; arc=pass smtp.client-ip=195.140.195.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iki.fi Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=iki.fi Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=iki.fi header.i=@iki.fi header.b="mi89WtC1" Received: from fauth-c2-smtp.messagingengine.com (fauth-c2-smtp.messagingengine.com [204.75.18.201]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: jmtilli) by meesny.iki.fi (Postfix) with ESMTPSA id 4hvkm5703RzyS4; Wed, 30 Sep 2026 08:55:17 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=meesny; t=1790747718; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=v0WHvqPEy1zCdoeR4zoo3J7a0wQn2OXgPRqA4AplJPY=; b=mi89WtC16ViDEso6lptBHLrWYe4WmAkcOzvBYiG4IdBLL4cuul3g8kAb++WwgW4R31YxAX qpLPNQprQzpBsU5RZ5lhhxvgyIKdrSK43CLzaUGNY7TnotPueTdfIQRz5Srgu0qUHbgcL5 hA1PuBFvq1OWOaUUyYnEVl/9Z31O9H0= ARC-Seal: i=1; a=rsa-sha256; d=iki.fi; s=meesny; cv=none; t=1790747718; b=taouanStDp19rbXzAw6kFJv4hXOdAUFol/pe49jDLHWlDIl5lP4gyEI1E1kmoH6SDN+wjV J6eWoeIrxsjXltLNv+iMQok6m1359fzctQotlk6MF2vAt3sbjcF0P0S33RyvOG61AV/h16 rrANrQm4AEUCLald818xIgRIa08PTC8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=meesny; t=1790747718; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=v0WHvqPEy1zCdoeR4zoo3J7a0wQn2OXgPRqA4AplJPY=; b=nx/Hkgl5Civpx/g4A5wgbIqbjVpgLoxPdm/d7l6nl1xI+MB5tLixw91AtJUqg7PUDAjUj+ 9BsTrDdVQr0OA6boZNS0MVCsfhVgRof+bg8dtVDvChstq71Pt9Y9C4+wHAsvUH33aKIulp eSoZt9+VCzs2ZbSqZSukc5somAz05GA= ARC-Authentication-Results: i=1; ORIGINATING; auth=pass smtp.auth=jmtilli smtp.mailfrom=juha-matti.tilli@iki.fi Received: from ams-compute-02.internal (ams-compute-02.internal [10.64.2.62]) by mailfauth.ams.internal (Postfix) with ESMTP id B9DBB198003A; Wed, 30 Sep 2026 01:55:16 -0400 (EDT) Received: from ams-imap-13 ([10.64.2.33]) by ams-compute-02.internal (MEProxy); Wed, 30 Sep 2026 01:55:16 -0400 X-ME-Sender: X-ME-Proxy-Cause: dmFkZTFp4NH+YWpk8RRtOx7/9/eJYhhRF0wfwR+qn9fmA0oEIQrIu+sy7ZWXMsFF9LAvVM SzfwpA0Tf+EgBAQ3rHRnsEGdl4HiNVUiyvbIC4JFIhF1rdlZiPSv0L+N5KHe9Oqohxp70I ofLhf90YJnnXnyUNgykBjUrru4MOOiGzSHELeoY2UKCrZNeDPRp/0wWt53PTFKf3y6cUd3 zcNd434ipqiO8/tYVE0McZzgmOXQrmxVTOki7dlgcQ6L66mQSNNlCS+Nmwst3TClrhaDW+ jnL6bxTvP43a9NQjoQRsLlDqTjAbZmmdddYC1bEepu6oC5ImfqbchtR2bBvdPDUxnLIePg t89nxml+h4BBpA7zMiiztQorDh42JLvPo5ob+kM4IBUYS4ixZJO0khvcLOEQFWRThOg97U GjNQ1d0hR/hi1AD3FXPrTi0CSpRKReJgHpeSVxCh4AJ+UukwMJf7Glh8Gofd9EU6PMLhML /kf4v0ebmNLcaN8KFwZoIHqttW6IcxOmHE6TnPfD9gGes0ONvOyEdK6qkssOTuJ2/fGMbN 1G9LvVOBGdfV/7Um4zCbSUXfC5jwc1/oVMjBPHGsBAN2aNIJ/nZcaUeo70SVLCHdSOLwm3 s+SUPfDaQBVm768N7gxb72e0uQBNdIlUvFBJdpmPQPq40UL3UdF4h+Ko3JOQ X-ME-Proxy: Feedback-ID: i02414972:Fastmail Received: by mailuser.ams.internal (Postfix, from userid 501) id 73D7CF8008F; Wed, 30 Sep 2026 01:55:13 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ThreadId: A0G5p0OZ_htJ Date: Wed, 30 Sep 2026 08:54:53 +0300 From: "Juha-Matti Tilli" To: "Marcel Holtmann" , "Manivannan Sadhasivam" Cc: "Deepak Kumar Singh" , "David S . Miller" , "Eric Dumazet" , "Jakub Kicinski" , "Paolo Abeni" , "Simon Horman" , "Jeff Johnson" , linux-arm-msm@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, ath11k@lists.infradead.org, ath12k@lists.infradead.org, "Bjorn Andersson" , "Chris Lew" , "Raj Kumar Bhagat" , "Jeff Hugo" Message-Id: <6e0ed085-07d0-46f0-97dd-b8d942842e1f@app.fastmail.com> In-Reply-To: <10091679-7567-42C2-B77E-EFD95CEDD649@holtmann.org> References: <20260922-qrtr-multi-ep-v3-0-c00831e88957@oss.qualcomm.com> <20260922-qrtr-multi-ep-v3-2-c00831e88957@oss.qualcomm.com> <7aed969d-0868-4c9c-967e-7766dbba427e@oss.qualcomm.com> <13BFC5B0-77E6-48F2-B857-37686EA1DB2C@holtmann.org> <05e539f8-bb7c-4038-8a83-8ab0d1a5b917@app.fastmail.com> <10091679-7567-42C2-B77E-EFD95CEDD649@holtmann.org> Subject: Re: [PATCH v3 2/4] net: qrtr: Assign unique node id for MHI endpoints Content-Type: text/plain Content-Transfer-Encoding: 7bit On Tue, Sep 29, 2026, at 23:37, Marcel Holtmann wrote: > >> I'm still willing to submit a new version of that patchset originally by > >> Denis, if the kernel devs so decide that it's the way. For example, the > >> "radix tree of radix trees" approach could be replaced with a hash > >> table. > >> > >> There was also some criticism about a layering violation in storing the > >> endpoint id to mhi controller. However, maybe that could be reduced by > >> providing a correct abstraction around it, so that other code doesn't > >> touch the mhi controller structure directly. > >> > >> Other criticism for that patchset by Denis was its overt complexity. > >> Yes, it has more lines of code changed. > >> > >> This dual-card setup needs to be handled somehow, either by Denis's > >> patchset or by Manivannan's patchset. > >> > > > > I wish to go ahead with my series as it is simple and tested across the > > multi-WLAN setups. For concern around exposing the nid to userspace, I'll > > implement it in next version, thanks! > > actually no. Seems you have no plan on how to address the userspace problem. > > It would be useful to actually review the endpoint_id concept introduced by Denis since it has a userspace facing API. What is your plan? Are you planning to break all existing userspace code? Well, in defense of Manivannan's patchset it currently works for PCI+AHB setups better than the last version of that by Denis/Mihai/me (although I could easily fix that), and it may be simpler for userspace to continue using nid than having to bind to an endpoint, which requires more changes in userspace code. The userspace just needs to know the nid. BR, Juha-Matti