From: Joe Perches <joe@perches.com>
To: Jerome Pouiller <Jerome.Pouiller@silabs.com>,
linux-mmc@vger.kernel.org, Ulf Hansson <ulf.hansson@linaro.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mmc: core: Fix indentation
Date: Fri, 21 Feb 2020 06:36:56 -0800 [thread overview]
Message-ID: <6e0f3988435bf55df19af2873314f283f25f72c6.camel@perches.com> (raw)
In-Reply-To: <20200221104341.583028-1-Jerome.Pouiller@silabs.com>
On Fri, 2020-02-21 at 11:43 +0100, Jerome Pouiller wrote:
> sdio_single_irq_set() was indented with a mix of tabs and spaces.
[]
> diff --git a/drivers/mmc/core/sdio_irq.c b/drivers/mmc/core/sdio_irq.c
[]
> @@ -278,12 +278,12 @@ static void sdio_single_irq_set(struct mmc_card *card)
> if ((card->host->caps & MMC_CAP_SDIO_IRQ) &&
> card->host->sdio_irqs == 1)
> for (i = 0; i < card->sdio_funcs; i++) {
> - func = card->sdio_func[i];
> - if (func && func->irq_handler) {
> - card->sdio_single_irq = func;
> - break;
> - }
> - }
> + func = card->sdio_func[i];
> + if (func && func->irq_handler) {
> + card->sdio_single_irq = func;
> + break;
> + }
> + }
> }
Perhaps it'd be better to add braces around the for loop too.
---
drivers/mmc/core/sdio_irq.c | 15 ++++++++-------
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/drivers/mmc/core/sdio_irq.c b/drivers/mmc/core/sdio_irq.c
index 7ca7b9..3086ed 100644
--- a/drivers/mmc/core/sdio_irq.c
+++ b/drivers/mmc/core/sdio_irq.c
@@ -260,14 +260,15 @@ static void sdio_single_irq_set(struct mmc_card *card)
card->sdio_single_irq = NULL;
if ((card->host->caps & MMC_CAP_SDIO_IRQ) &&
- card->host->sdio_irqs == 1)
+ card->host->sdio_irqs == 1) {
for (i = 0; i < card->sdio_funcs; i++) {
- func = card->sdio_func[i];
- if (func && func->irq_handler) {
- card->sdio_single_irq = func;
- break;
- }
- }
+ func = card->sdio_func[i];
+ if (func && func->irq_handler) {
+ card->sdio_single_irq = func;
+ break;
+ }
+ }
+ }
}
/**
prev parent reply other threads:[~2020-02-21 14:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-21 10:43 Jerome Pouiller
2020-02-21 14:36 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e0f3988435bf55df19af2873314f283f25f72c6.camel@perches.com \
--to=joe@perches.com \
--cc=Jerome.Pouiller@silabs.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®