From: Jinjie Ruan <ruanjinjie@huawei.com>
To: Thomas Gleixner <tglx@linutronix.de>, <maz@kernel.org>,
<joey.gouly@arm.com>, <mark.rutland@arm.com>, <will@kernel.org>,
<catalin.marinas@arm.com>, <linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] irqchip/gic-v3: Remove asmlinkage for gic_handle_irq()
Date: Mon, 29 Jul 2024 10:36:57 +0800 [thread overview]
Message-ID: <6e10605a-e45b-b683-afe1-27c2e3a51b4c@huawei.com> (raw)
In-Reply-To: <87zfq3tce4.ffs@tglx>
On 2024/7/27 17:25, Thomas Gleixner wrote:
> On Sat, Jul 27 2024 at 15:36, Jinjie Ruan wrote:
>> Since commit 064dbfb41691 ("arm64: entry: convert IRQ+FIQ handlers to C"),
>> the gic_handle_irq() is only called by C functions, so remove
>> the asmlinkage.
>>
>> Fixes: 064dbfb41691 ("arm64: entry: convert IRQ+FIQ handlers to C")
>> Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
>
> Right. Can we please fix all of that and be done with it?
>
> # git grep -l asmlinkage drivers/irqchip/ | xargs grep set_handle_irq
>
> should find the remaining leftovers of asmlinkage.
You are right，handle_arch_irq() are all only called in C now, we can all
remove the asmlinkage.
>
> Thanks,
>
> tglx
next prev parent reply other threads:[~2024-07-29 2:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-27 7:36 Jinjie Ruan
2024-07-27 9:25 ` Thomas Gleixner
2024-07-29 2:36 ` Jinjie Ruan [this message]
2024-07-27 9:35 ` Marc Zyngier
2024-07-27 9:40 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e10605a-e45b-b683-afe1-27c2e3a51b4c@huawei.com \
--to=ruanjinjie@huawei.com \
--cc=catalin.marinas@arm.com \
--cc=joey.gouly@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®