From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757118AbdJKDqS (ORCPT ); Tue, 10 Oct 2017 23:46:18 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:7965 "EHLO szxga04-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757045AbdJKDqR (ORCPT ); Tue, 10 Oct 2017 23:46:17 -0400 Subject: Re: [PATCH] f2fs/crypto: drop crypto key at evict_inode only To: Jaegeuk Kim , , , References: <20171010175646.9211-1-jaegeuk@kernel.org> From: Chao Yu Message-ID: <6e12a05c-eba6-e59c-fce2-d9c197dfe48c@huawei.com> Date: Wed, 11 Oct 2017 11:44:34 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20171010175646.9211-1-jaegeuk@kernel.org> Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020206.59DD9404.004C,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 076dec7d317f456a3cf87cdc0df581ce Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017/10/11 1:56, Jaegeuk Kim wrote: > This patch avoids dropping crypto key in f2fs_drop_inode, so we can guarantee > it happens only at evict_inode. > > Signed-off-by: Jaegeuk Kim Reviewed-by: Chao Yu Thanks, > --- > fs/f2fs/super.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c > index dc05b16df514..f10a1b1380c2 100644 > --- a/fs/f2fs/super.c > +++ b/fs/f2fs/super.c > @@ -717,7 +717,6 @@ static int f2fs_drop_inode(struct inode *inode) > > sb_end_intwrite(inode->i_sb); > > - fscrypt_put_encryption_info(inode, NULL); > spin_lock(&inode->i_lock); > atomic_dec(&inode->i_count); > } >