From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5488C04A6A for ; Wed, 9 Aug 2023 14:31:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233354AbjHIOb3 (ORCPT ); Wed, 9 Aug 2023 10:31:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59592 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229743AbjHIOb1 (ORCPT ); Wed, 9 Aug 2023 10:31:27 -0400 Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 27F3B170B for ; Wed, 9 Aug 2023 07:31:26 -0700 (PDT) Received: by mail-wr1-x431.google.com with SMTP id ffacd0b85a97d-317f1c480eeso2169555f8f.2 for ; Wed, 09 Aug 2023 07:31:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1691591484; x=1692196284; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=tFjpoWiKrYc/7swWNiDoznRKv0z/2+v/fxMff/HbFKs=; b=MYTFsaKlHMyoX/W9hD4vnmL4WV1ZgMtFu3FpiM9k2RVc0hVapCNWC2xnhYasMZvvRK Bk7j0dekxTmcoPrsIVZj8zVVXaokd5jJ/ThBL+8SZh7rne6m0tU53qc3wmGQSCm+piv6 wFCj7WYKEU+1w754sUq2ehVVxUGft/PwNDjP6p169VH2COKSiBSl27k4JnYSRulSclj3 73GFX0bR5jQnfTaHvfLMyyFHdDu+15rlgoayAJCdlrU4c0cJutXs7CjY/UFlrJgsSKTl /HmB3o8XYjuypIAy2ZgeaBdfV5Fp4dZB8LNiG3pSxDiIMJnd/w4QhIIQ3p89ba4N2kqH BkOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691591484; x=1692196284; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=tFjpoWiKrYc/7swWNiDoznRKv0z/2+v/fxMff/HbFKs=; b=kTu0RXj3VV8aUZyw/KIj2KXWggaIrkqa4Z6KilWTtdgBhQoeCIQhGlY7SkM9ZTlnwP RzOr6Tsg5x5m4Use5tg7sMwLy2DwidOg8FGPpEMsCZcZtGLIFfKtqOoaC4QLivxCUP6a Gmveqbo5XAv6T0oLr8uYWwtQhGS4JHeOp/4HkKOX6w2QgkiGS2p80si6rZunEnW9B53r OZWd79kKDDPou4rC2krw92u3fgVXGYxzWkyOSyAnQXaLsInSYwxe9CDZ7kb57cZiO103 iWLAw1lRKF06chuH9C2fmm9T+xOjwSiRji+Gf4xaErL8IiMWoC5H/spYXlLpY/t+lSIS JKuw== X-Gm-Message-State: AOJu0Yya3wcEptM/hEu567ekQ3YFxkugLNDp6+40YrjNecOLX+Ke6oJk tEIVXHkXKJQWF2DOwJuvlRdD9A== X-Google-Smtp-Source: AGHT+IHY0SyoRhCDAjJpmtQj6Df328GUTUN9z5VZLOgfANwBi/3guZ/uk3CPOMM3JxD0ngYv90AXAA== X-Received: by 2002:adf:e80b:0:b0:317:5cc7:794b with SMTP id o11-20020adfe80b000000b003175cc7794bmr2061578wrm.13.1691591484561; Wed, 09 Aug 2023 07:31:24 -0700 (PDT) Received: from [192.168.1.20] ([178.197.222.113]) by smtp.gmail.com with ESMTPSA id x12-20020adfec0c000000b0031274a184d5sm16881086wrn.109.2023.08.09.07.31.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Aug 2023 07:31:24 -0700 (PDT) Message-ID: <6e16e580-b8bb-d6c2-41ed-bcaa6d407b95@linaro.org> Date: Wed, 9 Aug 2023 16:31:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH v2 1/2] dt-bindings: input: cirrus,cs40l50: Support for CS40L50 Content-Language: en-US To: James Ogletree , dmitry.torokhov@gmail.com Cc: Fred Treven , Ben Bright , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Lee Jones , Eddie James , Jacky Bai , Arnd Bergmann , Jeff LaBundy , Markus Schneider-Pargmann , Randy Dunlap , ChiYuan Huang , Jean Delvare , Joel Stanley , patches@cirrus.com, linux-input@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230809135313.731706-1-james.ogletree@cirrus.com> <20230809135313.731706-2-james.ogletree@cirrus.com> From: Krzysztof Kozlowski In-Reply-To: <20230809135313.731706-2-james.ogletree@cirrus.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/08/2023 15:53, James Ogletree wrote: > Introduce device tree bindings for the initial commit > of the CS40L50 driver. > > Signed-off-by: James Ogletree > --- > .../bindings/input/cirrus,cs40l50.yaml | 77 +++++++++++++++++++ > MAINTAINERS | 9 +++ > 2 files changed, 86 insertions(+) > create mode 100644 Documentation/devicetree/bindings/input/cirrus,cs40l50.yaml > > diff --git a/Documentation/devicetree/bindings/input/cirrus,cs40l50.yaml b/Documentation/devicetree/bindings/input/cirrus,cs40l50.yaml > new file mode 100644 > index 000000000000..5437c6beb1b3 > --- /dev/null > +++ b/Documentation/devicetree/bindings/input/cirrus,cs40l50.yaml > @@ -0,0 +1,77 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/input/cirrus,cs40l50.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Cirrus Logic CS40L50 Advanced Haptic Driver > + > +maintainers: > + - James Ogletree > + > +description: > + CS40L50 is a Haptic Driver with Waveform Memory DSP > + and Closed-Loop Algorithms > + > +properties: > + compatible: > + enum:This is a friendly reminder during the review process. It seems my previous comments were not fully addressed. Maybe my feedback got lost between the quotes, maybe you just forgot to apply it. Please go back to the previous discussion and either implement all requested changes or keep discussing them. Thank you. > + - cirrus,cs40l50 > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + reset-gpios: > + maxItems: 1 > + > + VA-supply: No improvements... This is a friendly reminder during the review process. It seems my previous comments were not fully addressed. Maybe my feedback got lost between the quotes, maybe you just forgot to apply it. Please go back to the previous discussion and either implement all requested changes or keep discussing them. Thank you. Best regards, Krzysztof