mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Karoly Pados" <pados@pados.hu>
To: "Johan Hovold" <johan@kernel.org>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Loic Poulain" <loic.poulain@linaro.org>
Subject: Re: [PATCH v4] USB: serial: ftdi_sio: implement GPIO support for FT-X devices
Date: Tue, 18 Sep 2018 10:27:58 +0000	[thread overview]
Message-ID: <6e1a6550cbf886cb7dcfea641244bdcf@pados.hu> (raw)
In-Reply-To: <20180918094515.GD3943@localhost>

> We'll get this into 4.20 either way, there's plenty of time. But I guess
> we could play it safe and always register four pins, and if/when we get
> more info about FT234XD we can implement registering just one pin in a
> follow up patch.
> 
> Sounds good? If so I'll just merge your v5 (registering four pins) next
> week.

Ofc, thank you.

>> Does that mean something can call into our module while this method is running?
>> If not, I'm clueless about the possible race here.
> 
> Correct, you can get gpio callbacks until the gpio chip has been
> deregistered (anything coming in after that would be a gpiolib bug).

I'm just puzzled by the fact that this can still happen even while the port 
removal code is running. It also makes me ask the question what else here can
run in parallel. Don't we need mutexes here-and-there in the ftx gpio functions too
in this case? Or does gpiolib make sure to serialize multiple pin and direction
setting calls?

Thank you,
Karoly

  parent reply	other threads:[~2018-09-18 10:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-16 17:58 Karoly Pados
2018-09-18  9:16 ` Johan Hovold
2018-09-18  9:35 ` Karoly Pados
2018-09-18  9:45   ` Johan Hovold
2018-09-18 10:27   ` Karoly Pados [this message]
2018-09-18 11:19     ` Johan Hovold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6e1a6550cbf886cb7dcfea641244bdcf@pados.hu \
    --to=pados@pados.hu \
    --cc=gregkh@linuxfoundation.org \
    --cc=johan@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=loic.poulain@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®