From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3AEC4EB64DC for ; Tue, 18 Jul 2023 15:06:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233135AbjGRPG4 (ORCPT ); Tue, 18 Jul 2023 11:06:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45546 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232479AbjGRPGx (ORCPT ); Tue, 18 Jul 2023 11:06:53 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id D88F29D; Tue, 18 Jul 2023 08:06:52 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1FC6C2F4; Tue, 18 Jul 2023 08:07:36 -0700 (PDT) Received: from [10.57.33.56] (unknown [10.57.33.56]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3555C3F67D; Tue, 18 Jul 2023 08:06:51 -0700 (PDT) Message-ID: <6e1bdf71-7601-237d-3582-498352d8e0e0@arm.com> Date: Tue, 18 Jul 2023 16:06:49 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v2] hwtracing: coresight: Explicitly include correct DT includes To: Rob Herring , Mike Leach , James Clark , Leo Yan , Alexander Shishkin Cc: devicetree@vger.kernel.org, coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20230718143124.1065949-1-robh@kernel.org> From: Suzuki K Poulose In-Reply-To: <20230718143124.1065949-1-robh@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18/07/2023 15:31, Rob Herring wrote: > The DT of_device.h and of_platform.h date back to the separate > of_platform_bus_type before it as merged into the regular platform bus. > As part of that merge prepping Arm DT support 13 years ago, they > "temporarily" include each other. They also include platform_device.h > and of.h. As a result, there's a pretty much random mix of those include > files used throughout the tree. In order to detangle these headers and > replace the implicit includes with struct declarations, users need to > explicitly include the correct includes. > > Signed-off-by: Rob Herring > --- > v2: > - Fix double include of of.h > --- > drivers/hwtracing/coresight/coresight-core.c | 2 +- > drivers/hwtracing/coresight/coresight-platform.c | 2 -- > 2 files changed, 1 insertion(+), 3 deletions(-) Rob, Thanks for the updated version, I will queue this. Suzuki