mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Shuah Khan <skhan@linuxfoundation.org>
To: Rohan Lambture <rohanlambture13@gmail.com>,
	trenn@suse.com, shuah@kernel.org, jwyatt@redhat.com,
	jkacur@redhat.com
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
	Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH] cpupower: Add cpu_start()/cpu_stop() callbacks for monitors
Date: Wed, 18 Jun 2025 16:44:54 -0600	[thread overview]
Message-ID: <6e1fe001-dd21-43fd-ba7b-aae6df819fdd@linuxfoundation.org> (raw)
In-Reply-To: <94c3faee898b5436cc0b837c6778011a060b8468.1749480264.git.rohanlambture13@gmail.com>

On 6/9/25 08:49, Rohan Lambture wrote:
> Move per-CPU logic from inside individual monitors to the main
> monitoring framework by adding cpu_start() and cpu_stop() callback
> functions to the cpuidle_monitor structure.
> 
> This refactoring allows the framework to handle per-CPU scheduling
> and gives higher priority to fork_it operations as mentioned in
> the TODO. Individual monitors now only need to implement per-CPU
> initialization and cleanup logic without managing the CPU iteration
> themselves.
> 
> Changes made:
> - Add cpu_start()/cpu_stop() function pointers to cpuidle_monitor struct
> - Update monitoring framework to call per-CPU callbacks for each CPU
> - Refactor cpuidle_sysfs and mperf monitors to use new callback pattern
> - Maintain backward compatibility for monitors without per-CPU callbacks
> 
> This addresses the TODO item: "Add cpu_start()/cpu_stop() callbacks
> for monitor -> This is to move the per_cpu logic from inside the
> monitor to outside it."

Please share details on how this changes has been tested.
Also run checkpatch - there are a few warnings.

> 
> Signed-off-by: Rohan Lambture <rohanlambture13@gmail.com>
> ---

thanks,
-- Shuah

      reply	other threads:[~2025-06-18 22:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-09 14:49 Rohan Lambture
2025-06-18 22:44 ` Shuah Khan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6e1fe001-dd21-43fd-ba7b-aae6df819fdd@linuxfoundation.org \
    --to=skhan@linuxfoundation.org \
    --cc=jkacur@redhat.com \
    --cc=jwyatt@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rohanlambture13@gmail.com \
    --cc=shuah@kernel.org \
    --cc=trenn@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®