From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751989AbdJBPNK (ORCPT ); Mon, 2 Oct 2017 11:13:10 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33076 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751969AbdJBPNJ (ORCPT ); Mon, 2 Oct 2017 11:13:09 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 8312B7E438 Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=prarit@redhat.com Subject: Re: [PATCH 0/3 v2 RESEND] x86/smpboot: Cleanup logical package ID To: linux-kernel@vger.kernel.org References: <1506430406-26121-1-git-send-email-prarit@redhat.com> Cc: Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, Peter Zijlstra , Andi Kleen , Dave Hansen , Piotr Luc , Kan Liang , Borislav Petkov , Stephane Eranian , Arvind Yadav , Andy Lutomirski , Christian Borntraeger , "Kirill A. Shutemov" , Tom Lendacky , He Chen , Mathias Krause , Tim Chen , Vitaly Kuznetsov From: Prarit Bhargava Message-ID: <6e211b46-b30e-bf4c-59b4-7abd72ad1716@redhat.com> Date: Mon, 2 Oct 2017 11:13:05 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <1506430406-26121-1-git-send-email-prarit@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Mon, 02 Oct 2017 15:13:09 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/26/2017 08:53 AM, Prarit Bhargava wrote: > Sending to wider audience. I originally sent this to only the people Andi > had cc'd. Here's an example of the panic: smpboot: Booting Node 1, Processors #1 OK smpboot: Package 1 of CPU 1 exceeds BIOS package data 1. ------------[ cut here ]------------ kernel BUG at arch/x86/kernel/cpu/common.c:1087! invalid opcode: 0000 [#1] SMP Modules linked in: CPU: 1 PID: 0 Comm: swapper/1 Not tainted 4.14.0-rc2+ #4 > > Andi posted two patches to clean up the logical package ID, and I posted a > bug fix for systems which boot with less than than the maximum core count. > If I take his changes into account the code base ends up with a significant > cleanup. I am reposting his patches here. > > I boot tested this using max_cpus and nr_cpus, as well as booting on > systems which panic without the fix in 3/3. > > ---8<--- > > Cleanup the logical package ID code by storing the logical package ID in > the cpuinfo_x86 struct and calculating the maximum logical package ID > after all the CPUs have been enumerated. > > Signed-off-by: Prarit Bhargava > Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: "H. Peter Anvin" > Cc: x86@kernel.org > Cc: Peter Zijlstra > Cc: Andi Kleen > Cc: Dave Hansen > Cc: Piotr Luc > Cc: Kan Liang > Cc: Borislav Petkov > Cc: Stephane Eranian > Cc: Prarit Bhargava > Cc: Arvind Yadav > Cc: Andy Lutomirski > Cc: Christian Borntraeger > Cc: "Kirill A. Shutemov" > Cc: Tom Lendacky > Cc: He Chen > Cc: Mathias Krause > Cc: Tim Chen > Cc: Vitaly Kuznetsov > > Andi Kleen (2): > perf/x86/intel/uncore: Cache logical pkg id in uncore driver > x86/topology: Avoid wasting 128k for package id array > > Prarit Bhargava (1): > x86/smpboot: Fix __max_logical_packages estimate > > arch/x86/events/intel/uncore.c | 1 + > arch/x86/events/intel/uncore.h | 1 + > arch/x86/events/intel/uncore_snbep.c | 2 +- > arch/x86/include/asm/processor.h | 6 +- > arch/x86/kernel/smpboot.c | 113 +++++++++++------------------------ > 5 files changed, 42 insertions(+), 81 deletions(-) >