mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Shuah Khan <skhan@linuxfoundation.org>
To: Thorsten Blum <thorsten.blum@toblux.com>, Shuah Khan <shuah@kernel.org>
Cc: Mykola Lysenko <mykolal@fb.com>,
	Martin KaFai Lau <martin.lau@linux.dev>,
	linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
	Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH] tools: selftests: Remove unnecessary semicolons
Date: Tue, 20 Feb 2024 16:48:23 -0700	[thread overview]
Message-ID: <6e31af22-b1b5-43d6-85ee-6818dc8e8eac@linuxfoundation.org> (raw)
In-Reply-To: <20240213122317.1883-2-thorsten.blum@toblux.com>

On 2/13/24 05:23, Thorsten Blum wrote:
> Remove unnecessary semicolons reported by Coccinelle/coccicheck and the
> semantic patch at scripts/coccinelle/misc/semicolon.cocci.
> 
> Signed-off-by: Thorsten Blum <thorsten.blum@toblux.com>
> ---
>   tools/testing/selftests/bpf/benchs/bench_local_storage_create.c | 2 +-
>   tools/testing/selftests/kvm/access_tracking_perf_test.c         | 2 +-
>   tools/testing/selftests/timers/nanosleep.c                      | 2 +-
>   tools/testing/selftests/timers/nsleep-lat.c                     | 2 +-
>   tools/testing/selftests/timers/set-timer-lat.c                  | 2 +-
>   5 files changed, 5 insertions(+), 5 deletions(-)
> 

Thank you for finding the problems and fixing them.

Please split these up and generate separate patches.
Run getmaintainers.pl to get the right people to send the
patch.

Taking all these changes in one single patch will result in
conflicts between the trees and more importantly if changes
to one file have to reverted for some reason, it makes it
easier have separate patches.

thanks,
-- Shuah

      reply	other threads:[~2024-02-20 23:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-13 12:23 Thorsten Blum
2024-02-20 23:48 ` Shuah Khan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6e31af22-b1b5-43d6-85ee-6818dc8e8eac@linuxfoundation.org \
    --to=skhan@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=martin.lau@linux.dev \
    --cc=mykolal@fb.com \
    --cc=shuah@kernel.org \
    --cc=thorsten.blum@toblux.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®