Re: [PATCH v2 1/2] dt-bindings: pinctrl: qcom: Add SM4450 pinctrl

[Tengfei Fan <quic_tengfan@quicinc.com>]

在 9/15/2023 10:59 PM, Rob Herring 写道:
> On Fri, Sep 15, 2023 at 03:30:16PM +0800, Tengfei Fan wrote:
>>
>>
>> 在 9/15/2023 3:04 PM, Krzysztof Kozlowski 写道:
>>> On 15/09/2023 03:58, Tengfei Fan wrote:
>>>> Add device tree binding Documentation details for Qualcomm SM4450
>>>> TLMM device.
>>>>
>>>> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
>>>
>>> ...
>>>
>>>> +
>>>> +patternProperties:
>>>> +  "-state$":
>>>> +    oneOf:
>>>> +      - $ref: "#/$defs/qcom-sm4450-tlmm-state"
>>>> +      - patternProperties:
>>>> +          "-pins$":
>>>> +            $ref: "#/$defs/qcom-sm4450-tlmm-state"
>>>> +        additionalProperties: false
>>>> +
>>>> +$defs:
>>>> +  qcom-sm4450-tlmm-state:
>>>> +    type: object
>>>> +    description:
>>>> +      Pinctrl node's client devices use subnodes for desired pin configuration.
>>>> +      Client device subnodes use below standard properties.
>>>> +    $ref: qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state
>>>> +    unevaluatedProperties: false
>>>> +
>>>> +    properties:
>>>> +      pins:
>>>> +        description:
>>>> +          List of gpio pins affected by the properties specified in this
>>>> +          subnode.
>>>> +        items:
>>>> +          oneOf:
>>>> +            - pattern: "^gpio([0-9]|[1-9][0-9]|1[0-9][0-9])$"
>>>
>>> This is still wrong. How many GPIOs do you have? Please open existing
>>> bindings for recent device (e.g. sm8550) and look how it is done there.
>> yes, will update to "^gpio([0-9]|[1-9][0-9]|1[0-2][0-5])$".
> 
> What about 106, 116, etc.?
> 
> Rob
understand more, need "^gpio([0-9]|[1-9][0-9]|1[0-1][0-9]|12[0-5])$".

-- 
Thx and BRs,
Tengfei Fan