From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6FD613B95E7 for ; Wed, 18 Mar 2026 10:11:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773828666; cv=none; b=s4LuubV4ixa1AoiXdsMNYmO/bkvYIojxmujsR24UFcLsYcbNz8UpBNAEM0I0TsT8+ThBs/dqMkHvbbsfFzn68cQEZDMFY5ckKBOzkTg4+urt93KfsKhDMg+nKVn8imtf7PrX4WB3pPPoA9IwHwVyUA3myy/DgEXeNJjg/njvWQM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773828666; c=relaxed/simple; bh=1YE/OpnL+YYJMOI34XJtZZ+UqZifHDP5gCkFue5ZcqE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=BfwudtRcr2oXgAy0WhQg5u0whZ5ZHtekwkDd170wNe/CGwcpc2o7zy8uxBo4Su9rBdnNkFJykdV6mp38cCuGjDW00cdmH8FesgMRvWLttrcLFd/xxtSv23lLiOGPdfsJX0QUK1+CuZnGB5l1yOFdjGPckUW79wO3008HQgyIifg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=R+hnk3mf; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=e3qKcVPy; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="R+hnk3mf"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="e3qKcVPy" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62I6ZEZ32878100 for ; Wed, 18 Mar 2026 10:11:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= sPUWi4lpjkv2z22C9WzaZYDxTHjKKgtgORTt4qzKFTw=; b=R+hnk3mfNszSk4p8 N5fFH+rCWKMpOOLzLHyYO7TRc7F4n83sw3eQfObUfnibjaaPtQs2g5XDCQ0V9Ifb TQ8EFrGV22zwDCE6ATqAd8DnykiJ/YW3nz/u3bCT1QG3VN5Y8OoxI7kO2xStwiDS Sbnib/7S5LuXADemhzdKSfAe3vumBepBwmA3PtYnLP5Hnj5YYQOv1CN1WF6VtqFT Ju7I77Gd7Q/J5teMapi0B/UPuY3hruhMSEtQYAWfwsZ7kLsCnWy3v4VCwGVBjeyr N/yW4OS97xoZYNQvwnxEj2eArl/F7UgcT7dZFi6MCqyJdtgUqVnnvpgij3qmCA+v Esj8Mg== Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cypwr0ypn-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 18 Mar 2026 10:11:00 +0000 (GMT) Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-89c471045c9so26349086d6.2 for ; Wed, 18 Mar 2026 03:11:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773828659; x=1774433459; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=sPUWi4lpjkv2z22C9WzaZYDxTHjKKgtgORTt4qzKFTw=; b=e3qKcVPyrmUlmVU7meLu9UVKAVUHXkp+yaMcGaU63+Wl3rlcfkf+dpBI93MisEdpW3 JuRQFj2LZNapUyOGWM+LrK8zNK8MgJNMYmnCFKICxc9BlzYcOYsjBdF0TT9+zSuuvdCv VG9Pccb7OLFm6fnanDcMbNgcubzq1Et424cbqhZHi0ZqefQhQ6afo+k73f4RneIrPKQV ns38zKk715PpA4iCOBdiAhJfd0ruXPJOLEyMefnS25plpk2IJvdOgWzHXuTd22RtsCEC NUknMfRc3DXy9S4IlucihlCmkUfH7mkrWrJqb87gT2H1ifDeuVb3DRNyh+boPs5FTOx3 ThAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773828659; x=1774433459; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=sPUWi4lpjkv2z22C9WzaZYDxTHjKKgtgORTt4qzKFTw=; b=Dj7XkTB5G0G2dhs04IybphMakycguLnCCT2NEz5zxcmGiDnLcAbM2Ff6WMfqfGNjKa InTmO/XmsfkkWTy7Knng3We1OEm7pdneNO7Ggk2pndNsLcvNrUbCYUubeb9semSd2AWf i6bP8jVY5iCPumLPO1ZfpGG4ANSqJ10LfWPaJL0WfB2PKt+bXjO6CGcfp0jqnDtVRe1w qMv69QLcQCdICYLECxDlwaR9gUxdvG4cD8CgsP18ge9xDWDGqh324IEvKyeGlP9eghWJ zI3HQPXUYZ2Nxw83cas5arav7x04giVmISMccu5cX9QS55bXva/YYWQjYrGv7XERtHQ9 v7qA== X-Forwarded-Encrypted: i=1; AJvYcCWlxNbWwV6ab1D7T9OJczWymDfWL949+ScvixuYQfG6TM5UXqQ+zAkGqdh68YnK3q1q4zCqJu2m926fdJM=@vger.kernel.org X-Gm-Message-State: AOJu0Yw/4VYzoo6gl6Ox0ivMO8efRoHQtqkAQ44f+moFVuU1LPvExrCo LIQCXz/ZXiJIq2AmeLCpMvPtjWck3I/yTSf7ltJzoXfkgpYOAxKwm4VXAGTeKGu0pC+LkAwj3tL M+3gFKcQ7vk3Pro6hjhfoUHPQ2ztNKhhU9/Er7oGhQhr4bqjx7PAu9GTJW4k5LYhyKhc= X-Gm-Gg: ATEYQzy7DUyj34BkkqLQo14xMHIMZ8rtXM19mmXSEEWmCsupy1vlVONJA3JFddMS+Ue ACfF4xHLCgWq/41/WZUqQTbhsdyTpmMrkt0B78Om7u0l0XgHGQuMH2raLCproGEgEKAJ8lRhHoI F79wMVyQwHMkKRuzjHoGooGHEsZswEBLPP4IFrUBUQJfuYfZfNGWbVvqYGDTocnX1DhStqPCIPA LL6QeKRA/oQ9mo0Hau2xxSRCNkzrJ+nCkdz+11L2esX2dqDrpmuoIo/h3oHy3zWXQo2mRsUfUES xGEdU4KFTE+v2criJD46F+mamMtl3EHUl+PAFIdEgSSH3r90N1btlP7JUcdurqSwQcETceeVBUj SEQvpTtXd3V9v1SGqB/RIjm7LpbQRBy0uHuv58oPZ9SZQ8knu8TZJrvPi7BRPDL5G+lrDQTwNxM Cn43g= X-Received: by 2002:ad4:5ae3:0:b0:89c:5135:e369 with SMTP id 6a1803df08f44-89c6b592055mr32045426d6.3.1773828659477; Wed, 18 Mar 2026 03:10:59 -0700 (PDT) X-Received: by 2002:ad4:5ae3:0:b0:89c:5135:e369 with SMTP id 6a1803df08f44-89c6b592055mr32045126d6.3.1773828659065; Wed, 18 Mar 2026 03:10:59 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b97f17410aesm174296466b.62.2026.03.18.03.10.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Mar 2026 03:10:58 -0700 (PDT) Message-ID: <6e32e5ac-bdc4-4745-b819-0f409a6f6891@oss.qualcomm.com> Date: Wed, 18 Mar 2026 11:10:56 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] arm64: dts: qcom: Add qcs9075-radxa-airbox-q900 To: Mecid Urganci , andersson@kernel.org, konradybcio@kernel.org Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, richardcochran@gmail.com, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org References: <20260318083621.470826-1-mecid@mecomediagroup.de> <20260318083621.470826-3-mecid@mecomediagroup.de> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260318083621.470826-3-mecid@mecomediagroup.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=bIcb4f+Z c=1 sm=1 tr=0 ts=69ba7a34 cx=c_pps a=oc9J++0uMp73DTRD5QyR2A==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=ksxQWNrZAAAA:8 a=saThlYE7jayycMPKYI0A:9 a=QEXdDO2ut3YA:10 a=iYH6xdkBrDN1Jqds4HTS:22 a=l7WU34MJF0Z5EO9KEJC3:22 X-Proofpoint-ORIG-GUID: UOQuBMlf6SPCOlxRK89J3-l7o4zxEgWk X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzE4MDA4NiBTYWx0ZWRfXxxm4D6KZHDp3 4U1DwAM+V8rQOREr7BntPYo8DcrrXi39oGw6J8x0q+phFyIxW6yEfuJCR4pbjCugdX+9H2JAyLp 34G3i3AV6IjYtjpdyox8U2KJjRuimUvIFQZMNyR/WmGCzt3RLvVJZIjSIrINqV9R4rmMEPsekq0 Ou24hQibGdzkQ6R7hP2SRkQe7sKSj6kt7K+AFmVQi/xEGdyHyLsBvLdTyiES5J3PPjjym73Vwl0 yNBQmKAvijlduU1LNLsHuh70afO6jFQmyIgQj0PYlzSvr8SudhVT3ZR2Mqt9QOJtyaFOjm133UC G0HDslGXLqYrYNOtHAnybAUK/CZrDhcuX9xTN28NXut0/GV5oPrpE5DvGorZe9dmxUzfI3mIlFy wwLYYj0URSWQGdNMQ6wR/5UWHmJtIhu/ue45WMyy03OXukFz8nz4qRIN1pNdnNgeIQZjcpva4gi lG/4m5KwjSn3hg6uVoA== X-Proofpoint-GUID: UOQuBMlf6SPCOlxRK89J3-l7o4zxEgWk X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-18_01,2026-03-17_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 impostorscore=0 malwarescore=0 adultscore=0 lowpriorityscore=0 clxscore=1015 priorityscore=1501 bulkscore=0 phishscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603180086 On 3/18/26 9:36 AM, Mecid Urganci wrote: > Add device tree support for the Radxa AirBox Q900 board based on the > Qualcomm QCS9075 SoC (Lemans Family). > > This board features HDMI 2.0 via dp0, 2x USB 3.1 Gen 2 ports, > 2x 2.5GbE Ethernet ports and onboard UFS storage. > > Further information: https://radxa.com/products/fogwise/airbox-q900/ > > Functionality has been tested and confirmed working via an Armbian > Debian Trixie build. > > Signed-off-by: Mecid Urganci > Made-with: Cursor > --- [...] > + gpio_leds: gpio-leds { Please strip unused labels > + compatible = "gpio-leds"; > + pinctrl-names = "default"; > + pinctrl-0 = <&status_led_state>, <&power_led_state>; property-n property-names in this order, file-wide, please [...] > + vreg_l4c: ldo4 { > + regulator-name = "vreg_l4c"; > + regulator-min-microvolt = <1200000>; > + regulator-max-microvolt = <1200000>; > + regulator-initial-mode = ; > + /* > + * FIXME: This should have regulator-allow-set-load but > + * we're getting an over-current fault from the PMIC > + * when switching to LPM. > + */ Are you actually experiencing that, or is that a copy-pasta? [...] > +&i2c15 { > + clock-frequency = <400000>; > + status = "okay"; Please uniformly keep a \n before 'status' [...] > +&gpu_zap_shader { > + firmware-name = "qcom/sa8775p/a663_zap.mbn"; > +}; > + > +&iris { > + firmware-name = "qcom/vpu/vpu30_p4_s6.mbn"; > + status = "okay"; > +}; Those are only Qualcomm-signed (i.e. not vendor-signed) - are you using the ones from linux-firmware? [...] > +&remoteproc_adsp { > + firmware-name = "qcom/sa8775p/adsp.mbn"; Notably the ADSP firmware normally contains board-specific modifications.. [...] > + power_led_state: power-led-state { > + pins = "gpio98"; > + function = "gpio"; > + output-high; You're already manipulating this pin from the gpio-leds node, no need > + bias-pull-up; pull-up of an active-high pin sounds odd Konrad