From: Luis Oliveira <Luis.Oliveira@synopsys.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>,
Luis Oliveira <Luis.Oliveira@synopsys.com>
Cc: Wolfram Sang <wsa@the-dreams.de>,
Rob Herring <robh+dt@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
Jarkko Nikula <jarkko.nikula@linux.intel.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
linux-i2c <linux-i2c@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Ramiro Oliveira <Ramiro.Oliveira@synopsys.com>,
Joao Pinto <Joao.Pinto@synopsys.com>,
<CARLOS.PALMINHA@synopsys.com>
Subject: Re: [PATCH v11 5/6] i2c: designware: add SLAVE mode functions
Date: Wed, 14 Jun 2017 14:06:45 +0100 [thread overview]
Message-ID: <6e332d71-1891-21aa-4479-b91a7550f8af@synopsys.com> (raw)
In-Reply-To: <CAHp75VeHoUrq-PfayNZYGP0f-bbnKQQEN4uMBg6ZASJs46b_PQ@mail.gmail.com>
On 14-Jun-17 13:20, Andy Shevchenko wrote:
> On Wed, Jun 14, 2017 at 1:43 PM, Luis Oliveira
> <Luis.Oliveira@synopsys.com> wrote:
>> - Changes in Kconfig to enable I2C_DESIGNWARE_SLAVE support
>> - Slave functions added to core library file
>> - Slave abort sources added to common source file
>> - New driver: i2c-designware-slave added
>> - Changes in the Makefile to compile the I2C_DESIGNWARE_SLAVE module
>> when supported by the architecture.
>>
>> All the SLAVE flow is added but it is not enabled via platform
>> driver.
>
>> + //~ if (stat & DW_IC_INTR_TX_OVER)
>> + //~ dw_readl(dev, DW_IC_CLR_TX_OVER);
>
> If you are going to ignore reviewers' comments you will delay your
> work to be applied.
>
Im so sorry. I was doing some tests on the irq_handler and used the wrong branch
to create the patchset.
Believe me I've looked for mistakes like this but I've read the code so many
times I don't think I can see the obvious anymore.
> Certainly you are about to miss v4.13.
>
next prev parent reply other threads:[~2017-06-14 13:07 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-14 10:43 [PATCH v11 0/6] i2c: designware: add I2C SLAVE support Luis Oliveira
2017-06-14 10:43 ` [PATCH v11 1/6] i2c: designware: Cleaning and comment style fixes Luis Oliveira
2017-06-19 16:26 ` Wolfram Sang
2017-06-14 10:43 ` [PATCH v11 2/6] i2c: designware: refactoring of the i2c-designware Luis Oliveira
2017-06-19 16:26 ` Wolfram Sang
2017-06-14 10:43 ` [PATCH v11 3/6] i2c: designware: MASTER mode as separated driver Luis Oliveira
2017-06-19 16:26 ` Wolfram Sang
2017-06-14 10:43 ` [PATCH v11 4/6] i2c: designware: introducing I2C_SLAVE definitions Luis Oliveira
2017-06-19 16:27 ` Wolfram Sang
2017-06-14 10:43 ` [PATCH v11 5/6] i2c: designware: add SLAVE mode functions Luis Oliveira
2017-06-14 12:20 ` Andy Shevchenko
2017-06-14 13:06 ` Luis Oliveira [this message]
2017-06-19 15:58 ` Wolfram Sang
2017-06-19 16:05 ` Andy Shevchenko
2017-06-19 16:10 ` Luis Oliveira
2017-06-19 16:22 ` Wolfram Sang
2017-06-20 8:03 ` Jarkko Nikula
2017-06-18 4:53 ` kbuild test robot
2017-06-14 10:43 ` [PATCH v11 6/6] i2c: designware: enable SLAVE in platform module Luis Oliveira
2017-06-14 12:21 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e332d71-1891-21aa-4479-b91a7550f8af@synopsys.com \
--to=luis.oliveira@synopsys.com \
--cc=CARLOS.PALMINHA@synopsys.com \
--cc=Joao.Pinto@synopsys.com \
--cc=Ramiro.Oliveira@synopsys.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jarkko.nikula@linux.intel.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mika.westerberg@linux.intel.com \
--cc=robh+dt@kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®