From: Deepak R Varma <drv@mailo.com>
To: outreachy@lists.linux.dev,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: [PATCH v2 1/7] staging: wlan-ng: Remove unused struct wlan_ie_ssid references
Date: Tue, 1 Nov 2022 19:18:10 +0530 [thread overview]
Message-ID: <6e39ef59d01d65a1e179f6aecfbb0d68b81fa257.1667308828.git.drv@mailo.com> (raw)
In-Reply-To: <cover.1667308828.git.drv@mailo.com>
Pointer reference to struct wlan_ie_ssid is added as a member variable
to 5 different structures. However, these references are never used.
Remove such unused struct references. The cleanup also renders the
struct useless; so remove it as well.
Issue identified as part of coccicheck based code analysis.
Suggested-by: Dan Carpenter <dan.carpenter@oracle.com>
Suggested-by: Pavel Skripkin <paskripkin@gmail.com>
Signed-off-by: Deepak R Varma <drv@mailo.com>
---
Changes in v2:
1. Include additional code clean-up opportunities and combine changes in a
patch set based on impact areas.
2. The patch changes are compile tested only on X86 arch.
drivers/staging/wlan-ng/p80211mgmt.h | 12 ------------
1 file changed, 12 deletions(-)
diff --git a/drivers/staging/wlan-ng/p80211mgmt.h b/drivers/staging/wlan-ng/p80211mgmt.h
index 1ef30d3f3159..dcff56d18498 100644
--- a/drivers/staging/wlan-ng/p80211mgmt.h
+++ b/drivers/staging/wlan-ng/p80211mgmt.h
@@ -225,13 +225,6 @@ struct wlan_ie {
u8 len;
} __packed;
-/*-- Service Set Identity (SSID) -----------------*/
-struct wlan_ie_ssid {
- u8 eid;
- u8 len;
- u8 ssid[1]; /* may be zero, ptrs may overlap */
-} __packed;
-
/*-- Supported Rates -----------------------------*/
struct wlan_ie_supp_rates {
u8 eid;
@@ -319,7 +312,6 @@ struct wlan_fr_beacon {
u16 *bcn_int;
u16 *cap_info;
/*-- info elements ----------*/
- struct wlan_ie_ssid *ssid;
struct wlan_ie_supp_rates *supp_rates;
struct wlan_ie_fh_parms *fh_parms;
struct wlan_ie_ds_parms *ds_parms;
@@ -372,7 +364,6 @@ struct wlan_fr_assocreq {
u16 *cap_info;
u16 *listen_int;
/*-- info elements ----------*/
- struct wlan_ie_ssid *ssid;
struct wlan_ie_supp_rates *supp_rates;
};
@@ -407,7 +398,6 @@ struct wlan_fr_reassocreq {
u16 *listen_int;
u8 *curr_ap;
/*-- info elements ----------*/
- struct wlan_ie_ssid *ssid;
struct wlan_ie_supp_rates *supp_rates;
};
@@ -439,7 +429,6 @@ struct wlan_fr_probereq {
void *priv;
/*-- fixed fields -----------*/
/*-- info elements ----------*/
- struct wlan_ie_ssid *ssid;
struct wlan_ie_supp_rates *supp_rates;
};
@@ -457,7 +446,6 @@ struct wlan_fr_proberesp {
u16 *bcn_int;
u16 *cap_info;
/*-- info elements ----------*/
- struct wlan_ie_ssid *ssid;
struct wlan_ie_supp_rates *supp_rates;
struct wlan_ie_fh_parms *fh_parms;
struct wlan_ie_ds_parms *ds_parms;
--
2.34.1
next prev parent reply other threads:[~2022-11-01 13:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-01 13:47 [PATCH v2 0/7] wlan-ng: Unused code clean-up patch set Deepak R Varma
2022-11-01 13:48 ` Deepak R Varma [this message]
2022-11-01 13:48 ` [PATCH v2 2/7] staging: wlan-ng: Remove unused struct wlan_ie_supp_rates references Deepak R Varma
2022-11-01 13:49 ` [PATCH v2 3/7] staging: wlan-ng: Remove unused struct wlan_ie_tim references Deepak R Varma
2022-11-01 13:49 ` [PATCH v2 4/7] staging: wlan-ng: Remove unused struct wlan_ie_ibss_parms references Deepak R Varma
2022-11-01 13:49 ` [PATCH v2 5/7] staging: wlan-ng: Remove unused struct p80211macarray definition Deepak R Varma
2022-11-01 13:50 ` [PATCH v2 6/7] staging: wlan-ng: Remove unused function declarations Deepak R Varma
2022-11-01 13:50 ` [PATCH v2 7/7] staging: wlan-ng: Remove unused structure definitions Deepak R Varma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e39ef59d01d65a1e179f6aecfbb0d68b81fa257.1667308828.git.drv@mailo.com \
--to=drv@mailo.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®