From: Mark Brown <broonie@kernel.org>
To: Joy Zou <joy.zou@nxp.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
imx@lists.linux.dev, Frank Li <Frank.Li@nxp.com>,
Ye Li <ye.li@nxp.com>, Jacky Bai <ping.bai@nxp.com>,
Dong Aisheng <aisheng.dong@nxp.com>,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH v2 2/2] regulator: pf0900: Add PMIC PF0900 support
Date: Mon, 21 Jul 2025 13:26:00 +0100 [thread overview]
Message-ID: <6e3d022c-daec-4c3f-b064-33abdd7e2c93@sirena.org.uk> (raw)
In-Reply-To: <20250721-b4-pf09-v2-v2-2-e2c568548032@nxp.com>
[-- Attachment #1: Type: text/plain, Size: 803 bytes --]
On Mon, Jul 21, 2025 at 03:11:28PM +0800, Joy Zou wrote:
> The PF0900 is a power management integrated circuit (PMIC) optimized
> for high performance i.MX9x based applications. It features five high
> efficiency buck converters, three linear and one vaon regulators.
> It provides low quiescent current in Standby and low power off Modes.
This looks basically fine, one very minor issue since it looks like you
need to resubmit for the bindings:
> +static const struct regmap_config pf0900_regmap_config = {
> + .reg_bits = 8,
> + .val_bits = 8,
> + .volatile_table = &pf0900_volatile_regs,
> + .max_register = PF0900_MAX_REGISTER - 1,
> + .cache_type = REGCACHE_RBTREE,
> +};
Unless you've got a strong reason to do something else new drivers
should use _MAPLE, it's a more modern data structure.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2025-07-21 12:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-21 7:11 [PATCH v2 0/2] regulator: add new " Joy Zou
2025-07-21 7:11 ` [PATCH v2 1/2] dt-bindings: regulator: add PF0900 regulator yaml Joy Zou
2025-07-21 7:28 ` Krzysztof Kozlowski
2025-07-21 12:00 ` Mark Brown
2025-07-24 10:51 ` Joy Zou
2025-07-24 18:58 ` Krzysztof Kozlowski
2025-07-21 7:11 ` [PATCH v2 2/2] regulator: pf0900: Add PMIC PF0900 support Joy Zou
2025-07-21 7:30 ` Krzysztof Kozlowski
2025-07-21 12:26 ` Mark Brown [this message]
2025-07-22 10:19 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e3d022c-daec-4c3f-b064-33abdd7e2c93@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=aisheng.dong@nxp.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=imx@lists.linux.dev \
--cc=joy.zou@nxp.com \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=ping.bai@nxp.com \
--cc=robh@kernel.org \
--cc=ye.li@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®