From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E65F3C6778C for ; Tue, 3 Jul 2018 18:47:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A1DA22075C for ; Tue, 3 Jul 2018 18:47:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A1DA22075C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=deltatee.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934554AbeGCSrV (ORCPT ); Tue, 3 Jul 2018 14:47:21 -0400 Received: from ale.deltatee.com ([207.54.116.67]:36024 "EHLO ale.deltatee.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934481AbeGCSrT (ORCPT ); Tue, 3 Jul 2018 14:47:19 -0400 Received: from guinness.priv.deltatee.com ([172.16.1.162]) by ale.deltatee.com with esmtp (Exim 4.89) (envelope-from ) id 1faQKP-0000Mr-FO; Tue, 03 Jul 2018 12:47:06 -0600 To: Fabio Estevam , Andy Shevchenko Cc: Andrew Morton , linux-kernel , Linux-Arch , linux-ntb@googlegroups.com, "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" , Arnd Bergmann , Greg Kroah-Hartman , =?UTF-8?Q?Horia_Geant=c4=83?= , Dan Douglass , Herbert Xu , "David S. Miller" References: <20180622194752.11221-1-logang@deltatee.com> <20180622194752.11221-7-logang@deltatee.com> <13ea3f97-4a33-3a24-1b7e-b819be73d867@deltatee.com> From: Logan Gunthorpe Message-ID: <6e5224b9-343f-990c-19bd-fe37c6fbdc9b@deltatee.com> Date: Tue, 3 Jul 2018 12:47:01 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 172.16.1.162 X-SA-Exim-Rcpt-To: davem@davemloft.net, herbert@gondor.apana.org.au, dan.douglass@nxp.com, horia.geanta@nxp.com, gregkh@linuxfoundation.org, arnd@arndb.de, linux-crypto@vger.kernel.org, linux-ntb@googlegroups.com, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, andy.shevchenko@gmail.com, festevam@gmail.com X-SA-Exim-Mail-From: logang@deltatee.com Subject: Re: [PATCH v18 6/7] crypto: caam: cleanup CONFIG_64BIT ifdefs when using io{read|write}64 X-SA-Exim-Version: 4.2.1 (built Tue, 02 Aug 2016 21:08:31 +0000) X-SA-Exim-Scanned: Yes (on ale.deltatee.com) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/07/18 12:11 PM, Fabio Estevam wrote: > On Tue, Jul 3, 2018 at 3:09 PM, Andy Shevchenko > wrote: > >> Btw, what is the environment did you use to build it? >> and what is the environment / make variable you supply (like ARCH, >> CROSS_COMPILE, etc)? > > I build it on a Dell laptop running Ubuntu 16.04 with the following > variables exported: > > export ARCH=arm > export CROSS_COMPILE=/usr/bin/arm-linux-gnueabi- Ok, I'm at a bit of a loss... When I look at the assembly before and after the patch, it looks pretty much the same. Additionally, the function where the undefined exception occurs (caam_jr_interrupt()) doesn't make any use of wr_reg64 or rd_reg64 which is the only thing the patch changes... Also, it looks like the nonatomic headers are doing what they are supposed to on this arch and generating two 32-bit ios and not a 64 bit one. So I have no idea what's going on here... Are we sure this is the patch causing the problem? Did you bisect? Thanks, Logan