From: Shawn Lin <shawn.lin@linux.dev>
To: "Deomid \"rojer\" Ryabkov" <rojer@rojer.me>,
"llj@rock-chips.com" <llj@rock-chips.com>
Cc: shawn.lin@linux.dev, 林涛(系统) <shawn.lin@rock-chips.com>,
"Ulf Hansson" <ulfh@kernel.org>,
linux-mmc <linux-mmc@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
"Jensen Huang" <jensenhuang@friendlyarm.com>
Subject: Re: [PATCH 2/2] mmc: core: sdio: skip CMD11 if signalling is already 1.8V
Date: Tue, 27 Oct 2026 19:53:41 +0800 [thread overview]
Message-ID: <6e59ac7e-0186-477d-8166-083dd2987aa4@linux.dev> (raw)
In-Reply-To: <CABFmFwr0JozEeaDd4KErDzh+DWjkjkVRo6z61OxHG6BE=L_hKg@mail.gmail.com>
Hi Deomid
在 2026/10/27 星期二 19:00, Deomid "rojer" Ryabkov 写道:
> On Mon, 26 Oct 2026 at 08:35, llj@rock-chips.com <llj@rock-chips.com> wrote:
>> With this patch, swt6621s can skip CMD11 and successfully
>> enable UHS mode.
>>
>> Tested-by: Longjian Lin <llj@rock-chips.com>
>
> thanks for testing, Longjian! so in your case it's even worse: without
> the patch doesn't come up at all. good to know that now it does.
> note that your reply didn't reach the list (vger drops HTML-only
> mail). i'm quoting it here for but if you can, please re-send it in
> plain text again, with full context.
>
> Shawn, thanks for the reviews! you're right about the soft-reset vs
> power cycle: card is soft-reset, not power-cycled.
Just to mention that vqmmc is optional, so if not vqmmc-supply in DT,
the voltage is hardwired to 1.8V, then this patch doesn't help.
I'm inclined to add vqmmc dependency to the commit msg of this patch as
well. What's your opinion?
>
> Ulf, if there are no other comments, please s/power-cycle the
> card/reset the card/ in 1/2 when applying. sounds like we're
> converging on 2a, so the alt patch can be dropped. or, if you prefer a
> single cleaned up patch set, please let me know.
>
next prev parent reply other threads:[~2026-10-27 11:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-23 23:28 [PATCH 0/2] mmc: core: sdio: fix UHS init with fixed 1.8V vqmmc Deomid rojer Ryabkov
2026-10-23 23:28 ` [PATCH 1/2] mmc: core: sdio: retry without UHS if UHS init fails Deomid rojer Ryabkov
2026-10-26 0:58 ` Shawn Lin
2026-10-23 23:28 ` [PATCH 2/2] mmc: core: sdio: skip CMD11 if signalling is already 1.8V Deomid rojer Ryabkov
2026-10-23 23:28 ` [PATCH 2/2 alt] mmc: core: sdio: retry without CMD11 if it fails at 1.8V Deomid rojer Ryabkov
2026-10-24 2:24 ` [PATCH 2/2] mmc: core: sdio: skip CMD11 if signalling is already 1.8V Shawn Lin
2026-10-26 2:02 ` Shawn Lin
[not found] ` <202610261435018282601@rock-chips.com>
2026-10-27 11:00 ` Deomid "rojer" Ryabkov
2026-10-27 11:53 ` Shawn Lin [this message]
2026-10-27 12:05 ` Deomid "rojer" Ryabkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e59ac7e-0186-477d-8166-083dd2987aa4@linux.dev \
--to=shawn.lin@linux.dev \
--cc=jensenhuang@friendlyarm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=llj@rock-chips.com \
--cc=rojer@rojer.me \
--cc=shawn.lin@rock-chips.com \
--cc=ulfh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®