From: "Christian König" <christian.koenig@amd.com>
To: cryolitia@uniontech.com, Alex Deucher <alexander.deucher@amd.com>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>
Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org, wangyuli@uniontech.com,
zhanjun@uniontech.com, guanwentao@uniontech.com
Subject: Re: [PATCH] drm/amdgpu: fix incorrect comment format
Date: Wed, 6 Aug 2025 14:32:28 +0200 [thread overview]
Message-ID: <6e5b5c47-a97c-4757-ac0d-361c91fd5819@amd.com> (raw)
In-Reply-To: <20250806-amdgpu_typo-v1-1-b5a3cb84ce26@uniontech.com>
On 06.08.25 05:34, Cryolitia PukNgae via B4 Relay wrote:
> From: Cryolitia PukNgae <cryolitia@uniontech.com>
>
> Comments should not have a leading plus sign.
Good catch, potentially a left over from a merge conflict or similar.
>
> Signed-off-by: Cryolitia PukNgae <cryolitia@uniontech.com>
Acked-by: Christian König <christian.koenig@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/nbio_v7_4.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/nbio_v7_4.c b/drivers/gpu/drm/amd/amdgpu/nbio_v7_4.c
> index d5002ff931d841994ca2c70cdf5b989f5b3c59d6..860bc5cb03c81b5346743b5fb46a7dcbe5a201a4 100644
> --- a/drivers/gpu/drm/amd/amdgpu/nbio_v7_4.c
> +++ b/drivers/gpu/drm/amd/amdgpu/nbio_v7_4.c
> @@ -151,9 +151,9 @@ static void nbio_v7_4_sdma_doorbell_range(struct amdgpu_device *adev, int instan
> * BIF_SDMA0_DOORBELL_RANGE: 0x3bc0
> * BIF_SDMA1_DOORBELL_RANGE: 0x3bc4
> * BIF_SDMA2_DOORBELL_RANGE: 0x3bd8
> -+ * BIF_SDMA4_DOORBELL_RANGE:
> -+ * ARCTURUS: 0x3be0
> -+ * ALDEBARAN: 0x3be4
> + * BIF_SDMA4_DOORBELL_RANGE:
> + * ARCTURUS: 0x3be0
> + * ALDEBARAN: 0x3be4
> */
> if (adev->asic_type == CHIP_ALDEBARAN && instance == 4)
> reg = instance + 0x4 + 0x1 +
>
> ---
> base-commit: 6bcdbd62bd56e6d7383f9e06d9d148935b3c9b73
> change-id: 20250806-amdgpu_typo-80869b122c36
>
> Best regards,
next prev parent reply other threads:[~2025-08-06 12:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-06 3:34 Cryolitia PukNgae via B4 Relay
2025-08-06 12:32 ` Christian König [this message]
2025-08-08 15:28 ` Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e5b5c47-a97c-4757-ac0d-361c91fd5819@amd.com \
--to=christian.koenig@amd.com \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=cryolitia@uniontech.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=guanwentao@uniontech.com \
--cc=linux-kernel@vger.kernel.org \
--cc=simona@ffwll.ch \
--cc=wangyuli@uniontech.com \
--cc=zhanjun@uniontech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®