From: "Chuck Lever" <cel@kernel.org>
To: "Jeff Layton" <jlayton@kernel.org>, NeilBrown <neil@brown.name>,
"Olga Kornievskaia" <okorniev@redhat.com>,
"Dai Ngo" <Dai.Ngo@oracle.com>, "Tom Talpey" <tom@talpey.com>,
"Trond Myklebust" <trondmy@kernel.org>,
"Anna Schumaker" <anna@kernel.org>
Cc: linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sunrpc: drop unneeded nrpools check in svc_pool_for_cpu()
Date: Wed, 08 Jul 2026 08:58:03 -0400 [thread overview]
Message-ID: <6e5e956d-4a6a-4548-8d9b-3ca3628a018c@app.fastmail.com> (raw)
In-Reply-To: <20260708-pool-mode-v1-1-98e9e106ebf3@kernel.org>
On Wed, Jul 8, 2026, at 8:00 AM, Jeff Layton wrote:
> As Neil pointed out in review:
>
> "The values stored in svc_pool_map.to_pool are all less than
> svc_pool_map.npools. So that if() condition cannot be true."
>
> Drop the useless check from this hotpath.
>
> Suggested-by: NeilBrown <neil@brown.name>
> Signed-off-by: Jeff Layton <jlayton@kernel.org>
> ---
> Chuck, feel free to fold this into 5/5 of the pool_mode series.
Folded in to 5/5 and pushed out to nfsd-testing.
--
Chuck Lever
prev parent reply other threads:[~2026-07-08 12:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-08 12:00 Jeff Layton
2026-07-08 12:58 ` Chuck Lever [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e5e956d-4a6a-4548-8d9b-3ca3628a018c@app.fastmail.com \
--to=cel@kernel.org \
--cc=Dai.Ngo@oracle.com \
--cc=anna@kernel.org \
--cc=jlayton@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=neil@brown.name \
--cc=okorniev@redhat.com \
--cc=tom@talpey.com \
--cc=trondmy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®