From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6AE75225788 for ; Thu, 12 Feb 2026 15:25:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770909904; cv=none; b=YlmyNo8m8VpKfCtvHOPYZIG5P5XI2p9D4XjfqAx4El9TJzMdAmUkq66kn081NEHTUmGv9GnWSulW3WsIV+HN1AUFqGqxjDfrXyJr5SXa/2J3SVNDLpQDIH2XHSOM+NuoooNfrKq1Jr6qT47k5jaqqYkSAtaejx2IzAgyTmxQnoY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770909904; c=relaxed/simple; bh=vZtghbioPEYiah+MoX8gTKaFzFFJ/HaCdDIvxKcc+gQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=AXnRr3qIp4i+XePA6hgYGL4JmYEsJY3UVYCBjVy7OhCQTuUNKqFqOI30L92Mq9i1dzSRKHKiA8wQqPb1+ubguzjJ3u2tbJlhOe4yihtDMxoVO5lGFLyG/EwcHTDIOhavB9YNEHchqKCFLBBxnbFnWp5zhns18cu6oTEn2DtisCk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=VXqkHmve; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=IVuHXlGc; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="VXqkHmve"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="IVuHXlGc" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61CDRgUg1339732 for ; Thu, 12 Feb 2026 15:25:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= M0Cmlk/Minp4VG2OAandk7L3RRoq662YgBpDU9gk8pM=; b=VXqkHmverqq1ueY2 qtjatH82a4s1glaip30Gr85WGgCkBp68ot99Db7oXt59YBqguBLA+nLXHjtzwBpc 6DPw47fcXX3twuO8cdMJ0EnBp22OokhZm5dzMgWwt1aZnoyq+6KzYXw6WEnvW39k IcTuKzwQMHpBQUI8cX27KR3g8y17DA4I5G/ViQQjzuHdOIYMETqHQFzl43sIws6w eAZBSAsj1YUZNYjtLPnQyNxiJJ5ZOilieGO8MUjcHy79iKoFC6Y2bnpF00Ui8PAD uBhTwm6nSJQUXC4hbtim1juk/ZI3PmUV1DrzzDOLyVBJbTJVL22RitPGGkeZoIM3 /ERUWg== Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c90wjb5h2-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 12 Feb 2026 15:25:00 +0000 (GMT) Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-896f7c56f10so17112796d6.3 for ; Thu, 12 Feb 2026 07:25:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1770909899; x=1771514699; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=M0Cmlk/Minp4VG2OAandk7L3RRoq662YgBpDU9gk8pM=; b=IVuHXlGcQ4sOvBCxhbABdmIc+3OJCeSmbcrnVTOejUN8MplfqQMsd7FHAh4I3vp9Jq DlV3eaPvP1C7Jy13KMVcDU2EH7beUDalherWZHd9GIgh+FD1LMHV7EH4KxmVcTk1+15J QdMW+SqTWryc1nASeiOIO/tazM79KQ7guZiXMIazMsKF54Fd1l53zFiSEQSGtqvkQbBU gOuPDFVxZxkMjfHYrE4WFa5eSOednA7l74v7s+NouMdyzSXBUIhgV4OUYv9l+iwM5+LS nJ8ZIH4nEoTAQyAMHG+yFKL/nqjwDvdYaviWdpNki3rOXSegN8rlP0LKIeoddWUgMtj2 Xkfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770909899; x=1771514699; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=M0Cmlk/Minp4VG2OAandk7L3RRoq662YgBpDU9gk8pM=; b=Ww8Jrqovb01C+lgCz8ZQ5EJgrZoJn8bxrBxWmW5A2XGUOVde38LgRLNvBCpPbYZmfk ck+L1S/rms2kTkSBwIPXvBDoP7z/s0Z1uAuv0IlVO3Aq4t4Qo3Gjc9LMtro9Htjxu4BE ovwSOcnOTiVgF+oDg6OqNI4ZO/iJXrVX803s6EBUcf1J3dOLUtkMskJEm62v1sZn4JGH U+TRWahKFVjoW807uSXyqi+fq0HpSEUczfF7PhNdLwXKcT6AuTMRr+j5nv302ko8U1d0 yvLDKif1gr5jsWM1CJloufkP/m6s875Dad8YWNps65W5nGZrLzHHrNxm4ZZzBHLDARlX eunQ== X-Forwarded-Encrypted: i=1; AJvYcCVHI5jjwBPJLUvL/tn2vU39Ga4OPmz/BhpB7D3YCioPyMeR1xftvWnfCy25MWYTWYi5RtQlIrVe0i08ahE=@vger.kernel.org X-Gm-Message-State: AOJu0Yy/kDSasfGHqOCY86GrTtZcnD5sO3YSWZKW/PGpqGFlJ9jzImCK gfXt7M8l4iyK+MyNJ53saYsA7LVScAvTeBRkta+MVJWwXSC3aiKdpI89Qtcwf6XeEHolfDLfwec oqzIKK8/CE1Pv9bpNcSEbBK5xKGT1y9MShCpp4EZFQxW3ECFop5gWb4VRlIxXsUJzw69rAJ9f9h Y= X-Gm-Gg: AZuq6aLqAzwPUa4jL4DmWOdqr3pE7QuzMgPYuhSRnZXAzRoHyOOsnLzJO7f1W8//bjn 9zZRfpifRgD/MUWZ+O3SHV5pl/4xttZVNKkb+ORbunR8O7wIqdRQFLzDG1hyjgezz62jtb6Tlwd Kr5gZig+8V6FdQbWboLZ7vuQZ3BCJMta8MB0enmHMxvc6nuv+D/RBsXRAZ+qgNlIpyNtIlWJDCm R7Kd+NiQFTCkjA8XAqjAvDZsREzNWIDj7lhsYjtnK+iiZfYOhlMTe4zfqNj6ov4GqufSXp5zz3u lgGSIWVHv87ErxWKiH4G/OhricLoUteE7/XAeY7XNG4xg2fqfKyx5Li6Gb07KV/DY4YSubQLboB xXBmVaXdMIg0NArsZA1I6fLpDYl6x+FAnLS5KL9KBjVgCqizWIlTL/ccGygEYuVUDhUETE/lJLH Rb+CA= X-Received: by 2002:a0c:e002:0:b0:897:3f5:6a9a with SMTP id 6a1803df08f44-89727aaaaf6mr34928786d6.6.1770909898778; Thu, 12 Feb 2026 07:24:58 -0800 (PST) X-Received: by 2002:a0c:e002:0:b0:897:3f5:6a9a with SMTP id 6a1803df08f44-89727aaaaf6mr34928366d6.6.1770909898191; Thu, 12 Feb 2026 07:24:58 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-65a3cf50e38sm1794656a12.33.2026.02.12.07.24.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Feb 2026 07:24:57 -0800 (PST) Message-ID: <6e706170-4dac-48c8-881c-4f244a3db34b@oss.qualcomm.com> Date: Thu, 12 Feb 2026 16:24:55 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] wifi: ath11k: Silence remoteproc probe deferral prints To: Bjorn Andersson Cc: Bjorn Andersson , Jeff Johnson , linux-arm-msm@vger.kernel.org, linux-wireless@vger.kernel.org, ath11k@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260212-ath11k-silence-probe-deferr-v1-1-b8a49bb3c332@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=DtlbOW/+ c=1 sm=1 tr=0 ts=698df0cc cx=c_pps a=wEM5vcRIz55oU/E2lInRtA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=EUspDBNiAAAA:8 a=mOPo6HKdNPmMLqtFk4QA:9 a=QEXdDO2ut3YA:10 a=OIgjcC2v60KrkQgK7BGD:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjEyMDExNyBTYWx0ZWRfX6QRE2MSl/EBL kPOjN1L7zGRNYPtHOgiU+cfXQHqJOuMn+qLu8HxeCLV8z9MduHlyR7x/A6++a6PzdKygzsK8a/x NFu6mtSeSOFsHBgk5sTEwDEZ4Q83GojBo/fImS5oTY0+w0uWpQkyJCTKUkuri+fVSFewI4FsXED 0uZrrRNT4/dgkZywLdCdaIX5EueEqVnzTh6QkbKLHeSUX3GAr65lqiqGAOxsT0Vjtzq7KDV0N0z 0XnMJgg5C84xj+wlpogFLCCjdEAVQRmBdsRq+z9xlp7nXNTK382bAuWDg33NiygekVaMLku8j7l fRrpxQOowBmuONkp9FrpSd5feYiZe5EVEgMUFaOCSc0ylGQcu0p6KOEgx3mNXuSi5npJzcgC1LT OiZkbE29ommA+ClOaOVOpu1+vUGvSPcQ+8z4RlkDmrbPi3inEC4cwKRxtHN8aBAf2eUemrQ5Esy BxCiskQRu8EmVLOp/Sg== X-Proofpoint-ORIG-GUID: fKkmoOEoUsrPkCwD2zVlWj0oiIdSyJAZ X-Proofpoint-GUID: fKkmoOEoUsrPkCwD2zVlWj0oiIdSyJAZ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-12_04,2026-02-12_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 spamscore=0 suspectscore=0 impostorscore=0 adultscore=0 lowpriorityscore=0 clxscore=1015 bulkscore=0 malwarescore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602120117 On 2/12/26 4:16 PM, Bjorn Andersson wrote: > On Thu, Feb 12, 2026 at 04:01:21PM +0100, Konrad Dybcio wrote: >> On 2/12/26 3:52 PM, Bjorn Andersson wrote: >>> Upon failing to resolve the remoteproc phandle one ath11k_dbg() and one >>> ath11k_err() is used to tell the user about the (presumably) temporary >>> failure. >>> >>> Reduce the log spam by removing the duplicate print and switching to >>> dev_err_probe(), in line with how ath12k handles this error. >>> >>> Signed-off-by: Bjorn Andersson >>> --- >>> drivers/net/wireless/ath/ath11k/ahb.c | 10 +++------- >>> 1 file changed, 3 insertions(+), 7 deletions(-) >>> >>> diff --git a/drivers/net/wireless/ath/ath11k/ahb.c b/drivers/net/wireless/ath/ath11k/ahb.c >>> index 8dfe9b40c12626649639fc1dd9da0e5e0c2dcaf1..08d3a0c8f105b26b1548c5d6006f6ea162fe58ff 100644 >>> --- a/drivers/net/wireless/ath/ath11k/ahb.c >>> +++ b/drivers/net/wireless/ath/ath11k/ahb.c >>> @@ -807,10 +807,8 @@ static int ath11k_core_get_rproc(struct ath11k_base *ab) >>> } >>> >>> prproc = rproc_get_by_phandle(rproc_phandle); >>> - if (!prproc) { >>> - ath11k_dbg(ab, ATH11K_DBG_AHB, "failed to get rproc, deferring\n"); >>> - return -EPROBE_DEFER; >>> - } >>> + if (!prproc) >>> + return dev_err_probe(&ab->pdev->dev, -EPROBE_DEFER, "failed to get rproc\n"); >> >> I'd like to think this doesn't really change the behavior, but I'd rather >> see this that in-house print functions.. >> > > I'm having problems parsing your sentence. Are you saying you rather see > us keep using the ath11k_* functions? s/that/than i.e. "no" > >> >>> ab_ahb->tgt_rproc = prproc; >>> >>> return 0; >>> @@ -1190,10 +1188,8 @@ static int ath11k_ahb_probe(struct platform_device *pdev) >>> ath11k_ahb_init_qmi_ce_config(ab); >>> >>> ret = ath11k_core_get_rproc(ab); >>> - if (ret) { >>> - ath11k_err(ab, "failed to get rproc: %d\n", ret); >>> + if (ret) >>> goto err_ce_free; >>> - } >> >> If the rproc handle is unavailable at this point, we undo quite a bit of work >> in .probe.. would it make sense to move this check way above? >> > > Given that devlink doesn't covers this, but presumably cover several of > the above resources, I think that would make sense. It would be a > separate patch regardless... Yeah, I'm simply thinking out loud For this one: Reviewed-by: Konrad Dybcio Konrad