From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7DBE3378D89 for ; Fri, 19 Jun 2026 15:37:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781883423; cv=none; b=Idzv7/Z6WCNeCsGpkzCTEp7gX/9DN+oFqfoJ1F2OPu97UnDwtaIYSwLMQlJx+hXcPjepVItnKfglu1CtUoWISpiJCSiQws9uG1XlUwM1EsgO58VBvMqCLLF51vTaL+uXhnNQ3fNG017af44sZPq0kBUTApRj0BJkJ5KwD6J5Hjk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781883423; c=relaxed/simple; bh=Ue+aoWk4rNKM0Od3UOoy/W5n1XtBpOFjK2/UGI6BV0w=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=fY6R0NZ/vOLGetDBSODKeMfdklHcDNywANtERrz4QHOEuHyGsplK7o1A/oRyh9tCwmbywEvE0gZMAqF0Pi4Zz3fr2VN4aV94oAIhujSyHOvMs/1jYFf2lbtDABF5VWcO96R4HQHCFCdLxWokJ2GCY+fYEqg4tCQ7f5/2+DjGe7A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=NTEjpDPM; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=OyVJCngV; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="NTEjpDPM"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="OyVJCngV" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65JDBrsa758423 for ; Fri, 19 Jun 2026 15:37:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= l+ZBZUukYW3UATRdgCDpkV2aWJmXCVShzbz3nEXQmKM=; b=NTEjpDPMMF3fClMq 99XprWICtZJqKb5hCefZmSdGR+n4Vkjm9DPB8qEYu4aFFUqW2+3wERYRO6NZ0K8x /CEeFego/qLHer9/xB+4BypzIfgNNXuTCrTCaXilPy5mq136KVEOcvXNaRH5XvN6 HldYzixLRRiHk0Y56tfhsC7n58hRLQxe00jmpLmO5nw0vUwIma1wZAclSEFMqHV2 NSrx1uZVHLd8R7FJjvQY8RTQrPCIqx3hZCF4Z9dAHvAGx4KPp9LcAOBQ9z+FvQ5s TCw8URFrGr/P+AC6guothYIFhpWY/TVtHZ+gaFTl1W46sULmb7p5cgr2Hav5XWPi gLJLnw== Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ew5hp8p4k-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 19 Jun 2026 15:37:00 +0000 (GMT) Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-8ddb0711609so7741286d6.2 for ; Fri, 19 Jun 2026 08:37:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781883420; x=1782488220; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=l+ZBZUukYW3UATRdgCDpkV2aWJmXCVShzbz3nEXQmKM=; b=OyVJCngV6+IxrgWniWczhsi614GdXH8gCRS6g90jaTouhvojI2vDeXhlNdz54+2XkK tqwbphsLNYSjU2M1VspEWSq9yj9NI+PqJG/lbFmb0ZQqXKdKvHzGr319aNyIWcQBZV1O 80Rgbu5jUCxPFLfSUVmn5C4q+Hm2GwCMAc8JF5O2ZSQnFakP+ypPFOKqOLjslh/US15U zL4+jCabbFUKSC1SbwmSVeG73TQX5Mt2pZ5oV1px0pKJPnkEpKPI+PXIkyKGd1ArX4oc +lv06EAAmrJYDWoA79ITAm7aahMOvnLcXtuq99/uEZg5Pszmm7361cHmXdxnW0YkCRTP veJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781883420; x=1782488220; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=l+ZBZUukYW3UATRdgCDpkV2aWJmXCVShzbz3nEXQmKM=; b=rk92zB//9B8JLnIpvEbBz7y+YVNemEdVYH2W0FcxIItWEMPcUXt57UA61jjswFS9EN d4ognEy8r+xq+yY9oZciGvDmJiSWgVd4+EyxkMZgb49AbT+Kaj/dAHOqT+Og32nz+x/a l1WZune4tQiXtZUOove3ALfKHwkhQa+l6Swwtf019EniaeaoJbUKS0IEiesolA0VTH6+ 0HfI4WrdOkmji2ug2VYEDPP9GER3UxQOPFXvCiaJZZJOzBne0bgBCZZt4oA1c15xq2HA FqfDJ+5e86keoTJVy68w/L19gAAvQ2R9B8B69y8NAshbeR60Eh/fbK2YxsS1AAklnVRZ vwgw== X-Forwarded-Encrypted: i=1; AFNElJ+JlSbabyRrNkMQh8LvM8Ep4uTP+/+g4+Mo/9N3mx/3gPHjN+CiVd19ZmUzpZ1+biLvkwSOTQIxiR2Hd1g=@vger.kernel.org X-Gm-Message-State: AOJu0YxAXqaBuKvZMkZCZrxbiUpX4Ljel5X+X4tDcPx+Im9kvsj0YP1e MjfuuiF0mbppjecuI6whZt7D+EFw8EQiKlMcxB9TfAPn3NR0sDTseb5+H6iKBXMNnFKQFmNHS+Y VYIJlSRjsdZPGidIaLvWtXwfyHhq1co65ORb18UZwvwZBtk+ae6n1ZY0iYh6AT8YGJ+8= X-Gm-Gg: AfdE7cmWxfiKMQrF/hWm+BqGZNcpWldRdqJah2nc6EO/+CemHP2pDVsVVSIkx4XlL7h 50i5b3ouyDsFhjjfot1obQa/sGv8oO55dmXGvKQlnPytYTiFloW7pBDW7stYwoxBPgMIgzaOCVG T5vvUf/tSWkeTtu/gLGigI2RDv9VoSDoniI+OG6vVDV9jB3L6jIsPsphwjwvl720eMOh/ra+DMH sVaPECOi3ILxq4Gdl1RdisiLey7+F/ZCrIj12UtBdCwzL0aLkCsbAxGqrY0w8Q1hE6zbtQd6uTc Ohsu1khSO+2OHS3OTV+D07o6PeNiXM9u/fLsj2oITv5wzd1bTkvBxZB1RonrEzr0+7HCoDST6uu RJ+vvIKFs3ujZLhvcslPy6iZ9LdfTnzUY+io= X-Received: by 2002:a05:622a:1393:b0:50e:487a:bfef with SMTP id d75a77b69052e-519e4a25406mr39022071cf.2.1781883419833; Fri, 19 Jun 2026 08:36:59 -0700 (PDT) X-Received: by 2002:a05:622a:1393:b0:50e:487a:bfef with SMTP id d75a77b69052e-519e4a25406mr39021521cf.2.1781883419316; Fri, 19 Jun 2026 08:36:59 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-696edc76242sm1042750a12.4.2026.06.19.08.36.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 Jun 2026 08:36:58 -0700 (PDT) Message-ID: <6e760884-87b1-4ec8-9ae1-e53901451b65@oss.qualcomm.com> Date: Fri, 19 Jun 2026 17:36:54 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 4/6] arm64: dts: qcom: shikra: Add pin configuration for mclks To: Nihal Kumar Gupta , Bryan O'Donoghue , Vladimir Zapolskiy , Loic Poulain , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Robert Foss , Andi Shyti , Bryan O'Donoghue , Bjorn Andersson , Konrad Dybcio , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam Cc: linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, Suresh Vankadara , Vikram Sharma References: <20260615-shikra-camss-review-v4-0-bcb51081735b@oss.qualcomm.com> <20260615-shikra-camss-review-v4-4-bcb51081735b@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260615-shikra-camss-review-v4-4-bcb51081735b@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: 14R_p-H7EUNlGfzfMK1wni_xMGF0GGaS X-Authority-Analysis: v=2.4 cv=aOHAb79m c=1 sm=1 tr=0 ts=6a35621c cx=c_pps a=UgVkIMxJMSkC9lv97toC5g==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=EY8lGxjS-5OGnG_HtjIA:9 a=QEXdDO2ut3YA:10 a=1HOtulTD9v-eNWfpl4qZ:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: 14R_p-H7EUNlGfzfMK1wni_xMGF0GGaS X-Proofpoint-Spam-Info: AW1haW4tMjYwNjE5MDE0NyBTYWx0ZWRfXwAa6M7q2aD7f pqwfq3hmFyDc1Ccex5pgplLw/DtObjg8sbGUhlnz5qHe1AHfBKD9UseD1d89zC0vnoZ1eIOst2r qTYh88HpXZ0tbl1nls0LXmsAb7GCzTs= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjE5MDE0NyBTYWx0ZWRfX6xLFERxBYtCI 3kOsv5NoUkA1n5cVJTe2zG85G86sjtW2nW0OsOi6z0xsSm3e7W0QLJlj5hqUJDxZdpmtCrJhBuW S81QWnOwwFZNX2qkFy6FkgjrpbLRsG5HLRMmMY7q5Xgek93eHTgBZJzIZeDh35bXZkxvDHymdCp A9ZQC5gcDamXG+Y68+ejWAG6/Guf+05Io3aqpGdXwfQJaFS6V2OcFvEKxP78l5IzzD6SRDrUn2e qKt6H/eefup1L4olH/ayExYxeSoq1/OOmez8KKug1BaZ6Yzn2iCslwYD5XXqXt8z6iYuWZ/ZrJJ sFitFWN3k4uK2Q66b2OMPL83mUBrWjpTfvdnWcj3F6Sk2mt9HLBloafGTldsL04On447wy57eUn doK33rX2P6TSswMRTmwHHKFUNEag16O48ErMKaQqrh1NPLbp876/JtmKASEzzZ1/s95C3jOuTJ7 clsFpvljhuKLW1jJ7zg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-19_03,2026-06-18_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 bulkscore=0 spamscore=0 clxscore=1015 impostorscore=0 adultscore=0 lowpriorityscore=0 malwarescore=0 suspectscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606190147 On 6/15/26 10:33 AM, Nihal Kumar Gupta wrote: > Add pinctrl configuration for the four available camera master clocks. > > Reviewed-by: Bryan O'Donoghue > Reviewed-by: Vladimir Zapolskiy > Signed-off-by: Nihal Kumar Gupta > --- > arch/arm64/boot/dts/qcom/shikra.dtsi | 28 ++++++++++++++++++++++++++++ > 1 file changed, 28 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/shikra.dtsi b/arch/arm64/boot/dts/qcom/shikra.dtsi > index 57732804a6c6a114a407a4a541a1cc7af7635ea2..16b547131e8b14541abc68ff7cda126ba777ad80 100644 > --- a/arch/arm64/boot/dts/qcom/shikra.dtsi > +++ b/arch/arm64/boot/dts/qcom/shikra.dtsi > @@ -380,6 +380,34 @@ cci_i2c1_sleep: cci-i2c1-sleep-state { > bias-pull-down; > }; > > + cam_mclk0_default: cam-mclk0-default-state { > + pins = "gpio34"; > + function = "cam_mclk"; > + drive-strength = <2>; > + bias-disable; > + }; > + > + cam_mclk1_default: cam-mclk1-default-state { > + pins = "gpio35"; > + function = "cam_mclk"; > + drive-strength = <2>; > + bias-disable; > + }; > + > + cam_mclk2_default: cam-mclk2-default-state { > + pins = "gpio96"; > + function = "cam_mclk"; > + drive-strength = <2>; > + bias-disable; > + }; > + > + cam_mclk3_default: cam-mclk3-default-state { > + pins = "gpio98"; > + function = "cam_mclk"; > + drive-strength = <2>; > + bias-disable; > + }; Please try to keep the entries roughly sorted by the pin index For the entries themselves: Reviewed-by: Konrad Dybcio Konrad