From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8B8E94C10EA for ; Fri, 9 Oct 2026 10:48:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791542913; cv=none; b=YH8KJQZLdYKlyFPej3wNlgJegYzu9JneSs2/4MOPxhgMbjco0f9wRcRrjJGDV1AcB+pXTy6mJvMRhVYQzZyW/mJQkukwPBOVERO0gWuG7PBrQ2BTze0ign9Uy3ns+r9OCiA3xWysZSLIrwpphAJbf2Ob+xN/R+RiLAKGuJjMQ4M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791542913; c=relaxed/simple; bh=hXAZLulDZSHv7p+IwxBCxoU+xaRODRRS47Lz06TEE6E=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=f+R5DvZhPPWCOc4Chwsk7FQ/YIpBr115zeDLGskWPG6nRP2S+7IGgZCh0o3mD9+2TIpR04tzpUuxFfr83/s5zPOxxrdOjJuqURxMnw4nIs4cSqmZKUj6MdJn5NoH9r8ABPbrmSQbrPaNyiwdunjdszEqqkRQlTMeke1NJrAiuHg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=LOosSm7y; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=YO3h1tfx; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="LOosSm7y"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="YO3h1tfx" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6998KHBq230899 for ; Fri, 9 Oct 2026 10:48:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 1z/X9tGm5aE4WYRZZCAENSK6cH/4JbMWNqBqxrfbL3Q=; b=LOosSm7yKO+alq4p xcXdKdZ7BFVPTvAS9Xw4HBdBEDKfV7yDDLNZgPoMCS6j5ACC0k6ddntH7emkY9oM LAmt7cz/gqQkX/Vc910ZWDBlBv6RCq/zXjGqfjj0YHjc8Lu55SI5PODHeKxES8QP ULvgvQz2bdAs9sXfGRPC7y0Ur2OMpeLBcuFWrQBJXrPLrTRfTSAVj8jBCP9clDQH D6M9VPLlLKn0MZ1RjNAmHDiERtmffiGg2UVYbSe+EJd6ELr9l1zuLmGAEu/1q47p AIghGFOobUraSNoy1yq5dlJnoBUVHF2EiUsj+MfmI4nrkj/WvdwJTFghvEAWvE1D y0atkw== Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4h6fxu35m6-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 09 Oct 2026 10:48:21 +0000 (GMT) Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-8872ada18d7so5506529b3a.1 for ; Fri, 09 Oct 2026 03:48:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1791542900; x=1792147700; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=1z/X9tGm5aE4WYRZZCAENSK6cH/4JbMWNqBqxrfbL3Q=; b=YO3h1tfxW274EcGebsFyjVQ/7ZI2deGNy17kRFvX+iKOMnIGWtRTTtlxTRLVXqaf7w n7zMm0B/BiyU8d46jdGdsREvkgBhA/xqEM3chg2Tgl2bLLOiSRGJX8ESLh2dnbnU9Bu9 WmJwMYEyFkrCxKCjvty4qQoCtJCgYzdhnamuazLsuVcIspRDZHI0tu+tHDTFvMkO9YMU 6msPRELHjVagXRF3AAkjnL/rwWL4pEG08Dz0kidzmU177es6S+/NzeEZ4jxmRoxeLPyc qNuWxawF1kfK4hpZ7uK4qedOi8XQCBmuj7Lu7yoGsAyOua0BH5QmKk1AQVj9LmftG/Qe W3GA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791542900; x=1792147700; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=1z/X9tGm5aE4WYRZZCAENSK6cH/4JbMWNqBqxrfbL3Q=; b=nY99+o5hXf1CCv827h2uF1Y6O5iYm8BeQmbUMm1HPrryLcrRmOZ7vsL9CskLoZTFSp sOSnB2XoQm1mR/JgpMPvCUfoSPGAboYSMhy6XhVLkRAAkYIugnP1cdFHEDBMVFmR8mWo yhcqRBliaztzm5O0s9PGkLwOjuMMPckNGB/1VE7Md0KNc7DLtamv2i6WCPemwiNGPNIO DdJClzTcUXaQ0MspgM6yr6HQ+J7JSNiIFIdvZlJlH3wHJAO0UQN2EgELsLga75OaijtO 7cM2lZkbqBF61hMDVIMwzJZ0SX7EAA+EtWkPeWNPD7XyV+UHfLXd98h4rsRAIoo5yW5n km2A== X-Forwarded-Encrypted: i=1; AKwUvByeu3d3kkn+12ZUz5lF/p+te4SPExJM/rapucz0GydVuh/lqujOw8SLhqo+A1SgXf1VpGtA9IHEP+4gXQY=@vger.kernel.org X-Gm-Message-State: AFq9FYJHgs4PPiZwRXhYG6BXxZLYmhcM75vifqrr+W/k9qcdp0J15H91 Hc6Lkz2iVQGLUduFp7tgLGrNU8SotbqplQiyvc7XFjzCTYFCJh4NGnWuzq3tiK4D7OKooM/0Cwk 0xvtzyiiE5dPSb70KTRyYWEC0BKJYmcdG6xjvJiMybXNcs5SYaMnZZz1mXfr6wjrsPHw= X-Gm-Gg: AYBFou2Odsg7fhHrfiE5OoXWo5WGLWRsKVQrKvAHMUSeWybhKmt/4duJq4vICut/wsJ IRB7fr1sNEO32uyZsSAkgGosHkNRaOFFVyo+RJ3Mw0Vd0LG+sw/wVisaXWxRI5G+d5B59Fb2IKe js/XqfmzsUlD1w/N5JASTYT3WECclKyAJHK8/daTrp6LWrpgzbHBB9gEj4L+IUz+hWBVpAJxpuH 0roQl4sNxBmBf3e3L2HISrFADApVSr+cT/DzP8+tJwlUKglCU84m3IRLNglO+1grMUwa+yA7EuB 3PgpHKQcFWZZ5X5nhAuAdMQGgmuj9ti2+c1eED2hzfXXb/HQZjnLtN/r880XmYiUCA1bjMGKUSa s2i+t8yIV3Yp/aT/gnPF2xOiO+9UoAC3C8Q== X-Received: by 2002:a05:6a00:3403:b0:890:b4c2:d7e8 with SMTP id d2e1a72fcca58-897c79e0cf1mr1408249b3a.33.1791542900126; Fri, 09 Oct 2026 03:48:20 -0700 (PDT) X-Received: by 2002:a05:6a00:3403:b0:890:b4c2:d7e8 with SMTP id d2e1a72fcca58-897c79e0cf1mr1408225b3a.33.1791542899607; Fri, 09 Oct 2026 03:48:19 -0700 (PDT) Received: from [10.204.78.217] ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-896c3ecb01dsm712832b3a.36.2026.10.09.03.48.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Oct 2026 03:48:19 -0700 (PDT) Message-ID: <6e7779bc-89db-4ed9-b5b5-bff1dfd968b5@oss.qualcomm.com> Date: Fri, 9 Oct 2026 16:18:10 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/5] arm64: dts: qcom: kaanapali: Add DisplayPort controller To: Dmitry Baryshkov Cc: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Kuogee Hsieh , Yongxing Mou , Yuanjie Yang , Bjorn Andersson , Konrad Dybcio , Abel Vesa , Mahadevan P , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20261005-kaanapali_dp-v1-0-6faeac3a6d59@oss.qualcomm.com> <20261005-kaanapali_dp-v1-3-6faeac3a6d59@oss.qualcomm.com> Content-Language: en-US From: Balaji Kalkonda In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDA5MDA0MiBTYWx0ZWRfXz3XFCy9oQkp7 x6dPs1N62jer9bLlx1ZR+neswdKnWiiuDvw8RRfwiPH6suVYi3I05WJlz0GkPuXgh3UG3m5R2uQ 9kPFu40SATANtKuDoFgzYnAh8WIKZPe8wzE+DqxDCeauH1ZI/rAYo5UgaWom6lg5t53GTZclYZE Gd63oeOgqKfBbjAi2IF0ubuqskJUm4fWV8aGXjhLXsBSoF2jZPl0uATw9rO5R/AfIlplKJsCKNH h/hgqtJvMpWoy3M9H9A6i1NIKdGwhh7qGIrHG4/JFrIaVg6ETF4/IA5DmmFPgMJuGOMOdVOALv/ 97xL+n+ZfLFo6NTW9gjT6YimML8FZHnhO7nXKhkJm6DqysD6qPgxpMLqjHyR5ctXc7fT2NYhYco CD3a0mlUbgVAbkjAM+D9Lu7BXfr1V52y7GBi4mopKFasA4nP2Cr8quSVcoC9vSksgTtfsAZDh9w pDfpFSh+en8JDe89g3A== X-Authority-Analysis: v=2.4 cv=QbjzLcbv c=1 sm=1 tr=0 ts=6ac8c675 cx=c_pps a=rEQLjTOiSrHUhVqRoksmgQ==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=660iZSQnnn4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=6Q945mz2-PRHoXMB8K4A:9 a=QEXdDO2ut3YA:10 a=2VI0MkxyNR6bbpdq8BZq:22 X-Proofpoint-GUID: mSqf34YIHRx0F_mtUCQhcdQha5H1gLP0 X-Proofpoint-ORIG-GUID: mSqf34YIHRx0F_mtUCQhcdQha5H1gLP0 X-Proofpoint-Spam-Info: AW1haW4tMjYxMDA5MDA0MiBTYWx0ZWRfX1gmD8PLIbk9W 0c/Cr0NE/AYLO2mfjjCoAuxNyPTM72Q6hibVDZFfuwRQkFq/12DLlvO4E+AsAZQQFd4wpdJfAS8 hDF6J6uQs5gjVCAuM5EqGdnR8P/xUoM= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-10-09_03,2026-10-08_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 spamscore=0 priorityscore=1501 malwarescore=0 clxscore=1015 bulkscore=0 phishscore=0 impostorscore=0 suspectscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2610020000 definitions=main-2610090042 On 09-10-2026 02:02 pm, Dmitry Baryshkov wrote: > On Mon, Oct 05, 2026 at 12:54:28PM +0530, Balaji Kalkonda wrote: >> Add device node for the DisplayPort controller, its OPP table, clocks >> and power domain, and connect it to the DPU and USB/DP QMP PHY. >> >> Signed-off-by: Balaji Kalkonda >> --- >> arch/arm64/boot/dts/qcom/kaanapali.dtsi | 87 ++++++++++++++++++++++++++++++++- >> 1 file changed, 85 insertions(+), 2 deletions(-) >> >> diff --git a/arch/arm64/boot/dts/qcom/kaanapali.dtsi b/arch/arm64/boot/dts/qcom/kaanapali.dtsi >> index e48a179d0722..155c590c8eb6 100644 >> --- a/arch/arm64/boot/dts/qcom/kaanapali.dtsi >> +++ b/arch/arm64/boot/dts/qcom/kaanapali.dtsi >> @@ -3565,6 +3565,7 @@ usb_dp_qmpphy: phy@88e8000 { >> #clock-cells = <1>; >> #phy-cells = <1>; >> >> + mode-switch; > Not mentioned in the commit message. > >> orientation-switch; >> >> status = "disabled"; >> @@ -3851,6 +3854,86 @@ mdss_dsi0_phy: phy@9ac1000 { >> >> status = "disabled"; >> }; >> + >> + mdss_dp0: displayport-controller@9ad2000 { >> + compatible = "qcom,kaanapali-dp"; >> + reg = <0x0 0x09ad2000 0x0 0x10c>, >> + <0x0 0x09ad2200 0x0 0xc8>, >> + <0x0 0x09ad3000 0x0 0x78>, >> + <0x0 0x09ad4000 0x0 0xa0>; >> + >> + interrupts-extended = <&mdss 12>; >> + >> + clocks = <&dispcc DISP_CC_MDSS_AHB_CLK>, >> + <&dispcc DISP_CC_MDSS_DPTX0_AUX_CLK>, >> + <&dispcc DISP_CC_MDSS_DPTX0_LINK_CLK>, >> + <&dispcc DISP_CC_MDSS_DPTX0_LINK_INTF_CLK>, >> + <&dispcc DISP_CC_MDSS_DPTX0_PIXEL0_CLK>; >> + > Please define all pixel clocks that are used by the DP controller. Is it > not MST-capable? > >> + clock-names = "core_iface", >> + "core_aux", >> + "ctrl_link", >> + "ctrl_link_iface", >> + "stream_pixel"; >> + >> + assigned-clocks = <&dispcc DISP_CC_MDSS_DPTX0_LINK_CLK_SRC>, >> + <&dispcc DISP_CC_MDSS_DPTX0_PIXEL0_CLK_SRC>; >> + assigned-clock-parents = >> + <&usb_dp_qmpphy QMP_USB43DP_DP_LINK_CLK>, > Don't break the line here. > >> + <&usb_dp_qmpphy QMP_USB43DP_DP_VCO_DIV_CLK>; >> + >> + operating-points-v2 = <&dp_opp_table>; >> + >> + power-domains = <&rpmhpd RPMHPD_MX>; > MMCX. If you need to cast a vote on MX domain too, add second entry to > the power domains and handle it in the driver. > >> + >> + phys = <&usb_dp_qmpphy QMP_USB43DP_DP_PHY>; >> + phy-names = "dp"; >> + >> + #sound-dai-cells = <0>; >> + >> + status = "disabled"; >> + Hi Dmitry, Thanks for reviewing. I'll address all these comments in v2. Thanks, Balaji