From: Daniel Wagner <dwagner@suse.de>
To: Guangshuo Li <lgs201920130244@gmail.com>
Cc: Ram Vegesna <ram.vegesna@broadcom.com>,
"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Thomas Gleixner <tglx@kernel.org>, Kees Cook <kees@kernel.org>,
Hannes Reinecke <hare@suse.de>,
James Smart <jsmart2021@gmail.com>,
linux-scsi@vger.kernel.org, target-devel@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] scsi: efct: clear MWI on remove
Date: Mon, 21 Sep 2026 14:20:00 +0200 [thread overview]
Message-ID: <6e80e9b4-231a-4299-a90d-a2181ea49261@flourine.local> (raw)
In-Reply-To: <20260918181326.3633765-1-lgs201920130244@gmail.com>
On Sat, Sep 19, 2026 at 02:13:26AM +0800, Guangshuo Li wrote:
> efct_pci_probe() enables PCI Memory-Write-Invalidate with pci_set_mwi().
> The probe failure path clears this state with pci_clear_mwi(), but the
> normal remove path does not perform the corresponding cleanup.
>
> pci_disable_device() only disables PCI bus mastering and does not clear
> the PCI_COMMAND_INVALIDATE bit. As a result, the MWI configuration can
> remain enabled after the driver is removed.
>
> Call pci_clear_mwi() in efct_pci_remove(), matching the probe error
> path.
>
> This issue was found by manual code inspection.
>
> Fixes: 4df84e8466242 ("scsi: elx: efct: Driver initialization routines")
> Cc: stable@vger.kernel.org
> Signed-off-by: Guangshuo Li <lgs201920130244@gmail.com>
Reviewed-by: Daniel Wagner <dwagner@suse.de>
next prev parent reply other threads:[~2026-09-21 12:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-18 18:13 Guangshuo Li
2026-09-21 12:20 ` Daniel Wagner [this message]
2026-09-21 15:13 ` krzk
2026-09-22 2:50 ` Guangshuo Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e80e9b4-231a-4299-a90d-a2181ea49261@flourine.local \
--to=dwagner@suse.de \
--cc=James.Bottomley@hansenpartnership.com \
--cc=bigeasy@linutronix.de \
--cc=hare@suse.de \
--cc=jsmart2021@gmail.com \
--cc=kees@kernel.org \
--cc=lgs201920130244@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ram.vegesna@broadcom.com \
--cc=stable@vger.kernel.org \
--cc=target-devel@vger.kernel.org \
--cc=tglx@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®