From: Matti Vaittinen <mazziesaccount@gmail.com>
To: Mehdi Djait <mehdi.djait@linux.intel.com>
Cc: "Matti Vaittinen" <matti.vaittinen@fi.rohmeurope.com>,
"Matti Vaittinen" <matti.vaittinen@linux.dev>,
0012-iio-accel-kx022a-Fix-IPOL-macro-name.patch@mva-rohm,
"Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Javier Carrasco" <javier.carrasco.cruz@gmail.com>,
"Mehdi Djait" <mehdi.djait.k@gmail.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
"Kalle Niemi" <kaleposti@gmail.com>,
"Topi Sonkajärvi" <sonkajarvi@hotmail.com>
Subject: Re: [PATCH 12/12] iio: accel: kionix-kx022a: Fix IPOL macro name
Date: Fri, 14 Aug 2026 10:43:35 +0300 [thread overview]
Message-ID: <6e82d7fd-37f1-40fb-9c5b-aea753cc0a13@gmail.com> (raw)
In-Reply-To: <anxdf0ee_-CpDU1S@mdjait-mobl>
Thanks for all the reviews Mehdi. Much appreciated!
On 12/08/2026 14:53, Mehdi Djait wrote:
> Hi Matti,
>
> Thank you for the patch!
>
> On Mon, Aug 10, 2026 at 10:55:25AM +0300, Matti Vaittinen wrote:
>> From: Matti Vaittinen <mazziesaccount@gmail.com>
>>
>> The "interrupt polarity high" -macro for KX022A variant is defined as:
>
> -macro ?
Yes, the "interrupt polarity high"-macro ;) I should probably have used
the proper name of the macro here ^_^;
> defined as what ?
as "KX022A_MASK_IPOL1". Seems like my brains moved to the next topic
before hands finished writing this one :| Thanks for pointing it out :)
>> However, the KX022A_MASK_IPOL1 is not defined anywhere, so actually
>> using the KX022A_IPOL_HIGH would produce a compile error.
>>
>> Fix the define by using correct mask.
>
> Reviewed-by: Mehdi Djait <mehdi.djait@linux.intel.com>
>
Yours,
-- Matti
--
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland
~~ When things go utterly wrong vim users can always type :help! ~~
prev parent reply other threads:[~2026-08-14 7:43 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-10 7:49 [PATCH 00/12] ROHM IIO fixes Matti Vaittinen
2026-08-10 7:49 ` [PATCH 01/12] iio: adc: rohm-bd79124: Fix rising alarm Matti Vaittinen
2026-08-10 7:50 ` [PATCH 02/12] iio: adc: rohm-bd79124: Fix channel initialization Matti Vaittinen
2026-08-10 7:50 ` [PATCH 03/12] iio: adc: rohm-bd79124: Fix GPIO mask check Matti Vaittinen
2026-08-10 7:51 ` [PATCH 04/12] iio: adc: rohm-bd79124: Catch regmap errors at measurement start/stop Matti Vaittinen
2026-08-10 7:51 ` [PATCH 05/12] iio: dac: rohm-bd79703: Do not allow writing SCALE Matti Vaittinen
2026-08-10 7:52 ` [PATCH 06/12] iio: pressure: rohm-bm1390: Return error when read fails Matti Vaittinen
2026-08-10 7:53 ` [PATCH 07/12] iio: pressure: rohm-bm1390: Fix AVE_NUM initialization Matti Vaittinen
2026-08-10 20:06 ` Andy Shevchenko
2026-08-11 9:05 ` Matti Vaittinen
2026-08-11 10:08 ` Andy Shevchenko
2026-08-10 7:53 ` [PATCH 08/12] iio: light: rohm-bu27034: Fix error return Matti Vaittinen
2026-08-10 7:54 ` [PATCH 09/12] iio: light: rohm-bu27034: Fix infinite delay on error Matti Vaittinen
2026-08-10 20:09 ` Andy Shevchenko
2026-08-11 9:07 ` Matti Vaittinen
2026-08-10 7:54 ` [PATCH 10/12] iio: accel: kionix-kx022a: Fix array boundary check Matti Vaittinen
2026-08-12 11:43 ` Mehdi Djait
2026-08-10 7:55 ` [PATCH 11/12] iio: accel: kionix-kx022a: Prevent memory leak and fix state Matti Vaittinen
2026-08-12 11:47 ` [PATCH 11/12] iio: accel: kionix-kx022a: Prevent memory leak and fix statey Mehdi Djait
2026-08-14 7:39 ` Matti Vaittinen
2026-08-10 7:55 ` [PATCH 12/12] iio: accel: kionix-kx022a: Fix IPOL macro name Matti Vaittinen
2026-08-12 11:53 ` Mehdi Djait
2026-08-14 7:43 ` Matti Vaittinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e82d7fd-37f1-40fb-9c5b-aea753cc0a13@gmail.com \
--to=mazziesaccount@gmail.com \
--cc=0012-iio-accel-kx022a-Fix-IPOL-macro-name.patch@mva-rohm \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=javier.carrasco.cruz@gmail.com \
--cc=jic23@kernel.org \
--cc=kaleposti@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matti.vaittinen@fi.rohmeurope.com \
--cc=matti.vaittinen@linux.dev \
--cc=mehdi.djait.k@gmail.com \
--cc=mehdi.djait@linux.intel.com \
--cc=nuno.sa@analog.com \
--cc=sonkajarvi@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®