From: Maxime Chevallier <maxime.chevallier@bootlin.com>
To: Aleksei Sviridkin <f@lex.la>, netdev@vger.kernel.org
Cc: andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net: phy: reject attach while the PHY driver is in transition
Date: Thu, 17 Sep 2026 14:00:21 +0200 [thread overview]
Message-ID: <6e82dc04-a68d-4c54-a6f0-a13c04fa2eef@bootlin.com> (raw)
In-Reply-To: <20260914204200.2743251-1-f@lex.la>
Hi,
On 9/14/26 22:42, Aleksei Sviridkin wrote:
> phy_remove() clears phydev->drv as its last act; the driver core
> clears d->driver only afterwards, in device_unbind_cleanup(). In that
> window phy_attach_direct() skips the genphy substitution, because
> d->driver is still set, and then dereferences the NULL phydev->drv in
> phy_drv_supports_irq().
[...]
> Verified on an MT7981 board (mtk_eth_soc GMAC, "MediaTek MT7981 PHY" at
> mdio-bus:00), 6.18.44, with a 200 ms msleep() added at the end of
> phy_remove() to hold the window open. Two images, identical except for
> this patch.
If you need to add msleep(200) in the core of the framework to trigger that,
this is net-next material.
Maxime
next prev parent reply other threads:[~2026-09-17 12:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-14 20:42 Aleksei Sviridkin
2026-09-17 11:43 ` netdev-bot+sashiko
2026-09-17 12:00 ` Maxime Chevallier [this message]
2026-09-17 18:33 ` Aleksei Sviridkin
2026-09-17 20:30 ` Maxime Chevallier
2026-09-17 21:04 ` Aleksei Sviridkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e82dc04-a68d-4c54-a6f0-a13c04fa2eef@bootlin.com \
--to=maxime.chevallier@bootlin.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f@lex.la \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®