From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0D5FF2FFDDE for ; Thu, 23 Apr 2026 08:07:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776931634; cv=none; b=Mbvb2drfPUH5ELl0EFEYoLe80ER5gCXG213Dei7fC2kCWi3UCPolvl3+HU9Gvn9KNrki6KKg4xSze3EROYPSrFlU5/TJ4sGGSmuhjpIj0u0V1zd10K2H+6x164BQ5xEvoT6uqL93G4Utt1fnHPBbt8DxDMZfcrDG2avYjAlyUHQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776931634; c=relaxed/simple; bh=9+0W2VWdwc2cB9MzpKPzLqvQtBRd88DboztIZvW7wcU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=YrUlBoOZPo/qDi/0dUpkGlcd67mwisnsCnFIUd4lzMWWYFoSQPXBQGzEpwNHcxR9hbZXVFsmKBuFDA+GYuyxhCS9o7u+Rd2tTLYUHA10eDUz1OVGkDqBuJ7cXlSoJFOtkp1X8O2nVvNWlfAEeYSwh4KPEdleYt+IH7fr3PJS2K4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ogLZ41lT; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Y814IOjt; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ogLZ41lT"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Y814IOjt" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63N3WdSO1230241 for ; Thu, 23 Apr 2026 08:07:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 5cA4KLyFriM7ec4/EYZtlcwbpyBshVV3+QDW2hRa3qk=; b=ogLZ41lTaJKrurR0 LMjZ7doJ63U2gowFEBxYYJC1DtJphoGHOdgmLh7yyncX41fP374tLPyAfH+el4JK WtSzbM/mGa5NRX/dE28zlfqPupu62h2WvBa0SxpDqtHnriwrTJWsDEijVCWINHGR WWCRiq/V0wHBnuD1wMhOdekBOZ1ebglFSkgPNYRoPiw84FzHHiCChdcR26NYud4s GvG8aGEHxRYhVum8JYomLllzOlNCVxi4AznlEj7xjz2DHn9mZswI+pKu4/kxqhir ypuXg0RU6hWfQ8cSxy7FL6Ysh9A7GjSP2RQpx6jvyLc1aWLH4DDPc/hxI+se2ICv dQ6TaQ== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dq1h6avpe-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 23 Apr 2026 08:07:12 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2b2d83e7461so107310155ad.3 for ; Thu, 23 Apr 2026 01:07:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776931631; x=1777536431; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=5cA4KLyFriM7ec4/EYZtlcwbpyBshVV3+QDW2hRa3qk=; b=Y814IOjtf9ZS9ObWnNThH/Lsxn0Mem+6vKAmqQlwa6+Xl7M9tc1Cbg+uuHobkYUqe+ ApHNcFnCQkpK5iK9sPfjTcGBbUR0gk+VvuwXvpVOoWIsRKcaPzIVnQTQoxeqEJjiHLwI 61IbD0rOEB03KciccjwxxiZlXosoiFmh4Ns2XDP5Q2s+xA7WV/A3QTPHKIzoFAgSoz+f RpVnVt5DnL/ms6Vvav2LrHcMVsy7NQxSu2L39ht1UvXZWFbSKmTxzcV5pHkCzHz90RSX m6OhzMA4AcBP08lPRhnZnG1K7D4ifyWu019rKkZTzEDI/22U5NVVYEwli3OXYS/vXMRH aF1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776931631; x=1777536431; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=5cA4KLyFriM7ec4/EYZtlcwbpyBshVV3+QDW2hRa3qk=; b=HVO4k6ZAMefXag7A+ANODApo7Y/yaiIIzgYJLI5UJJtRTAnLw2myBgvtOofrfcBlfe CkU3GGg0lhadrHyN8H1juP5IIyJH8mWSCzhdlTvHg+YwNAjtzHQfLouR/+CivSV+rUmW vXAsrMgoR3KEdZnkGSgALsxM6iC4wyUiR4z6aGBfWsNrDU+k4FskgDBDYjj/20/Im3Vh yzkEz56S6m5Vun4o/CNyxZiW5VAeIOEWgSWlntpczQ/+DZ2tIzYgWZGxwg0vsKSghebS dHUFEL+AfrlBvPxtW/mRRwyPbLkcYP+ByFG2FbUVRRy2RoioiVOjgjTuN44I6HNsEABi UG2w== X-Forwarded-Encrypted: i=1; AFNElJ/ODDx7GQMWPDrVjTc4f/VpJ6ZlLoj1f5FlOAFQwIngD/CS4t1+FyxDGTbLSBiZytK8WKdy8aaZ8IZprMM=@vger.kernel.org X-Gm-Message-State: AOJu0YyzJG9sJ7mb8HQkaXNLRqwKn1vgyibpBJmHPI9o2vkwbBUggp84 vIcllwLLk8QUK7V7Pa2yMObInVEj1EYXioUhdI3gHENnA70NJ/wa5NNFLEnUx+J1j7vXIgEjgyL XsFrlHRBbgv1lPeErYPz5pKLJIrFv/Crg1BHkt72lEbSfy2a+wK5vbOR6TlA3oiexA6A= X-Gm-Gg: AeBDievqcYkuu4mit/6iqE4jYlLOQaUd02W9s4T4PdbozDUdC0WMyQ6fmmwiCEuLsm3 SIMrS9grCmU+9HPj8+/FE/8puKKGLBvbFDJpzDZ3tJ3a5ArCycs2uZQOV5jMVYF0rjXirSUfeqa Wj1sK6QuNtqk/Z77qBDcT8a5mnczd8GIC+w7Wx0xVgyR5jFJRRrPnY2m+Ag8l0wGEiJteuogzH+ 0EWNhSs++RVCxbL7jTB5q6YvqdzOdsp+s7QrQ8mTqpBHHLE5H1NZvNpsbwvb5gqRNqK6uOZPMUL IuMGDLGB2RIIunQiJTgBHqY3/FLqS7xdPZ13wVq1XScILBvSgxmMO98mZzVb0M5enBjXUQ5ia3m PO/kFSUFljR5Q3YZewbzbw0eZU+HuXQSkXt7n7n98BgsIPqdoa/sHb2kx5EHW X-Received: by 2002:a17:902:9a4a:b0:2b2:4eec:9806 with SMTP id d9443c01a7336-2b5f9e78234mr194281345ad.8.1776931631565; Thu, 23 Apr 2026 01:07:11 -0700 (PDT) X-Received: by 2002:a17:902:9a4a:b0:2b2:4eec:9806 with SMTP id d9443c01a7336-2b5f9e78234mr194281025ad.8.1776931631021; Thu, 23 Apr 2026 01:07:11 -0700 (PDT) Received: from [10.218.10.142] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b5fab30f29sm185133235ad.68.2026.04.23.01.07.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Apr 2026 01:07:10 -0700 (PDT) Message-ID: <6e8f523f-7ad4-4472-aca8-118de81223e7@oss.qualcomm.com> Date: Thu, 23 Apr 2026 13:37:06 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] arm64: dts: qcom: hamoa-iot-evk: Enable retimer on USB0 port To: Dmitry Baryshkov , Konrad Dybcio Cc: Bjorn Andersson , Konrad Dybcio , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krishna Kurapati , stable@vger.kernel.org References: <20260422093924.2976069-1-prashanth.k@oss.qualcomm.com> <6c2c5fd6-c032-4658-9a15-039c77074c4b@oss.qualcomm.com> <8cb5e28c-1c6e-450e-855b-32491ee73885@oss.qualcomm.com> <3d50f17c-060a-4a1d-b539-1bea9b3e6cd0@oss.qualcomm.com> <79926b02-a892-4e59-b794-e8534136fe07@oss.qualcomm.com> Content-Language: en-US From: Prashanth K In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=f4Z4wuyM c=1 sm=1 tr=0 ts=69e9d330 cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=VwQbUJbxAAAA:8 a=BqLQL_UPtuLX997o1IYA:9 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDIzMDA3NyBTYWx0ZWRfX6avU2Y0AxS4A IpcrOdGdLUp4pbUVO5RGVWgEkwXyBCF7kdbcQW2J8tLNFOzS8gfG0PEcYHaKDLYFZ5Wj/1cnl87 WbQBGiiq2xXAeX7+QdN6D94QDmQJMux9lm4n8i6aBwAOr6x4BRRFwxH7g1Wemq5WsqLArNqn3aI yO4wx/vfCpvsejDVMRBet9WdRtjmSeAQR6oKczQ4qOMB5tqZrd40IprG/GQBMMbOwU20h5Iye3C rjgxBl0KqZ00R8Jzo5rtn5muBWMQiI/TxjGHdcDdyo/7MJpHOditzdbTdKWIkuowgCl/RzV1Ilp 7zk/XfpW0o28H878MXchvLPdIiu6wrsBwThZM3evaDXRHPlSaRawBh+DixvhXgOc0A9BQJtbHli N6AmE9UrlIQ5zO/IRYb0nMW3jR9qeW4cAKIJCTKOW/tk3J+e6g2+43ish8EQB+dcDxpGfaH+yLk mpDhjyCg8M6eCLdHg/A== X-Proofpoint-GUID: S_ob3NjOjVNKKR6sawvJJdXxDetWz33e X-Proofpoint-ORIG-GUID: S_ob3NjOjVNKKR6sawvJJdXxDetWz33e X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-23_02,2026-04-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 phishscore=0 bulkscore=0 malwarescore=0 clxscore=1015 spamscore=0 suspectscore=0 adultscore=0 priorityscore=1501 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604230077 On 4/22/2026 5:22 PM, Dmitry Baryshkov wrote: > On Wed, Apr 22, 2026 at 01:09:22PM +0200, Konrad Dybcio wrote: >> On 4/22/26 1:04 PM, Prashanth K wrote: >>> >>> >>> On 4/22/2026 4:13 PM, Konrad Dybcio wrote: >>>> On 4/22/26 12:32 PM, Prashanth K wrote: >>>>> >>>>> >>>>> On 4/22/2026 3:56 PM, Konrad Dybcio wrote: >>>>>> On 4/22/26 11:39 AM, Prashanth K wrote: >>>>>>> Add the retimer for usb_1_ss0 port (USB0), in order to enable >>>>>>> super-speed enumeration on that port. >>>>>>> >>>>>>> Fixes: c11645afb0e2 ("arm64: dts: qcom: Add base HAMOA-IOT-EVK board") >>>>>>> Cc: stable@vger.kernel.org >>>>>> >>>>>> This is a feature addition, not a fix >>>>>> >>>>>> [...] >>>>>> >>>>> Sure. >>>>>>> + ports { >>>>>>> + #address-cells = <1>; >>>>>>> + #size-cells = <0>; >>>>>>> + >>>>>>> + port@0 { >>>>>>> + reg = <0>; >>>>>>> + >>>>>>> + retimer_ss0_ss_out: endpoint { >>>>>>> + remote-endpoint = <&pmic_glink_ss0_ss_in>; >>>>>>> + }; >>>>>>> + }; >>>>>>> + >>>>>>> + port@1 { >>>>>>> + reg = <1>; >>>>>>> + >>>>>>> + retimer_ss0_ss_in: endpoint { >>>>>>> + remote-endpoint = <&usb_1_ss0_qmpphy_out>; >>>>>>> + }; >>>>>>> + }; >>>>>>> + >>>>>> >>>>>> Stray \n, but you should really have a @2 port here as well. >>>>>> >>>>>> Konrad >>>>> Can we ad port@2 and leave it empty? >>>> >>>> Why would you? Just connect it to port2 of the connector under pmic-glink >>>> >>>> Konrad >>> >>> Because the port@2 of pmic-glink (pmic_glink_ss0_sbu) is already >>> connected to usb-1-ss0-sbu-mux (onn,fsusb42). This is different compared >>> to other connectors. >> >> Are both the SBU mux and the Parade retimer present on board? >> >> The former is redundant since the retimer already has a superset of its >> functionality, so that sounds rather odd. > > fsusb42 might be also used to switch SBU lines for other purposes (e.g. > for the debug). > I just checked, fsusb42 is not present in evk, not sure why it was added in the first place. Will link the retimer port@2 with pmic-glink. Regards, Prashanth K