From: Ekansh Gupta <quic_ekangupt@quicinc.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: <srinivas.kandagatla@linaro.org>, <linux-arm-msm@vger.kernel.org>,
<ekangupt@qti.qualcomm.com>, <linux-kernel@vger.kernel.org>,
<fastrpc.upstream@qti.qualcomm.com>
Subject: Re: [PATCH v1] misc: fastrpc: Reset metadata buffer to avoid incorrect free
Date: Fri, 29 Sep 2023 12:53:02 +0530 [thread overview]
Message-ID: <6e9200a1-cf3c-27ca-ceef-7d9b70297530@quicinc.com> (raw)
In-Reply-To: <2023092840-balmy-proved-e337@gregkh>
On 9/28/2023 6:38 PM, Greg KH wrote:
> On Thu, Aug 31, 2023 at 12:05:23PM +0530, Ekansh Gupta wrote:
>> Metadata buffer is allocated during get_args for any remote call.
>> This buffer carries buffers, fdlists and other payload information
>> for the call. If the buffer is not reset, put_args might find some
>> garbage FDs in the fdlist which might have an existing mapping in
>> the list. This could result in improper freeing of FD map when DSP
>> might still be using the buffer. Added change to reset the metadata
>> buffer after allocation.
>>
>> Signed-off-by: Ekansh Gupta <quic_ekangupt@quicinc.com>
>
> What commit id does this fix?
>
> And you sent 3 patches, but not in a list, what order are they to be
> applied in?
>
Thanks for reviewing the patches, Greg. I'll send the 3 patches as a
patch series for better understanding.
-ekansh
> thanks,
>
> greg k-h
prev parent reply other threads:[~2023-09-29 7:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-31 6:35 Ekansh Gupta
2023-09-28 13:08 ` Greg KH
2023-09-29 7:23 ` Ekansh Gupta [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e9200a1-cf3c-27ca-ceef-7d9b70297530@quicinc.com \
--to=quic_ekangupt@quicinc.com \
--cc=ekangupt@qti.qualcomm.com \
--cc=fastrpc.upstream@qti.qualcomm.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®