From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A512C433F5 for ; Thu, 7 Oct 2021 13:13:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1DF6B61074 for ; Thu, 7 Oct 2021 13:13:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241528AbhJGNOx (ORCPT ); Thu, 7 Oct 2021 09:14:53 -0400 Received: from smtp-relay-internal-0.canonical.com ([185.125.188.122]:50930 "EHLO smtp-relay-internal-0.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241317AbhJGNOr (ORCPT ); Thu, 7 Oct 2021 09:14:47 -0400 Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 4AC3C40009 for ; Thu, 7 Oct 2021 13:12:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1633612373; bh=iirK3i9WG+HMUrskVNYjHF1PRpxBdgd8IKVUip8gjUQ=; h=Subject:To:Cc:References:From:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=UzN7h64Id7SHnxwBiLhjP5D9qD3+3i5DPAyiKndQPadyaA84P6kLZ3dvOu9aW8BIp YjrwummcSVlZ0mE7Hw8kcgnJtXrVxP745ShPJ6sERP2DOmu1Ch7r4jglRXogA8StXZ thJZdmzoTVZoFW/qpA/5nWuUatIFLxD71hh4PoSN3IX1aHrrBNSVpujXrN0QskAH0h AMS7aXXhPrZ51zudiCTil9Sdu91v0aQs+y5oMXeEgxwNCrWAh/wMq4MoTQaYSMU6jD IanjnqdxT1UVCPj0V26/j6M6nxsV2ZCu4aZO+w48bwMbq1RI2FHh/4wCFjSzz7e33h fdZQbiqERP08g== Received: by mail-wr1-f69.google.com with SMTP id o2-20020a5d4a82000000b00160c6b7622aso4574877wrq.12 for ; Thu, 07 Oct 2021 06:12:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=iirK3i9WG+HMUrskVNYjHF1PRpxBdgd8IKVUip8gjUQ=; b=COyjqx2/CPYPa8jH+Oc42Ea22Xg+7Qx+Pm41eXQBomyAZaNbuwkrbiy7joY3L5gUuV euyygD0mXERYuWSMiIXary9oAdPROh8l9XSKv/25I5qBzL3h/2NVnsBcVH+t1IsCCTHd UCNj0XahmwuIPPEozR8qnjRBBUdqtrGCUe6JLSdHlu6dTG33klSxh+6kbFNmnsL1sm0e gv2oNi0xZJh5z0brYvDl6qd8JMLa1E56AszXfvtJBwp1AJWyMKxLEtMkLR8D3jU9VSDH qqi3aZIAAkP531GPxRhvmcQuWva7rzeAOBtjQMJjPfda4TaYc3xOamTj+RGyOGoW5n3S 1u5A== X-Gm-Message-State: AOAM5330mf87ATT1ZUsXvDAcMUGU3Xs0OzaVukjsfs9dmhuZA5Wb8DNB 5XToqXPR0pH4qLxUiChuTEPZ3K6kfVEUj3KjGogcnqes058P5NMIYZwfFj/XuwxOoA2PT7WbvF+ g8OiQBJbGf5eL49ELO07yM7B7iJiA201NY/ImTs7CdA== X-Received: by 2002:adf:e8d2:: with SMTP id k18mr5360895wrn.219.1633612372789; Thu, 07 Oct 2021 06:12:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw3hpfP4OSaat1L3xt+PSv3NTONOShlxrR7nAUJcdNm/g+TtJbmwx0s/MXDAzkDO+Y0ZGjeDw== X-Received: by 2002:adf:e8d2:: with SMTP id k18mr5360863wrn.219.1633612372674; Thu, 07 Oct 2021 06:12:52 -0700 (PDT) Received: from [192.168.1.115] (xdsl-188-155-186-13.adslplus.ch. [188.155.186.13]) by smtp.gmail.com with ESMTPSA id p13sm5355062wma.22.2021.10.07.06.12.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 Oct 2021 06:12:51 -0700 (PDT) Subject: Re: [PATCH 2/7] dt-bindings: power: Add apple,pmgr-pwrstate binding To: Hector Martin , linux-arm-kernel@lists.infradead.org Cc: Marc Zyngier , Rob Herring , Arnd Bergmann , Linus Walleij , Alyssa Rosenzweig , Greg Kroah-Hartman , Mark Kettenis , Philipp Zabel , "Rafael J. Wysocki" , devicetree@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-serial@vger.kernel.org References: <20211005155923.173399-1-marcan@marcan.st> <20211005155923.173399-3-marcan@marcan.st> <5b89aed0-f9b7-fdba-16d8-a8bd9e2d7437@marcan.st> From: Krzysztof Kozlowski Message-ID: <6e92a8d3-798a-267a-d24e-6b9ff0c3c645@canonical.com> Date: Thu, 7 Oct 2021 15:12:50 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <5b89aed0-f9b7-fdba-16d8-a8bd9e2d7437@marcan.st> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/10/2021 17:59, Hector Martin wrote: > On 06/10/2021 16.05, Krzysztof Kozlowski wrote: >>> + IP cores belonging to a power domain should contain a >>> + "power-domains" property that is a phandle for the >>> + power domain node representing the domain. >> >> Skip this last paragraph - it is obvious in usage of power domains. >> Specific bindings should not duplicate generic knowledge. > > Ack, I'll drop it. > >>> +properties: >>> + $nodename: >>> + pattern: "^power-controller@[0-9a-f]+$" >> >> Usually we call nodes as power-domain. > > I had it as that originally, but these aren't power domains. These are > power management domains (they can clock *and* power gate separately, > where supported) plus also do reset management. So I wasn't sure if it > was really fair calling them "power-domain" at that point. OK, thanks for explanation. > >>> + power-domains: >>> + description: >>> + Reference to parent power domains. A domain may have multiple parents, >>> + and all will be powered up when it is powered. >> >> How many items? > > One or more (if there are none the property should not exist). I guess > that should be encoded. Probably this should not go without any constraints. Are you sure it could have more than one? It would mean more than one parent. Best regards, Krzysztof