From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8199A3F0AAD for ; Fri, 10 Jul 2026 08:28:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783672112; cv=none; b=SADwlrov3jCeMccyvLDyswHP6KlzR49GkIPzarsfp8wZY/9eMgQ2ERMq+JMzGwAMBnL1IsCBgtO+BjgSrx+7zHBEaTl0smqX7vuFYYS1SnN4NwZpC7O5Am36DaqkVmPHdxAciU/U13azCc0WfQos8AJlxB0pU+6i3FWZwbpEITg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783672112; c=relaxed/simple; bh=vr3J4Ah6TFyjmNOt7bQrHjkTvfkgZCWxs+iaTw5TBhM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=F3QBzRhmZpfp7cjMMDcsNTbDxgrKxVJ6QF/Wto5105YM6z7y3LfC89v94EGv0VDk6s6VbrzYkjp7WxU8nchkEgnEeXkC1oP31CZNdIKnFtz2BOdI6cBgC48ohRxqstkTkYcOJ7syMkA+5NR/PvR9sCRzrOENHDVj+IXh+ZVgtp4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=KluTD8RJ; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ZBQwGg7a; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="KluTD8RJ"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ZBQwGg7a" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66A7eHUU141512 for ; Fri, 10 Jul 2026 08:28:28 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= cA+3fVMURMQV7pN3n2WY+GcSkJAyciW1cmPl1kI+vaE=; b=KluTD8RJxNfUx5G8 TkpEu9xIr6p85PRKtw/iz+oe6muBssXSK+AQi6RcYEAwvZdK1khlaEbcxdVnovQb Nqln0uimfviWbaEXXYsftLuTcChFX32/k1SDm2jSGFaOpGFuDNI4DLnkWczbRFP2 2xUR3DD5lzS5ETB8N7NEfvH/ytnjr4mokcbl/FD0Xz83BTbmB0GbQea47t+mE8Em 8MoNVr94uTSV2HS+Yzgkmh1+wSwD41dvE87wd6jIMECWhoUG0sqUizuGj4HPiFsL 925ov0D7qIYnufpMZzVq3U4Fepo+l5kpEqt8e49fiSYOBSIqPUz7U0VFOqRB728r GQ7aTw== Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4faf5mu9r2-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 10 Jul 2026 08:28:28 +0000 (GMT) Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-8f000e221d7so10347006d6.0 for ; Fri, 10 Jul 2026 01:28:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783672108; x=1784276908; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=cA+3fVMURMQV7pN3n2WY+GcSkJAyciW1cmPl1kI+vaE=; b=ZBQwGg7amnKGcNx5eTOpUJCzG7U4S4BvIbHpnNSRKxXFOq/MYb7BLGa8DsjaT0VaaX QinnGB3CrnDjZt5PorhXrWeAtvWEDj9SEK8Q9SdWad9kjd+1xWTicmbmDZjtIoCUbROT 6rA2xJsRFD9niGguvx8y6qOJlcpxNph/nVVN/SBBhYLqZzDjruO+R9hoT1YRTs1cZcy3 heLzPppYto7/dEinq27PO+/twE1/8f2BnK0ygBef0aW3DCnezpSlhmZC17rAt6QeeHPq PtEHU8g0tnKZX9OljOlYLZ0Gaqpt1p/VgQviuN6rEj6nulNNlZOirqBCCg4/yXc1bNv/ Clvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783672108; x=1784276908; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=cA+3fVMURMQV7pN3n2WY+GcSkJAyciW1cmPl1kI+vaE=; b=FC8ZHAzSpBQwahXoqxVMYMn0R2KJH4XDmdXQevXqWUMaOX0+EMU7xxBKGMYK9nAbgs p9QxT8NNyHvnv+gO/rQUQil+gouEH3qYWeUC03vtGg86NBK1fZG/a1knEFD7iiQk820H RnUz90VscgJLPzANVI1CagYKSHQB7nxxqbK0fiNcDEM3uKD6WtV52dOLNCG+r9PSq3VH zY2hmLFLq87z92dvSDKoDR8sX7LKFwWC13mAQ1o5bQgUVRwKzBzAWgAbNg1QPFNaKh3/ of+VcCzcQ19V60XChFZhmf2G2yPMHD7nj5ekL8Enz266BFOtf18wnGKbH00SO0YrUIT7 eX5Q== X-Forwarded-Encrypted: i=1; AHgh+RpSpt86PrQGLtXTUy7zExPad8u4ZQ/hH3idRGG9IHsxdyD16WUinn7fnASmDJWWntSZZ0B38L+/RF9V41E=@vger.kernel.org X-Gm-Message-State: AOJu0YzWbl72gM5bTyaW/FCuiFrFg0mL310eYFz3dXzWF7pUe3p7PBqp zznq7Gmk/kil9FZQ07gOtmMa5DZhZ3x1i3Q+/2968P0QjuSjMzLT/xQgzPMeA3YhnKeYv9llYtL u8+UH/tSJCe4N6B3zuy3BZ1vq9cwuOIFkJEOKzKAH+ViApjXNvVTJMO/sTiSHMukQcIU= X-Gm-Gg: AfdE7cmod2Co1QFE474nT5QwXtB6PTKv6UTHNAimf5reHQVseWDGMr26cbrYGkOpl6j QrLfVQo9HJMNSdR9T0+42gT7/um5t89jfGzTd6ujgmFc4qPtEiHJPygS6kB/Kg/M0+CXYRAiLOc 5nbP7rb6m7TK5OCEJcFfJJV/l54S6+KUICwaHDP2gxz/u0dSOC40nXyz3gMxpCn0emrUHSSRN/x Dv983IMN6hd0I8GbNAfkTb1dYdjdWoaOHZBeuZ0OljDuwDI+/VQ0Khrg7e5uIj//X8xVgqu1j5F 6t31MMwwLBsAgFjrNzo2R8Mesnq5cnj8XerW6GYlWfVbZvuV7UDZKvMl7tqv4m3/4Rv4tq/8cNc YgaFr8tpXTEBpqBxXByIf26mX2y2tgVPicR5LV7OXeDB9Fw== X-Received: by 2002:a05:622a:4d05:b0:51c:7d0:7ed7 with SMTP id d75a77b69052e-51c8b31e045mr122859111cf.39.1783672107580; Fri, 10 Jul 2026 01:28:27 -0700 (PDT) X-Received: by 2002:a05:622a:4d05:b0:51c:7d0:7ed7 with SMTP id d75a77b69052e-51c8b31e045mr122858921cf.39.1783672107193; Fri, 10 Jul 2026 01:28:27 -0700 (PDT) Received: from [192.168.0.172] ([49.205.253.142]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c15c6bd0d72sm405268566b.7.2026.07.10.01.28.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Jul 2026 01:28:26 -0700 (PDT) Message-ID: <6e955b2d-3889-4387-9f85-2b000a9599b2@oss.qualcomm.com> Date: Fri, 10 Jul 2026 13:58:18 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] media: iris: disable time-delta-based rate control for VBR To: Vishnu Reddy , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Dmitry Baryshkov , Neil Armstrong Cc: Bryan O'Donoghue , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Gourav Kumar References: <20260710-qc10c_fix_and_disable_time_delta_based_rc-v2-0-701d6dfd1ac1@oss.qualcomm.com> <20260710-qc10c_fix_and_disable_time_delta_based_rc-v2-2-701d6dfd1ac1@oss.qualcomm.com> Content-Language: en-US From: Vikash Garodia In-Reply-To: <20260710-qc10c_fix_and_disable_time_delta_based_rc-v2-2-701d6dfd1ac1@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: NbIbaIJgQ6vAsz1QAG6wkNfGj92v0L3a X-Proofpoint-Spam-Info: AW1haW4tMjYwNzEwMDA4MSBTYWx0ZWRfXz/FTudqHThq/ 2jQKH11bPw3kNPEZspZA7HvNeoOOqMCdpoIg3q1nYnGd9xeRBZShaFfhBG6NGeiQMywCSXlCkTW D0LGGEQwvq3yX3A4ChjECbjUVeTrIpc= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzEwMDA4MSBTYWx0ZWRfX6vAMT9w24BcC +EnWGioweYKFA/NGitwc1BXhxkBpDnrTN5bUgbW3cJlRX07mBzm6RQlD5FLq5jdW8wj+s8F/ZoZ NOgso1pemS8tWTMXSl8m6wGR7otXq+cx5xlj9vC25HxGNYWt5IJnuX4dhnq8lquYMpDpEllCnEF oYHPh1E2nc/tagYMmGB/v2rVNT+kwAkcVqryIaxJfr0hkz+MfQwlFX0pr+t8XK2yVpiKFPJH7FL vpHbpol+JTXe6PT5er63wmbuSbO/zGqT0X/za4C3NNRj0k6nduo1CIRO0PurHIYHoAeykWR/U4Q lu9Ym1rX7NrUCGKfv6HH+FX4cFvApPjumBx4Bemz5Xb+uzfSGdxLX/A789EXsZkEQuOnW1rg6kr sVoHtYXWUnN5U1UqH/UmaAflyPZkR4HTSwnTg9OEJirPJsIWyPuyBZ9t8qOndlP+zAVN54AkEwQ XCHJTNqevQ7SyKUukOg== X-Proofpoint-GUID: NbIbaIJgQ6vAsz1QAG6wkNfGj92v0L3a X-Authority-Analysis: v=2.4 cv=N+QZ0W9B c=1 sm=1 tr=0 ts=6a50ad2c cx=c_pps a=oc9J++0uMp73DTRD5QyR2A==:117 a=MoCqpHF70WjPNMFBpltNPQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=kaZPDjHNpzmdL6TKSoIA:9 a=QEXdDO2ut3YA:10 a=iYH6xdkBrDN1Jqds4HTS:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-10_02,2026-07-09_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 malwarescore=0 priorityscore=1501 phishscore=0 adultscore=0 suspectscore=0 impostorscore=0 spamscore=0 lowpriorityscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607100081 On 7/10/2026 8:24 AM, Vishnu Reddy wrote: > From: Gourav Kumar > > The iris encoder driver was not sending > HFI_PROP_TIME_DELTA_BASED_RATE_CONTROL to the firmware during encoder > initialization. Without this property, the firmware defaults to > time-delta-based rate control (enabled), which calculates the output > bitrate from actual frame timing rather than following the configured > bitrate target. > This caused variable bitrate (VBR) encoding to produce ~5x configured > bitrate. For example, with video_bitrate=896000 (896 Kbps), the output > is ~4.4 Mbps instead of the expected ~896 Kbps. > Time-delta-based rate control is designed for variable frame rate (VFR) > scenarios where the encoder adapts to actual frame timing. However, when > an application explicitly configures a bitrate target, the firmware must > follow that target regardless of frame timing. > Fix this by adding the TIME_DELTA_BASED_RC capability with a default value > of 0 (disabled) and sending HFI_PROP_TIME_DELTA_BASED_RATE_CONTROL = 0 to > the firmware during stream-on, allowing the firmware to use the configured > bitrate as the target. > > Signed-off-by: Gourav Kumar > Signed-off-by: Vishnu Reddy > --- > drivers/media/platform/qcom/iris/iris_ctrls.c | 19 +++++++++++++++++++ > drivers/media/platform/qcom/iris/iris_ctrls.h | 1 + > drivers/media/platform/qcom/iris/iris_hfi_gen2.c | 10 ++++++++++ > .../media/platform/qcom/iris/iris_hfi_gen2_defines.h | 1 + > .../media/platform/qcom/iris/iris_platform_common.h | 1 + > 5 files changed, 32 insertions(+) Reviewed-by: Vikash Garodia