From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751615AbdBUPJr (ORCPT ); Tue, 21 Feb 2017 10:09:47 -0500 Received: from mail-sn1nam01on0049.outbound.protection.outlook.com ([104.47.32.49]:44032 "EHLO NAM01-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751072AbdBUPJf (ORCPT ); Tue, 21 Feb 2017 10:09:35 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Thomas.Lendacky@amd.com; Subject: Re: [RFC PATCH v4 00/28] x86: Secure Memory Encryption (AMD) To: Borislav Petkov References: <20170216154158.19244.66630.stgit@tlendack-t1.amdoffice.net> <20170218181209.xk5ut4g65f2fedzi@pd.tnic> CC: , , , , , , , , , Rik van Riel , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Toshimitsu Kani , Arnd Bergmann , Jonathan Corbet , Matt Fleming , "Michael S. Tsirkin" , Joerg Roedel , Konrad Rzeszutek Wilk , Paolo Bonzini , Brijesh Singh , Ingo Molnar , Alexander Potapenko , Andy Lutomirski , "H. Peter Anvin" , Andrey Ryabinin , Thomas Gleixner , Larry Woodman , Dmitry Vyukov From: Tom Lendacky Message-ID: <6e95ee26-a46d-e85b-ade7-c3973f0355e9@amd.com> Date: Tue, 21 Feb 2017 09:09:27 -0600 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <20170218181209.xk5ut4g65f2fedzi@pd.tnic> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: MWHPR10CA0007.namprd10.prod.outlook.com (10.172.48.17) To CY4PR12MB1141.namprd12.prod.outlook.com (10.168.163.149) X-MS-Office365-Filtering-Correlation-Id: e23c5484-3194-4f8d-3f70-08d45a6ba43c X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(48565401081);SRVR:CY4PR12MB1141; X-Microsoft-Exchange-Diagnostics: 1;CY4PR12MB1141;3:Wvypb2yz28lxIzkXEfhhAEiA5Y1eL5jhb/UCf8PhKTWlc8NOSUF4RbxwKolEYAeq088tFNa6JQh4335xECGT4Yedfr8gKBILJMmbZ9X+1V6J/+A9lMhwRvQxky1qZTFkWsuyVnPpnowjZedSyjakoarxOGjna4OXtr5YpkPsxlCdqMRn4E2o8dr4Pp3Qc61qia45iHLY8KizTE/P+B/Uvy8X8PnVOvEXvwrIN78CYktLreCSl/NpHLOT5Aq+73ONmoCY10+gnZO34gSp4AUMqhPAPq/tHs1hWOzu2PVMSeA=;25:xs21jkfIfG8Y6fYBVpf/vz65vgV6xROX+4pzBnhiymDDTd51LQrbfdET54hyU+EU6k7SSxvb66vOAKSF4a1jAcCEYdcl3jDhMylJWYS/7PvIpKrkDsQpa3xJulH1yvjbA/iD2gv13Pzi5Kp69c2+iRib5cJXwa0OzQipIwLLImvbEOWZYaXnM9u5jR2GgJTBlWY6HLpkkO8XnsGlGywL+JN1E8I+V+2vTQBjzjR2BhJKznUWlhCl8LPrj9HV3BmBzYBRSzY8qPwqd2EJCIIOr/DpxAmh4dt7AsidQNQThxrcaUSRhds2RmJyTGQGVy2P23N+Lh5hsB2R6mO++j9jh1k6Xf82FIh67ZpUDxB/ulZbu3JwA8l4h2Q/kqDKmFxO3CEJFBMR32HtdDYy4kYfikgE1FbnFiTuPyluIi2QybUTyp8AbN4h0GM2Tj/EeikaaAWFmBylwMVMi7lwa91alQ== X-Microsoft-Exchange-Diagnostics: 1;CY4PR12MB1141;31:uC5l8dyqdONu3CfvRqGNPzICSpaJr4fT6BcGZIVQLEWX/lU0tqaNco2Ln+C152qhwO7dpFmtbpcr2S1LxQegB3oxf1q+F2z0jXdlxJlLM2yhDXNrglLbqT5/SNVeqJ+1UOBWwYSqrUDYYEY6JJOp57Ivj+KWkQAL2lTdFwLK4r9/SMuhhgh7bMFPrpOMxd1QKO4WqO2B9uG+eRGyvSjiG8F4iDIb5tpHvel0zuiPjU4LpJEmiowQe2U9e8TqI+PS;20:2jmKv15h3aWX+Q+nOfyfT9AyU6wjeoOxm79xnHmWZBcofHlJypVo4cqq55pfx3/BvrF2WB0KZtK9jM6QDo+PoEuQ2P/0mnJ4lI9OIwRLjVujCRY7TT7F7MoRFNAfBJxQkQtA4uTk9hOzBnkEfZMip5rtJyO0sjB1/8gb44uWNKZwN7g1sUNRc/pgy3wlsELfbU2dtAVg6XKPAAWIK3Ob9fQ0eZagSEhcZ2YlRgVeDjOpNdp5J0dLXO2O/VMNGSANDNQNCJnj8ddZjHkwDE2+X2E0Hor8emGUgVmTWWj87ko6o8b8kXYcpKI0aQbDnvXM3U+ptQeXTx5FketuYzSSlQwYzNORKQkiHjAELH/INSPhcbim+ci7pnxLujfttTl7qqfNnSTWW+qKxcQ7YyxCOEFGIOXPw/pakS7LfUzNY4ngG2mSYgFH3qcrPjmqVcoyaN3ngGjv/Y+GoV09QIKibtn5+tnfVmIZL8rxuDD25jwizSXJRVt+wQAEyEmb0aZW X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6055026)(6041248)(20161123555025)(20161123564025)(20161123562025)(20161123560025)(20161123558025)(6072148);SRVR:CY4PR12MB1141;BCL:0;PCL:0;RULEID:;SRVR:CY4PR12MB1141; X-Microsoft-Exchange-Diagnostics: 1;CY4PR12MB1141;4:pcdybjV3nV5xcBYSFSGAia4xZ6R3dN/Clui+XDAWNgn3nNHsdO+FsPinb8sb0cqPt4tYNwYGz/6F3uJ6YnQzEnUiOME1BjaY9bRNA6LsHNxLEEshFuU0gEuwqhrGaaIPe/I7Y57ybCcf3b65PFbKN2+nv87J37BHav/SgR3JWUWQQDrUkMu+bWaiGEcETemuUE/EklklGFSH6K93tUy+ZMKgOhGzgDYIxbQCFnbnXHs2dh+L/olLa4+/A/UZ3I3echYpQLqDrUezLMjRF0TnOR1iwBL0srd+GWFNIx8x6UkI5imWXiHtDm+Nvhi8t4893tcYa910Hb4+BYSh2Tx7yNlJAb9XUaSqrPcaAxU32uV/a6uOPl61qz/gbgyFoL9zim66TWKJkONqBejT+hbUZ4GqGkYfxuB11aNMCVo+to0NLWH4tLEQwYmW6Rqo7morTTlNLE8ns8zKcS7gQ5zENbgnyMBQbma0OF09cjoCCw2PTa6xqHs6SlLb7N5D2M6apbuTKI9Yf76KPbPQMLI6eKm9G3blCcHOJjhsakwvEWEOz3ABEQXIjND96pvnQe+1Dbg3+qkS10z6n/CH72eyz/0UvKKENL3J0iGQxdbCH+tMQwXuUtfm5aLH19PvA3Q5 X-Forefront-PRVS: 0225B0D5BC X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6049001)(6009001)(7916002)(39860400002)(39410400002)(39450400003)(39850400002)(39840400002)(24454002)(189002)(377454003)(199003)(90366009)(6486002)(77096006)(25786008)(68736007)(97736004)(6666003)(53546006)(83506001)(36756003)(53936002)(31696002)(92566002)(7736002)(7416002)(38730400002)(6246003)(110136004)(33646002)(5660300001)(6916009)(65826007)(86362001)(2950100002)(50466002)(23676002)(230700001)(6116002)(2906002)(8676002)(81166006)(106356001)(81156014)(3846002)(105586002)(4326007)(54906002)(64126003)(50986999)(4001350100001)(189998001)(42186005)(76176999)(54356999)(31686004)(101416001)(47776003)(305945005)(229853002)(65956001)(66066001)(65806001)(217873001);DIR:OUT;SFP:1101;SCL:1;SRVR:CY4PR12MB1141;H:[10.236.64.179];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTRQUjEyTUIxMTQxOzIzOkVaVHlvbTkvQWpFN29Ld1NUUWorOVpNSDQ4?= =?utf-8?B?cGFqTGlHQzA0emkxeWR5NldkTm9CcVZkL3BFNTJNYnYvK3FhVVpPVXRISkhi?= =?utf-8?B?QUlBZERzWnhUL0NIc0EybWFwclBVbkx2bHQ2dVlleWNwUUdNRjNYdm5mTklK?= =?utf-8?B?WmxNbi9HcGFsekJwYWJkdjNpdkdrNEQybWlmMkhWVFl0YkdRWFZwNVNyaktQ?= =?utf-8?B?UUsrQklzeGMxTFZPVk1xREViUU1Ma3FJYjVGMkg3NUFsV3M2VitzYzZROTJ2?= =?utf-8?B?ZktTcHpqRXQ5MFJSYzJKeURNcnM2STNiWGVCd0dLdVJxWmdlQ3FsaE4ybHgy?= =?utf-8?B?QlNBYW9mY1p5VnBra0ZJUk4zc2tIVkRwT3RqNXNKNVQ1L0FTV2QwdGxrSW9r?= =?utf-8?B?WndYb25Ka29kMnJ4WmxncDQrcm9lbmlGZkhoN3dUa1BCVklpK1JrYWhFWG5s?= =?utf-8?B?R21PaW5SWGhEUVRaaVJTdW9PNzJiOXBHTDhEdktPT0JKemRlMFlNSjJiV0hy?= =?utf-8?B?b29Ia0xkUXF2ZVRqSXZ1MnZVem5jOGpjeHJTL2xCajdtVENFT0hyaXBmM1Yy?= =?utf-8?B?QXhWVE14Nnhzc3VLa2haQ0NXQkVDTHdSNzhySzRRbkZtWFlqQ05YK2toQWZ3?= =?utf-8?B?YjFUOXZ0QjBRbEkyeHBmdGhPLzZFUzJIcXlPdzY2SDBjYjBRanN1RFJxSktt?= =?utf-8?B?a1VtWnpqa2FQRUozRVBTdGp6S2w0REx5cW5SL0ovMWVzaXA5UEtJOTVML2xH?= =?utf-8?B?bC9vZThoRGxHY2Q4TDdqQzhzajVEUGRBTmpHVnJVWS9ISi9uSUtMUmRXYk9G?= =?utf-8?B?eS9CZ25FeUMvb2RwY1BQbS9LSlhpQVBBZ2NjMmwxcGREVzROd3VUNzI1OWtu?= =?utf-8?B?OGhmdVVxN2JIcmJKZmxGYU1vWHgwSkdVcmpOT0pBbFFFakdMV1V1djNPdDZR?= =?utf-8?B?Zm41RzduSzhvTm9YSUV0WWkzOW12K0szVjZ5dFBHUm1tczBNRlE1cUQxQm8v?= =?utf-8?B?ZXIrTkJvOEthNVo1Y2RwTjRWK2tMYlFBTHc2V1I4QUtIZ2FENnNTRlYzWmZH?= =?utf-8?B?NWxTMGg1ZzQvQ2xqazdlZ3gvaUpZNllMSXlTdVhMamliajVJODFHVE53RlFj?= =?utf-8?B?RnM0NldHNWNFUS9wblQ4SEw4VW1IL1pXN2VtN1kvNW40dFRWdFMyb0k2cUpX?= =?utf-8?B?bkV0aFdzTFZLK05XdmFXYXhWcWdNWjFXM2hPU1hWVncyYmhhejlGSWREeWY5?= =?utf-8?B?SUJLN0dJWnJIdk5JR1lNaCtaMld6OGRUYUNpWVQvNXJTeGZVSGV3UTFwQ0I4?= =?utf-8?B?NklIMTlWS3l5bnlRSWdaR2tobGp0aHpYczN4MUkzaEQyQ2FUbnhZMnNycytM?= =?utf-8?B?bVZmTzZMSHU0aUZIRXl2NFpJUDhqL2R3cWhkYVJYeUphWmxnWVFhVUhOQVVp?= =?utf-8?B?VXdiZUN2Uy83clJDZndqbmJZVkxGK3lDUHh2YnJyNHlnZjN1Uk9UWHVoQkFF?= =?utf-8?B?MjVPVzFyMWRXa0dsK1Y0djJRaU1TYjd4S0xaODFyMTdvNjVEZy83TnZBckRG?= =?utf-8?B?aytCNi90TmQ2YWlRb2dMZEdybHFUUmhxcjNJZlRBTjFSd2VtZGFtUlB5Z0dX?= =?utf-8?B?U05zeC8rRzlTME9xc0dHZHhSNVB2eG5zdXZYa0NzenRrKyt5aDg0S2JhRGZQ?= =?utf-8?B?QlZIbHZUR3ZpbjhndmE1T3NIN21TZ0tidFQzSzlFbWt1V1hxTVNsWHRSRzNx?= =?utf-8?B?WlE2cjhaU2NPSndNWmJ5RlE2YTMycGNidFVGc2JOVHdJbFVCQk9sN2xKcnQx?= =?utf-8?B?NENWWk9sYlVhekVDWTRiRzJYWXd1dnJIWGk3SFlnaGhiZU9rUTR3ck8vRnA3?= =?utf-8?B?N3JubVNmRVUwRmRoRUtMdkVkQ2tReGhQL2lEb0hnNUlXUmVFb2ErRWRVRWYr?= =?utf-8?B?SmRFeEgvUHUxRU82NnJhQkNIQVVoQ0JiS1V1RWJhTHBJdTRUV0NxK2xyOGlU?= =?utf-8?B?MjVNQmpmUGJXRWNLVlNNSTdScDI5L0tHMThQcmg0b3ZGYTByYWZvTDlybDQw?= =?utf-8?B?SzdnVGZXaWhkQ0JsMXY4cDVJaWZHTHZzaHFEZnlwNUJEdGFqRXpHOFZaU1dq?= =?utf-8?Q?y14lOwPuYno5Qz1aCN8vlPs=3D?= X-Microsoft-Exchange-Diagnostics: 1;CY4PR12MB1141;6:zPrfaZApHj5EXEPomANWosR7ehHTu1fH9rcxlO3g/WdMBeThM03wza4Jdx0jUF5a4F7qaNRax0Epj1eUO74xWhz7FpjkGFf8IiXroyIu7Me98muSeNfCKS/SBFZdI8QOQzp9j1Q7kYMe+xHiyjBsGT8yzYeHcvaibkIMkzYLZsnM8PC3F5jf1X+tnCvjyNHHsQt0LKWLzsczNRBGEc46myMXKJo7STz8OipnYTePwbQ29ZfUaZYSmvSYdM7WkHZ4pvZlAdW2OtiqYyv5O6+AlITLstBnf0qLKpjCuNAhjfNIQ9h/T+VnpBYBNgQMN70238O4l2cvtWK0pdnK6eI9DehIaRDriREjiKJjAtRDFfr/o5sV6hEcogO9wp6FvD5hKOfBAkCuCp6l65logkPEOs2yc53gMAq6inrdFMw55Sg=;5:221p+KfUNpAHcEP3K4gG3Uqk31UijB+YkAVrP9oCHPEw4r0uxbg9O2TLeZM7lVFCLwYlYnFS/Yvqf5CZgfNwTgRF91rAszZLW8Jq+BQZ88RgZQWoIs366tPItELgByO7QZ3ahYvEPRifQU5HW4dOsw==;24:TypZHm8c9XotEdTO8P5+ZESGruQoi7O2EvNWvY2TfJ64C6BXodFWI8tRz85qAk92xbVQ87r+yEuLAz6RqlYCw+7rqTpxTudRAJVrZ4+QGyw= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CY4PR12MB1141;7:GP18xcmJfOcrIhBD/iz64m1RtTJWdpEcTqt9cZObWSV5NrzOixfz/HrJnvAbsxRHE1ejq3XMaAby46ZLsPN7BSoBomNqhRlb13AeaFsoAVngBWqE/1vYu9vHcIXGT4afImPGFzcq9mu8phdSHyGDHDqPxW6ACyGMbArwb3dLo9M0V4hcbNKpwCvWEJcI8in+iztIeqR2NyH34ulUeFgArcYcCUeBnJ9QKiFcjWzswyXYHMShwsVAd5b2SZidTgdPSDUtgtj4O+g9LoF4We5CpSiUWvX71lB2LPdtol68VPnShUhLPUw+VOMv65p0bwgZif2099N+BuNmvnsdwohIzA==;20:YsFkpwBxa+I+c0HqLOD7ERZAWmCwLrLE+28+tVKHji/pRTn4h2nFuPq5KQGGn+suHdaeXpOAgfNC10WLFcB3anSoCW9jLoxoOoQbU2jIYPCw+JnvBG2Av6xrelXERfa77ctP+JROsy7w7kULfsRRwA5aLjlXLgdGbQeV4JtfUGXawWu6eH13Rq9K9C9KTyQgxRH7ahb0grWlQp7GJe2zJUOSlvDMUyhENftEoWiKqtgt/0ZBLJjUvr+piTGJStCX X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2017 15:09:30.3503 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR12MB1141 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/18/2017 12:12 PM, Borislav Petkov wrote: > On Thu, Feb 16, 2017 at 09:41:59AM -0600, Tom Lendacky wrote: >> create mode 100644 Documentation/x86/amd-memory-encryption.txt >> create mode 100644 arch/x86/include/asm/mem_encrypt.h >> create mode 100644 arch/x86/kernel/mem_encrypt_boot.S >> create mode 100644 arch/x86/kernel/mem_encrypt_init.c >> create mode 100644 arch/x86/mm/mem_encrypt.c > > I don't see anything standing in the way of merging those last two and > having a single: > > arch/x86/kernel/mem_encrypt.c > > with all functionality in there with ifdeffery around it so > that sme_encrypt_kernel() et all are still visible in the > !CONFIG_AMD_MEM_ENCRYPT case. Sounds good. I'll combine those two files. Thanks, Tom >