From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f174.google.com (mail-lj1-f174.google.com [209.85.208.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9B28F3A5E6C for ; Wed, 3 Jun 2026 20:42:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780519336; cv=none; b=MsjyTfSsGs76RBAFALZBNepBF2Q62ZoBZ2MQBYFpJG2QdIiTqojnBa8T/KztskGFAHbZLL6wrjuU8fO+cnHeqcwpxAEGCVr1ACLJBMV5/MoZA7fAC6WRtL4T/MjTZ9K0qTQjP+obsZXmmzLndd56WiypkIQd1fNzlYBmvKceAU8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780519336; c=relaxed/simple; bh=NL5LlForqYlh+fcRsfduuGF8C586rzxAZDzcova+u04=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=mblH72tdEcpnjM3dieBxm/qINdewJKZhZOvdJL7WhLKkZQkTVcMvVhsul51+75AT8SsCB9EYa/AZEGpIFGRhkzabBPEMCai896CQo3QyiubLhR+M7hUIWK64PqL6Bz9FfxhY1oPgGEijhkT2aqOi4YRyI+bilGhpeqafig36lrY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=jo+wIgNB; arc=none smtp.client-ip=209.85.208.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="jo+wIgNB" Received: by mail-lj1-f174.google.com with SMTP id 38308e7fff4ca-39677519c05so5653151fa.3 for ; Wed, 03 Jun 2026 13:42:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1780519334; x=1781124134; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=ZKtbINASkuxxe/pYPg2E1h0L+MT79XjrtpjoA45kS4I=; b=jo+wIgNBbxyAecLYjcLmeKFAHMwp7tZugXinVwPPjFXlJ8ADVk/TA9UClregWIkD+F UFYuwert/plUxkp52MeC9UUvfOa1fzGvU95BNmqGSOTIa3j7WOlnliShjREdRmo3wlK6 vIv7xqRrrFKp6ejK1HrqAVgEO8w4n0VE4X2Zmv0QaGj0FsvzHZkOmJv/ZPqOmzlTGcBY rb6CobN6fo63BYNNFzW244wTqdPZ/L3B0Vu1bhPLA5B4hNvcu52/05UXOn0O6rmAP/dQ QmJGg0Oe7f231yhvG29hdx2lPd1nROJSeb6uRnpW9NBnytK0o9SxtxpDm513mHCADfJE KAiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780519334; x=1781124134; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=ZKtbINASkuxxe/pYPg2E1h0L+MT79XjrtpjoA45kS4I=; b=mRGba6KFm3vME+BH4IoFjPkpJMxY/dJkkeOJbMRt4lI9TEKgLMBa3mzNlDF0hbzS8o Ow9Sem8h2HgtB3U462IlP7c2LKfm8161RqAnDcf10EXxn4om+0xPou/bHdzoYIv5iEGA EIxhq0riTKja4wkQCH/CjPye3wnKDixvyewOcxmWl+hNKe4a+slqnRzi/EocvK7DLwoC e5/jaYVDovFXaME2uRBWsgtRbPXHr/rFZKLbn8YNbtTRFn7VO4oUxbfL9+h1gxMFXIrw 5aZcrivia51fcxfIuFsvy6fbZ+V3D2AUMY2DcgbsAkFovHVy0cJL6WAlUrEZSzh9iR04 NKoQ== X-Forwarded-Encrypted: i=1; AFNElJ8RN6bSrREdqFFOLRC9dK74sozfKx1s6cDaIzacHigYXwAM4VU9Va+EmUAHMhpIqzizaQhNKCcbYAPelmc=@vger.kernel.org X-Gm-Message-State: AOJu0Yz0cHPVVuvm+SFKgQpp8BgiJmAaLcL6N63PFb7tHtAKy6HSGp/e DaEw65ejzqJ6RKFxk8gFiqSsT20TW5TgLWuKrteA+CXFZmxpsd84hqsxOaig2lJ8gRg= X-Gm-Gg: Acq92OGHPKfFjDQBmyNjKDi/dU3/a4Ruv6Fj23+uoL5uiLAjyKz/+D1eqjaoEwbLEmP tE3gBXWn0mVPenadYUiap/6xUgJ3V0R0Bu6IzzokeRGmAMp8+iebkZdpRD74HpIy5cb2yKpuImM pcxHDVTqBxpEgKcGtTzYIIXmIzsGLLsHEAI6GZVpa3SPTFTPDxEROMOLmttNKxd+QXLwaqCIPMx LlhLKfz++i7n/STWkxxPpTSJClGB2gOOXD7bwTOiE8D5gjR4NmU38mhoVhVLq/OAfwKEAcZXJqt YsopnN25gvIpmAs8bXZ0YD7bLNIQyFxOqBJkF3mRdDMCzJnPnVa7ga1lSDquicN4+8RtiZxUc25 QtKQhCIFtnrRSCecqWCGaF8eAPTYuHtDztDsHy7Z6XZjC6sMeKT36YCj2wBW9V7BJG7Zf5BXHnT wva/xRkR/ww/+Fs0KusG9md2V1uFWlyNLUmCUXwSKqMJvjNvgpOo5eQPIyaK7fdNARy81djrVLS HPCWSF3BICX+nvU X-Received: by 2002:a05:6512:6c4:b0:5a8:6f01:e1a0 with SMTP id 2adb3069b0e04-5aa81edc1c6mr4375e87.3.1780519333830; Wed, 03 Jun 2026 13:42:13 -0700 (PDT) Received: from [192.168.1.100] (91-159-24-186.elisa-laajakaista.fi. [91.159.24.186]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5aa7b907269sm837408e87.34.2026.06.03.13.42.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 03 Jun 2026 13:42:13 -0700 (PDT) Message-ID: <6e962010-8097-4b52-9369-0727c0d5a31a@linaro.org> Date: Wed, 3 Jun 2026 23:42:12 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 2/2] phy: qcom-mipi-csi2: Add a CSI2 MIPI DPHY driver To: Bryan O'Donoghue , Dmitry Baryshkov Cc: Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Neil Armstrong , Bryan O'Donoghue , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260523-x1e-csi2-phy-v8-0-a85668459521@linaro.org> <20260523-x1e-csi2-phy-v8-2-a85668459521@linaro.org> <54904b61-222d-4600-ad4c-c03a9952d337@linaro.org> <8eb709ce-3469-4303-9c3d-8d1a221cb8de@linaro.org> From: Vladimir Zapolskiy In-Reply-To: <8eb709ce-3469-4303-9c3d-8d1a221cb8de@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 6/3/26 15:57, Bryan O'Donoghue wrote: > On 03/06/2026 13:40, Dmitry Baryshkov wrote: >>> Are you sure about that ? >> Yes. >> >>> ipcat I thought designated lane 7 specifically as clk-lane i.e. named it >>> CLK_LN of some description. >> Split configurations explicitly use other lanes for clocks. E.g. check >> the RB5 Navigation schematics, CAM0B connector. > > Can you please check: > > CSI_3PHASE_COMMON.CSI_COMMON_CTRL5 > > 0 LN0_PWRDN_B Lane 0 > ... > 7 LNCK_PWRDN_B Clock Lane Please note that media devices have a numeration scheme of lanes starting from 1 (it'd be easy to check/confirm it), for instance today CAMSS has lane numeration starting from 0 is out of the accepted scheme, and here it'd be better to correct it and not enter the same pit. I don't have access to the IP spec, anyway I do not grasp it, where are 8 lanes on the CSIPHY found? Each CSIPHY IP has 4+1 D-PHY lanes, not 8. > > ... just a badly name field > > CSI_2PHASE_CTRL10 > > Bit[2] = IS_CLKLANE > > Right so CSI_2PHASE_CTRL10 controls lane mode, indeed. Thanks for checking. > -- Best wishes, Vladimir