From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82EB4C64E7D for ; Sat, 28 Nov 2020 22:02:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5E78F2344C for ; Sat, 28 Nov 2020 22:02:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390393AbgK1VvD (ORCPT ); Sat, 28 Nov 2020 16:51:03 -0500 Received: from smtprelay0175.hostedemail.com ([216.40.44.175]:36666 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729662AbgK1S2m (ORCPT ); Sat, 28 Nov 2020 13:28:42 -0500 Received: from smtprelay.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by smtpgrave01.hostedemail.com (Postfix) with ESMTP id D848918020B0F for ; Sat, 28 Nov 2020 16:00:10 +0000 (UTC) Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay07.hostedemail.com (Postfix) with ESMTP id D2046181D3028; Sat, 28 Nov 2020 16:00:07 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: rub33_0c07f4a27391 X-Filterd-Recvd-Size: 3363 Received: from XPS-9350.home (unknown [47.151.128.180]) (Authenticated sender: joe@perches.com) by omf06.hostedemail.com (Postfix) with ESMTPA; Sat, 28 Nov 2020 16:00:06 +0000 (UTC) Message-ID: <6e9917257cfd6774066446014051d39b784ba497.camel@perches.com> Subject: Re: [PATCH] MAINTAINERS add D: tag for subsystem commit prefix From: Joe Perches To: Tom Rix , apw@canonical.com, nickhu@andestech.com, green.hu@gmail.com, deanbo422@gmail.com Cc: linux-kernel@vger.kernel.org Date: Sat, 28 Nov 2020 08:00:04 -0800 In-Reply-To: References: <20201127214316.3045640-1-trix@redhat.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.38.1-1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2020-11-28 at 07:36 -0800, Tom Rix wrote: > On 11/27/20 2:10 PM, Joe Perches wrote: [] > > I think an exception mechanism would be better than a specific > > mechanism added to various entries. > Can you give an example of what you mean ? Inherit the parent prefix then add the basename(dirname) as a default. For instance, changes to any subsystem of drivers/staging starts as "staging: " and with "$basename(path): " appended. So the MAINTAINERS entry for staging could be: STAGING SUBSYSTEM M: Greg Kroah-Hartman L: devel@driverdev.osuosl.org S: Supported T: git git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git D: "staging: " F: drivers/staging/ Any specified D: use would override the generic form. And generic ARM changes could use the same mechanism with: ARM PORT M: Russell King L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers) S: Odd Fixes W: http://www.armlinux.org.uk/ T: git git://git.armlinux.org.uk/~rmk/linux-arm.git D: "ARM: " F: arch/arm/ X: arch/arm/boot/dts/ And media likewise: MEDIA INPUT INFRASTRUCTURE (V4L/DVB) M: Mauro Carvalho Chehab L: linux-media@vger.kernel.org S: Maintained W: https://linuxtv.org Q: http://patchwork.kernel.org/project/linux-media/list/ T: git git://linuxtv.org/media_tree.git D: "media: " F: Documentation/admin-guide/media/ F: Documentation/devicetree/bindings/media/ F: Documentation/driver-api/media/ F: Documentation/userspace-api/media/ F: drivers/media/ F: drivers/staging/media/ F: include/linux/platform_data/media/ F: include/media/ F: include/uapi/linux/dvb/ F: include/uapi/linux/ivtv* F: include/uapi/linux/media.h F: include/uapi/linux/meye.h F: include/uapi/linux/uvcvideo.h F: include/uapi/linux/v4l2-* F: include/uapi/linux/videodev2.h etc... > > >  # check MAINTAINERS entries for the right ordering too > > > - my $preferred_order = 'MRLSWQBCPTFXNK'; > > > + my $preferred_order = 'MRLSWQBCPTFXNKD'; > > >   if ($rawline =~ /^\+[A-Z]:/ && > > >   $prevrawline =~ /^[\+ ][A-Z]:/) { > > >   $rawline =~ /^\+([A-Z]):\s*(.*)/; > > I'd prefer to keep the file and keyword list last. > > > So change to > > my $preferred_order = 'MRLSWQBCPTDFXNK'; > > ? Right. And update the preferred_order in scripts/parse-maintainers.pl too.