From: Markus Elfring <Markus.Elfring@web.de>
To: linux-cifs@vger.kernel.org, samba-technical@lists.samba.org,
Bharath SM <bharathsm@microsoft.com>,
Paulo Alcantara <pc@manguebit.org>,
Ronnie Sahlberg <ronniesahlberg@gmail.com>,
Shyam Prasad N <sprasad@microsoft.com>,
Steve French <sfrench@samba.org>, Tom Talpey <tom@talpey.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Alexander Viro <viro@zeniv.linux.org.uk>,
David Howells <dhowells@redhat.com>
Subject: [PATCH] smb: client: Simplify conditional compilation in __cifs_do_create()
Date: Fri, 12 Jun 2026 19:39:01 +0200 [thread overview]
Message-ID: <6e9c0200-9539-49e2-b667-eeb2b4906d45@web.de> (raw)
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Fri, 12 Jun 2026 19:24:14 +0200
Move an opening curly bracket behind the preprocessor directive “#endif”
so that an “#else” branch can be omitted.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
fs/smb/client/dir.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/fs/smb/client/dir.c b/fs/smb/client/dir.c
index 88a4a1787ff0..1e747e8c51e5 100644
--- a/fs/smb/client/dir.c
+++ b/fs/smb/client/dir.c
@@ -432,10 +432,9 @@ static int __cifs_do_create(struct inode *dir, struct dentry *direntry,
if (tcon->unix_ext)
rc = cifs_get_inode_info_unix(&newinode, full_path, dir->i_sb,
xid);
- else {
-#else
- {
+ else
#endif /* CONFIG_CIFS_ALLOW_INSECURE_LEGACY */
+ {
/* TODO: Add support for calling POSIX query info here, but passing in fid */
rc = cifs_get_inode_info(&newinode, full_path, buf, dir->i_sb, xid, fid);
if (newinode) {
--
2.54.0
reply other threads:[~2026-06-12 17:39 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e9c0200-9539-49e2-b667-eeb2b4906d45@web.de \
--to=markus.elfring@web.de \
--cc=bharathsm@microsoft.com \
--cc=dhowells@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pc@manguebit.org \
--cc=ronniesahlberg@gmail.com \
--cc=samba-technical@lists.samba.org \
--cc=sfrench@samba.org \
--cc=sprasad@microsoft.com \
--cc=tom@talpey.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®