From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3AEBCECAAD3 for ; Wed, 14 Sep 2022 19:44:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229678AbiINToe (ORCPT ); Wed, 14 Sep 2022 15:44:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55440 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229539AbiINToa (ORCPT ); Wed, 14 Sep 2022 15:44:30 -0400 Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 28312B3E for ; Wed, 14 Sep 2022 12:44:28 -0700 (PDT) Received: by mail-wr1-x42d.google.com with SMTP id t14so27342636wrx.8 for ; Wed, 14 Sep 2022 12:44:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=YTsYGZzhaRMoDOgNfzuhnR52+qccmbYkM+d60yg4Y1o=; b=rc+mHPUzZAS2vaOMbc+ho7YHBG6KDEr4WTDkzwNDL0gxKp6i5o6efQIKDl8MVjCkyp SDdCy7XR0H1SXxE22Txl/z622N2tIr7mI4YdTIwEYE9Z1d3CoVS3404Dj1AGaLK4rTHy fPXLz/c5SN7bK6yuNa42AWpsuABfsCuMl+aGIsABOLYcy9IVXfGmh9ztlUefWnX81bpG xChKHRapSNO/RFnek90S91Lh6nm4jKMBAk812ZPbc8GM60idFsqF63UnRtL4adtHlBjt lhKD8sJso61h70U78ySAd/CBrFkIE4KoSTVDd944h70BZbIdFr5BmqrYyEDrCxdWBKtG SsZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=YTsYGZzhaRMoDOgNfzuhnR52+qccmbYkM+d60yg4Y1o=; b=neZMarn3PzKwHXfCTghAGdt+PumW/1P97hBOanZfHWjwDNTv5NtFUul+gd3ZqpTNE5 H9biyr6rq9d4zpudge86MiWujw1xEeu6llLD7UA49EWAstqTXr34W8jxfJDSsRubLU3+ g7IQp1XvIXit+3TQ4eBB7JxrnwLmM5taAqc1sFtSA0MKettPbZyeBp7YTCjNrsjs+pCb PxPUenKr1tzBubOKOwp2LE+aSlPDmyN5+r8UxpL/eq3ySrdZyT2YsVEuT/Caz0KgrMfs y40RUcxMiHK03/6Y/8D6qc+troluPFI8LR9zpO66PopZZuWjsSin4s5nZ8Ci5QC4oa9T lFHw== X-Gm-Message-State: ACgBeo2qGsJyqChHlDAxo1wUBwH92y3DHILivSaYL0I4BQsRfn72dD/b a/i9s8Vc5CjHtJgFWj+uG+C73A== X-Google-Smtp-Source: AA6agR7EL+x8pNTKbWUf5+XEsJ9MrMWoqCeAkvA4m6JWQ59HbDf/+G5IzKtN54Lh5GYaFanSNTBEGA== X-Received: by 2002:a05:6000:1866:b0:228:e373:ad68 with SMTP id d6-20020a056000186600b00228e373ad68mr21165175wri.605.1663184666639; Wed, 14 Sep 2022 12:44:26 -0700 (PDT) Received: from [192.168.0.20] (210.145.15.109.rev.sfr.net. [109.15.145.210]) by smtp.gmail.com with ESMTPSA id bi6-20020a05600c3d8600b003b339438733sm53756wmb.19.2022.09.14.12.44.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Sep 2022 12:44:25 -0700 (PDT) Message-ID: <6e9c94e7-3f0b-83bd-b419-db6c002f7d98@baylibre.com> Date: Wed, 14 Sep 2022 21:44:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH] arm64: dts: mediatek: mt8183: remove thermal zones without trips. Content-Language: en-US To: Matthias Brugger , Rob Herring Cc: Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org References: <20220914131339.18348-1-aouledameur@baylibre.com> From: Amjad Ouled-Ameur In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Matthias, Thank you for your review. On 9/14/22 16:15, Matthias Brugger wrote: > > > On 14/09/2022 15:13, Amjad Ouled-Ameur wrote: >> Thermal zones without trip point are not registered by thermal core. >> >> tzts1 ~ tzts6 zones of mt8183 were intially introduced for test-purpose >> only but are not supposed to remain on DT. >> >> Remove the zones above and keep only cpu_thermal. >> > > My understanding is that this thermal zones exist but are not used. > DTS should describe the HW as it is, so I propose to add > status = "disabled"; > to the zones. > Correct, they are unused unless for testing purposes. Thus, your suggestion of disabling them seems more relevant than removal. Regards, Amjad > Regards, > Matthias > >> Signed-off-by: Amjad Ouled-Ameur >> --- >>   arch/arm64/boot/dts/mediatek/mt8183.dtsi | 57 ------------------------ >>   1 file changed, 57 deletions(-) >> >> diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi >> b/arch/arm64/boot/dts/mediatek/mt8183.dtsi >> index 9d32871973a2..f65fae8939de 100644 >> --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi >> +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi >> @@ -1182,63 +1182,6 @@ THERMAL_NO_LIMIT >>                       }; >>                   }; >>               }; >> - >> -            /* The tzts1 ~ tzts6 don't need to polling */ >> -            /* The tzts1 ~ tzts6 don't need to thermal throttle */ >> - >> -            tzts1: tzts1 { >> -                polling-delay-passive = <0>; >> -                polling-delay = <0>; >> -                thermal-sensors = <&thermal 1>; >> -                sustainable-power = <5000>; >> -                trips {}; >> -                cooling-maps {}; >> -            }; >> - >> -            tzts2: tzts2 { >> -                polling-delay-passive = <0>; >> -                polling-delay = <0>; >> -                thermal-sensors = <&thermal 2>; >> -                sustainable-power = <5000>; >> -                trips {}; >> -                cooling-maps {}; >> -            }; >> - >> -            tzts3: tzts3 { >> -                polling-delay-passive = <0>; >> -                polling-delay = <0>; >> -                thermal-sensors = <&thermal 3>; >> -                sustainable-power = <5000>; >> -                trips {}; >> -                cooling-maps {}; >> -            }; >> - >> -            tzts4: tzts4 { >> -                polling-delay-passive = <0>; >> -                polling-delay = <0>; >> -                thermal-sensors = <&thermal 4>; >> -                sustainable-power = <5000>; >> -                trips {}; >> -                cooling-maps {}; >> -            }; >> - >> -            tzts5: tzts5 { >> -                polling-delay-passive = <0>; >> -                polling-delay = <0>; >> -                thermal-sensors = <&thermal 5>; >> -                sustainable-power = <5000>; >> -                trips {}; >> -                cooling-maps {}; >> -            }; >> - >> -            tztsABB: tztsABB { >> -                polling-delay-passive = <0>; >> -                polling-delay = <0>; >> -                thermal-sensors = <&thermal 6>; >> -                sustainable-power = <5000>; >> -                trips {}; >> -                cooling-maps {}; >> -            }; >>           }; >>             pwm0: pwm@1100e000 {