From: Helge Deller <deller@gmx.de>
To: Myeonghun Pak <mhun512@gmail.com>, Antonino Daplas <adaplas@gmail.com>
Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fbdev: nvidia: Release write-combining handle on probe failure
Date: Tue, 15 Sep 2026 09:04:58 +0200 [thread overview]
Message-ID: <6e9c98f9-56b8-4e8f-9707-a567656741d8@gmx.de> (raw)
In-Reply-To: <20260915005447.51995-1-mhun512@gmail.com>
On 9/15/26 02:54, Myeonghun Pak wrote:
> Failures in nvidia_set_fbinfo() or register_framebuffer() leave the handle
> from arch_phys_wc_add() allocated. Release it in the shared error path,
> as nvidiafb_remove() already does on normal removal.
>
> The missing cleanup was already present in the initial Git import,
> when the driver used mtrr_add() directly.
>
> This issue was identified during our ongoing static-analysis research
> while reviewing kernel code.
>
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Cc: stable@vger.kernel.org
> Assisted-by: LLM
> Co-developed-by: Ijae Kim <ae878000@gmail.com>
> Signed-off-by: Ijae Kim <ae878000@gmail.com>
> Signed-off-by: Myeonghun Pak <mhun512@gmail.com>
> ---
> drivers/video/fbdev/nvidia/nvidia.c | 1 +
> 1 file changed, 1 insertion(+)
Thanks for your patches!
I've added this one and the two similar ones regarding kyro and gxt4500
to the fbdev git tree.
Helge
prev parent reply other threads:[~2026-09-15 7:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-15 0:54 Myeonghun Pak
2026-09-15 7:04 ` Helge Deller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e9c98f9-56b8-4e8f-9707-a567656741d8@gmx.de \
--to=deller@gmx.de \
--cc=adaplas@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhun512@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®