From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18694C433ED for ; Sat, 8 May 2021 15:57:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DDE1560FE9 for ; Sat, 8 May 2021 15:57:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229645AbhEHP6y (ORCPT ); Sat, 8 May 2021 11:58:54 -0400 Received: from smtprelay0118.hostedemail.com ([216.40.44.118]:56922 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S229500AbhEHP6v (ORCPT ); Sat, 8 May 2021 11:58:51 -0400 Received: from omf05.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay01.hostedemail.com (Postfix) with ESMTP id 120E2100E7B45; Sat, 8 May 2021 15:57:49 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: joe@perches.com) by omf05.hostedemail.com (Postfix) with ESMTPA id 91409B2793; Sat, 8 May 2021 15:57:47 +0000 (UTC) Message-ID: <6ea0773df765ec4d261e5e3434060622ce48d8f1.camel@perches.com> Subject: Re: [RFC PATCH net-next v4 01/28] net: mdio: ipq8064: clean whitespaces in define From: Joe Perches To: Ansuel Smith , Florian Fainelli Cc: Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Jakub Kicinski , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Date: Sat, 08 May 2021 08:57:46 -0700 In-Reply-To: <20210508002920.19945-1-ansuelsmth@gmail.com> References: <20210508002920.19945-1-ansuelsmth@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.38.1-1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspamout03 X-Rspamd-Queue-Id: 91409B2793 X-Stat-Signature: 1h3gjuode6wyq67r57fp99bcyqmajug7 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Session-ID: U2FsdGVkX19KSTGJVGvmPqzwYwCMA96QBCKLxc9d+d0= X-HE-Tag: 1620489467-53897 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2021-05-08 at 02:28 +0200, Ansuel Smith wrote: > Fix mixed whitespace and tab for define spacing. Incomplete commit message here. > diff --git a/drivers/net/mdio/mdio-ipq8064.c b/drivers/net/mdio/mdio-ipq8064.c [] > -#define MII_CLKRANGE_60_100M (0 << 2) > -#define MII_CLKRANGE_100_150M (1 << 2) > -#define MII_CLKRANGE_20_35M (2 << 2) > -#define MII_CLKRANGE_35_60M (3 << 2) > -#define MII_CLKRANGE_150_250M (4 << 2) > -#define MII_CLKRANGE_250_300M (5 << 2) [] > +#define MII_CLKRANGE(x) ((x) << 2) > +#define MII_CLKRANGE_60_100M MII_CLKRANGE(0) > +#define MII_CLKRANGE_100_150M MII_CLKRANGE(1) > +#define MII_CLKRANGE_20_35M MII_CLKRANGE(2) > +#define MII_CLKRANGE_35_60M MII_CLKRANGE(3) > +#define MII_CLKRANGE_150_250M MII_CLKRANGE(4) > +#define MII_CLKRANGE_250_300M MII_CLKRANGE(5) Adding a define and using it isn't just whitespace.