From: Guenter Roeck <linux@roeck-us.net>
To: Lakshmi Yadlapati <lakshmiy@us.ibm.com>
Cc: jdelvare@suse.com, ninad@linux.ibm.com, eajames@linux.ibm.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] hwmon: (ucd90320) Increase delay from 250 to 500us
Date: Thu, 9 May 2024 09:32:59 -0700 [thread overview]
Message-ID: <6ea76e83-f623-4bf8-9594-dc882cda6c81@roeck-us.net> (raw)
In-Reply-To: <20240507194603.1305750-1-lakshmiy@us.ibm.com>
On Tue, May 07, 2024 at 02:46:03PM -0500, Lakshmi Yadlapati wrote:
> Following the failure observed with a delay of 250us, experiments were
> conducted with various delays. It was found that a delay of 350us
> effectively mitigated the issue.
>
> To provide a more optimal solution while still allowing a margin for
> stability, the delay is being adjusted to 500us.
>
> Signed-off-by: Lakshmi Yadlapati <lakshmiy@us.ibm.com>
Why did you not send this patch to the hardware monitoring mailing list ?
Such an omission all but guarantees that it gets lost, so you should not
be surprised if that happens with your patches if you do that on a regular
basis.
I am going to apply your patch (fortunately I still had it in my inbox),
but please keep that in mind for the future if you want your patches
applied.
Thanks,
Guenter
> ---
> drivers/hwmon/pmbus/ucd9000.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/hwmon/pmbus/ucd9000.c b/drivers/hwmon/pmbus/ucd9000.c
> index 8d9d422450e5..d817c719b90b 100644
> --- a/drivers/hwmon/pmbus/ucd9000.c
> +++ b/drivers/hwmon/pmbus/ucd9000.c
> @@ -80,11 +80,11 @@ struct ucd9000_debugfs_entry {
> * It has been observed that the UCD90320 randomly fails register access when
> * doing another access right on the back of a register write. To mitigate this
> * make sure that there is a minimum delay between a write access and the
> - * following access. The 250us is based on experimental data. At a delay of
> - * 200us the issue seems to go away. Add a bit of extra margin to allow for
> + * following access. The 500 is based on experimental data. At a delay of
> + * 350us the issue seems to go away. Add a bit of extra margin to allow for
> * system to system differences.
> */
> -#define UCD90320_WAIT_DELAY_US 250
> +#define UCD90320_WAIT_DELAY_US 500
>
> static inline void ucd90320_wait(const struct ucd9000_data *data)
> {
> --
> 2.40.1
>
prev parent reply other threads:[~2024-05-09 16:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-07 19:46 Lakshmi Yadlapati
2024-05-08 15:16 ` Eddie James
2024-05-09 16:32 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ea76e83-f623-4bf8-9594-dc882cda6c81@roeck-us.net \
--to=linux@roeck-us.net \
--cc=eajames@linux.ibm.com \
--cc=jdelvare@suse.com \
--cc=lakshmiy@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ninad@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®