mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Mark Pearson" <mpearson-lenovo@squebb.ca>
To: "Rong Zhang" <i@rong.moe>,
	"Derek J . Clark" <derekjohn.clark@gmail.com>,
	"Hans de Goede" <hansg@kernel.org>,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
	"Alok Tiwari" <alok.a.tiwari@oracle.com>,
	"Armin Wolf" <W_Armin@gmx.de>
Cc: "platform-driver-x86@vger.kernel.org"
	<platform-driver-x86@vger.kernel.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/5] platform/x86: lenovo-wmi-other: Eliminate attribute-specific callbacks
Date: Wed, 18 Nov 2026 17:17:37 -0500	[thread overview]
Message-ID: <6eaa6dc3-3997-423d-997d-e673872c3e86@app.fastmail.com> (raw)
In-Reply-To: <20261119-lwmi-no-singleton-v1-2-6b06fcfb5126@rong.moe>



On Wed, Nov 18, 2026, at 1:58 PM, Rong Zhang wrote:
> Currently, all firmware-attributes are backed by numerous
> attribute-specific wrapper callbacks generated by macros. Besides,
> every firmware attribute has the same type "integer" and shares the same
> show callback int_type_show(), but LWMI_ATTR_GROUP_TUNABLE_CAP01()
> defines attr_*_type over and over again.
>
> As a result, the definition of attributes significantly bloats up the
> module size.
>
> Eliminating these attribute-specific callbacks by moving their data into
> a newly-introduced container struct capdata01_attr, and utilize
> container_of_const() to retrieve the required data in the corresponding
> callbacks, which are adjusted to make them generic and shared among
> different attributes. Also introduce a unified attr_int_type attribute
> to replace all attr_*_type attributes.
>
> With these, all firmware-attributes now use generic callbacks directly
> and are constified.
>
> This shrinks the module size by 23.8K (42.7%).
>
>       text       data        bss      total filename (before)
>      23463      32197          3      55663 lenovo-wmi-other.ko
>
>       text       data        bss      total filename (after)
>       5816      26059          3      31878 lenovo-wmi-other.ko
>
> Signed-off-by: Rong Zhang <i@rong.moe>
> ---
>  drivers/platform/x86/lenovo/wmi-other.c | 217 ++++++++++++++++----------------
>  1 file changed, 108 insertions(+), 109 deletions(-)
>
> diff --git a/drivers/platform/x86/lenovo/wmi-other.c 
> b/drivers/platform/x86/lenovo/wmi-other.c
> index c31a8bd08a85..4d51b05a5acf 100644
> --- a/drivers/platform/x86/lenovo/wmi-other.c
> +++ b/drivers/platform/x86/lenovo/wmi-other.c
> @@ -981,7 +981,7 @@ struct tunable_attr_01 {
>   *
>   * Return: encoded capability data attribute ID.
>   */
> -static u32 tunable_attr_01_id(struct tunable_attr_01 *attr, u8 mode)
> +static u32 tunable_attr_01_id(const struct tunable_attr_01 *attr, u8 
> mode)
>  {
>  	return lwmi_attr_id(attr->device_id, attr->feature_id, mode, 
> attr->type_id);
>  }
> @@ -1118,6 +1118,15 @@ static struct tunable_attr_01 gpu_nv_cpu_boost = 
> {
>  	.type_id = LWMI_TYPE_ID_NONE,
>  };
> 
> +struct capdata01_attr {
> +	struct kobj_attribute kobj_attr;
> +	struct tunable_attr_01 *tunable_attr;
> +	union {
> +		enum attribute_property prop;
> +		const char *display_name;
> +	};
> +};
> +
>  struct capdata01_attr_group {
>  	const struct attribute_group *attr_group;
>  	struct tunable_attr_01 *tunable_attr;
> @@ -1128,6 +1137,12 @@ static inline struct lwmi_om_priv 
> *kobj_to_om_priv(const struct kobject *kobj)
>  	return dev_get_drvdata(kobj_to_dev(kobj->parent));
>  }
> 
> +static inline const struct capdata01_attr *
> +kobj_attr_to_cd01_attr(const struct kobj_attribute *kattr)
> +{
> +	return container_of_const(kattr, struct capdata01_attr, kobj_attr);
> +}
> +
>  /* Attribute Methods */
> 
>  /**
> @@ -1138,36 +1153,54 @@ static inline struct lwmi_om_priv 
> *kobj_to_om_priv(const struct kobject *kobj)
>   *
>   * Return: Number of characters written to buf.
>   */
> -static ssize_t int_type_show(struct kobject *kobj, struct 
> kobj_attribute *kattr,
> +static ssize_t int_type_show(struct kobject *kobj, const struct 
> kobj_attribute *kattr,
>  			     char *buf)
>  {
>  	return sysfs_emit(buf, "integer\n");
>  }
> 
> +static const struct kobj_attribute attr_int_type = __KOBJ_ATTR(type, 
> 0444, int_type_show, NULL);
> +
> +/**
> + * attr_display_name_show() - Get the display name of the given 
> attribute
> + * @kobj: Pointer to the driver object.
> + * @kattr: Pointer to the attribute calling this function.
> + * @buf: The buffer to write to.
> + *
> + * Retrieves the display name from the capdata01_attr struct for the 
> specified
> + * attribute. This function is intended to be generic so it can be 
> called from
> + * any integer attributes.
> + *
> + * Return: Number of characters written to buf.
> + */
> +static ssize_t attr_display_name_show(struct kobject *kobj,
> +				      const struct kobj_attribute *kattr, char *buf)
> +{
> +	const struct capdata01_attr *cd01_attr = 
> kobj_attr_to_cd01_attr(kattr);
> +
> +	return sysfs_emit(buf, "%s\n", cd01_attr->display_name);
> +}
> +
>  /**
>   * attr_capdata01_show() - Get the value of the specified attribute 
> property
>   *
>   * @kobj: Pointer to the driver object.
>   * @kattr: Pointer to the attribute calling this function.
>   * @buf: The buffer to write to.
> - * @tunable_attr: The attribute to be read.
> - * @prop: The property of this attribute to be read.
>   *
>   * Retrieves the given property from the capability data 01 struct for 
> the
>   * specified attribute's "custom" thermal mode. This function is 
> intended
> - * to be generic so it can be called from any integer attributes 
> "_show"
> - * function.
> - *
> - * If the WMI is success the sysfs attribute is notified.
> + * to be generic so it can be called from any integer attributes.
>   *
>   * Return: Either number of characters written to buf, or an error 
> code.
>   */
>  static ssize_t attr_capdata01_show(struct kobject *kobj,
> -				   struct kobj_attribute *kattr, char *buf,
> -				   struct tunable_attr_01 *tunable_attr,
> -				   enum attribute_property prop)
> +				   const struct kobj_attribute *kattr, char *buf)
>  {
>  	struct lwmi_om_priv *priv = kobj_to_om_priv(kobj);
> +	const struct capdata01_attr *cd01_attr = 
> kobj_attr_to_cd01_attr(kattr);
> +	const struct tunable_attr_01 *tunable_attr = cd01_attr->tunable_attr;
> +	enum attribute_property prop = cd01_attr->prop;
>  	struct capdata01 capdata;
>  	u32 attribute_id;
>  	int value, ret;
> @@ -1204,26 +1237,23 @@ static ssize_t attr_capdata01_show(struct 
> kobject *kobj,
>   * @kattr: Pointer to the attribute calling this function.
>   * @buf: The buffer to read from, this is parsed to `int` type.
>   * @count: Required by sysfs attribute macros, pass in from the callee 
> attr.
> - * @tunable_attr: The attribute to be stored.
>   *
>   * Sets the value of the given attribute when operating under the 
> "custom"
>   * smartfan profile. The current smartfan profile is retrieved from the
>   * lenovo-wmi-gamezone driver and error is returned if the result is 
> not
>   * "custom". This function is intended to be generic so it can be 
> called from
> - * any integer attribute's "_store" function. The integer to be sent 
> to the WMI
> - * method is range checked and an error code is returned if out of 
> range.
> - *
> - * If the value is valid and WMI is success, then the sysfs attribute 
> is
> - * notified.
> + * any integer attributes. The integer to be sent to the WMI method is 
> range
> + * checked and an error code is returned if out of range.
>   *
>   * Return: Either count, or an error code.
>   */
>  static ssize_t attr_current_value_store(struct kobject *kobj,
> -					struct kobj_attribute *kattr,
> -					const char *buf, size_t count,
> -					struct tunable_attr_01 *tunable_attr)
> +					const struct kobj_attribute *kattr,
> +					const char *buf, size_t count)
>  {
>  	struct lwmi_om_priv *priv = kobj_to_om_priv(kobj);
> +	const struct capdata01_attr *cd01_attr = 
> kobj_attr_to_cd01_attr(kattr);
> +	const struct tunable_attr_01 *tunable_attr = cd01_attr->tunable_attr;
>  	struct wmi_method_args_32 args = {};
>  	struct capdata01 capdata;
>  	enum thermal_mode mode;
> @@ -1266,22 +1296,20 @@ static ssize_t attr_current_value_store(struct 
> kobject *kobj,
>   * @kobj: Pointer to the driver object.
>   * @kattr: Pointer to the attribute calling this function.
>   * @buf: The buffer to write to.
> - * @tunable_attr: The attribute to be read.
>   *
>   * Retrieves the value of the given attribute for the current smartfan 
> profile.
>   * The current smartfan profile is retrieved from the 
> lenovo-wmi-gamezone driver.
>   * This function is intended to be generic so it can be called from 
> any integer
> - * attribute's "_show" function.
> - *
> - * If the WMI is success the sysfs attribute is notified.
> + * attributes.
>   *
>   * Return: Either number of characters written to buf, or an error 
> code.
>   */
>  static ssize_t attr_current_value_show(struct kobject *kobj,
> -				       struct kobj_attribute *kattr, char *buf,
> -				       struct tunable_attr_01 *tunable_attr)
> +				       const struct kobj_attribute *kattr, char *buf)
>  {
>  	struct lwmi_om_priv *priv = kobj_to_om_priv(kobj);
> +	const struct capdata01_attr *cd01_attr = 
> kobj_attr_to_cd01_attr(kattr);
> +	const struct tunable_attr_01 *tunable_attr = cd01_attr->tunable_attr;
>  	struct wmi_method_args_32 args = {};
>  	enum thermal_mode mode;
>  	int retval;
> @@ -1382,128 +1410,99 @@ static bool lwmi_attr_01_is_supported(struct 
> lwmi_om_priv *priv,
>  }
> 
>  /* Lenovo WMI Other Mode Attribute macros */
> -#define __LWMI_ATTR_RO(_func, _name)                                  \
> -	{                                                             \
> -		.attr = { .name = __stringify(_name), .mode = 0444 }, \
> -		.show = _func##_##_name##_show,                       \
> -	}
> 
> -#define __LWMI_ATTR_RO_AS(_name, _show)                               \
> -	{                                                             \
> -		.attr = { .name = __stringify(_name), .mode = 0444 }, \
> -		.show = _show,                                        \
> +/* Attribute current value read/write */
> +#define __LWMI_TUNABLE_CURRENT_VALUE_CAP01(_attrname)                  
>                       \
> +	static const struct capdata01_attr 
> ext_attr_##_attrname##_current_value = {          \
> +		.kobj_attr = __KOBJ_ATTR(current_value, 0644,                        
>         \
> +					 attr_current_value_show, attr_current_value_store), \
> +		.tunable_attr = &_attrname,                                          
>         \
>  	}
> 
> -#define __LWMI_ATTR_RW(_func, _name) \
> -	__ATTR(_name, 0644, _func##_##_name##_show, _func##_##_name##_store)
> -
> -/* Shows a formatted static variable */
> -#define __LWMI_ATTR_SHOW_FMT(_prop, _attrname, _fmt, _val)             
>         \
> -	static ssize_t _attrname##_##_prop##_show(                            
>  \
> -		struct kobject *kobj, struct kobj_attribute *kattr, char *buf) \
> -	{                                                                     
>  \
> -		return sysfs_emit(buf, _fmt, _val);                            \
> -	}                                                                     
>  \
> -	static struct kobj_attribute attr_##_attrname##_##_prop =             
>  \
> -		__LWMI_ATTR_RO(_attrname, _prop)
> +/* Attribute property read only */
> +#define __LWMI_TUNABLE_RO_CAP01(_prop, _attrname, _prop_type)          
>                      \
> +	static const struct capdata01_attr ext_attr_##_attrname##_##_prop = { 
>               \
> +		.kobj_attr = __KOBJ_ATTR(_prop, 0444, attr_capdata01_show, NULL),    
>        \
> +		.tunable_attr = &_attrname,                                          
>        \
> +		.prop = _prop_type,                                                  
>        \
> +	}
> 
> -/* Attribute current value read/write */
> -#define __LWMI_TUNABLE_CURRENT_VALUE_CAP01(_attrname)                  
>         \
> -	static ssize_t _attrname##_current_value_store(                       
>  \
> -		struct kobject *kobj, struct kobj_attribute *kattr,            \
> -		const char *buf, size_t count)                                 \
> -	{                                                                     
>  \
> -		return attr_current_value_store(kobj, kattr, buf, count,       \
> -						&_attrname);                   \
> -	}                                                                     
>  \
> -	static ssize_t _attrname##_current_value_show(                        
>  \
> -		struct kobject *kobj, struct kobj_attribute *kattr, char *buf) \
> -	{                                                                     
>  \
> -		return attr_current_value_show(kobj, kattr, buf, &_attrname);  \
> -	}                                                                     
>  \
> -	static struct kobj_attribute attr_##_attrname##_current_value =       
>  \
> -		__LWMI_ATTR_RW(_attrname, current_value)
> +/* Attribute display name */
> +#define __LWMI_DISPLAY_NAME(_attrname, _val)                           
>                      \
> +	static const struct capdata01_attr 
> ext_attr_##_attrname##_display_name = {          \
> +		.kobj_attr = __KOBJ_ATTR(display_name, 0444, attr_display_name_show, 
> NULL), \
> +		.tunable_attr = &_attrname,                                          
>        \
> +		.display_name = _val,                                                
>        \
> +	}
> 
> -/* Attribute property read only */
> -#define __LWMI_TUNABLE_RO_CAP01(_prop, _attrname, _prop_type)          
>         \
> -	static ssize_t _attrname##_##_prop##_show(                            
>  \
> -		struct kobject *kobj, struct kobj_attribute *kattr, char *buf) \
> -	{                                                                     
>  \
> -		return attr_capdata01_show(kobj, kattr, buf, &_attrname,       \
> -					   _prop_type);                        \
> -	}                                                                     
>  \
> -	static struct kobj_attribute attr_##_attrname##_##_prop =             
>  \
> -		__LWMI_ATTR_RO(_attrname, _prop)
> -
> -#define LWMI_ATTR_GROUP_TUNABLE_CAP01(_attrname, _fsname, _dispname)   
>    \
> +#define LWMI_ATTR_GROUP_TUNABLE_CAP01(_attrname, _dispname)            
>    \
>  	__LWMI_TUNABLE_CURRENT_VALUE_CAP01(_attrname);                    \
>  	__LWMI_TUNABLE_RO_CAP01(default_value, _attrname, DEFAULT_VAL);   \
> -	__LWMI_ATTR_SHOW_FMT(display_name, _attrname, "%s\n", _dispname); \
> +	__LWMI_DISPLAY_NAME(_attrname, _dispname);                        \
>  	__LWMI_TUNABLE_RO_CAP01(max_value, _attrname, MAX_VAL);           \
>  	__LWMI_TUNABLE_RO_CAP01(min_value, _attrname, MIN_VAL);           \
>  	__LWMI_TUNABLE_RO_CAP01(scalar_increment, _attrname, STEP_VAL);   \
> -	static struct kobj_attribute attr_##_attrname##_type =            \
> -		__LWMI_ATTR_RO_AS(type, int_type_show);                   \
> -	static struct attribute *_attrname##_attrs[] = {                  \
> -		&attr_##_attrname##_current_value.attr,                   \
> -		&attr_##_attrname##_default_value.attr,                   \
> -		&attr_##_attrname##_display_name.attr,                    \
> -		&attr_##_attrname##_max_value.attr,                       \
> -		&attr_##_attrname##_min_value.attr,                       \
> -		&attr_##_attrname##_scalar_increment.attr,                \
> -		&attr_##_attrname##_type.attr,                            \
> +	static const struct attribute *const _attrname##_attrs[] = {      \
> +		&ext_attr_##_attrname##_current_value.kobj_attr.attr,     \
> +		&ext_attr_##_attrname##_default_value.kobj_attr.attr,     \
> +		&ext_attr_##_attrname##_display_name.kobj_attr.attr,      \
> +		&ext_attr_##_attrname##_max_value.kobj_attr.attr,         \
> +		&ext_attr_##_attrname##_min_value.kobj_attr.attr,         \
> +		&ext_attr_##_attrname##_scalar_increment.kobj_attr.attr,  \
> +		&attr_int_type.attr,                                      \
>  		NULL,                                                     \
>  	};                                                                \
>  	static const struct attribute_group _attrname##_attr_group = {    \
> -		.name = _fsname, .attrs = _attrname##_attrs               \
> +		.name = #_attrname,                                       \
> +		.attrs_const = _attrname##_attrs,                         \
>  	}
> 
>  /* CPU tunable attributes */
> -LWMI_ATTR_GROUP_TUNABLE_CAP01(cpu_temp, "cpu_temp",
> +LWMI_ATTR_GROUP_TUNABLE_CAP01(cpu_temp,
>  			      "Set the CPU thermal load limit");
> -LWMI_ATTR_GROUP_TUNABLE_CAP01(ppt_cpu_cl, "ppt_cpu_cl",
> +LWMI_ATTR_GROUP_TUNABLE_CAP01(ppt_cpu_cl,
>  			      "Set the CPU cross loading power limit");
> -LWMI_ATTR_GROUP_TUNABLE_CAP01(ppt_pl1_apu_spl, "ppt_pl1_apu_spl",
> +LWMI_ATTR_GROUP_TUNABLE_CAP01(ppt_pl1_apu_spl,
>  			      "Set the APU sustained power limit");
> -LWMI_ATTR_GROUP_TUNABLE_CAP01(ppt_pl1_spl, "ppt_pl1_spl",
> +LWMI_ATTR_GROUP_TUNABLE_CAP01(ppt_pl1_spl,
>  			      "Set the CPU sustained power limit");
> -LWMI_ATTR_GROUP_TUNABLE_CAP01(ppt_pl1_spl_cl, "ppt_pl1_spl_cl",
> +LWMI_ATTR_GROUP_TUNABLE_CAP01(ppt_pl1_spl_cl,
>  			      "Set the CPU cross loading sustained power limit");
> -LWMI_ATTR_GROUP_TUNABLE_CAP01(ppt_pl2_sppt, "ppt_pl2_sppt",
> +LWMI_ATTR_GROUP_TUNABLE_CAP01(ppt_pl2_sppt,
>  			      "Set the CPU slow package power tracking limit");
> -LWMI_ATTR_GROUP_TUNABLE_CAP01(ppt_pl2_sppt_cl, "ppt_pl2_sppt_cl",
> +LWMI_ATTR_GROUP_TUNABLE_CAP01(ppt_pl2_sppt_cl,
>  			      "Set the CPU cross loading slow package power tracking limit");
> -LWMI_ATTR_GROUP_TUNABLE_CAP01(ppt_pl3_fppt, "ppt_pl3_fppt",
> +LWMI_ATTR_GROUP_TUNABLE_CAP01(ppt_pl3_fppt,
>  			      "Set the CPU fast package power tracking limit");
> -LWMI_ATTR_GROUP_TUNABLE_CAP01(ppt_pl3_fppt_cl, "ppt_pl3_fppt_cl",
> +LWMI_ATTR_GROUP_TUNABLE_CAP01(ppt_pl3_fppt_cl,
>  			      "Set the CPU cross loading fast package power tracking limit");
> -LWMI_ATTR_GROUP_TUNABLE_CAP01(ppt_pl1_tau, "ppt_pl1_tau",
> +LWMI_ATTR_GROUP_TUNABLE_CAP01(ppt_pl1_tau,
>  			      "Set the CPU sustained power limit exceed duration");
> -LWMI_ATTR_GROUP_TUNABLE_CAP01(ppt_pl4_ipl, "ppt_pl4_ipl",
> +LWMI_ATTR_GROUP_TUNABLE_CAP01(ppt_pl4_ipl,
>  			      "Set the CPU instantaneous power limit");
> -LWMI_ATTR_GROUP_TUNABLE_CAP01(ppt_pl4_ipl_cl, "ppt_pl4_ipl_cl",
> +LWMI_ATTR_GROUP_TUNABLE_CAP01(ppt_pl4_ipl_cl,
>  			      "Set the CPU cross loading instantaneous power limit");
> 
>  /* GPU tunable attributes */
> -LWMI_ATTR_GROUP_TUNABLE_CAP01(dgpu_boost_clk, "dgpu_boost_clk",
> +LWMI_ATTR_GROUP_TUNABLE_CAP01(dgpu_boost_clk,
>  			      "Set the dedicated GPU boost clock");
> -LWMI_ATTR_GROUP_TUNABLE_CAP01(dgpu_didvid, "dgpu_didvid",
> +LWMI_ATTR_GROUP_TUNABLE_CAP01(dgpu_didvid,
>  			      "Get the GPU device identifier and vendor identifier");
> -LWMI_ATTR_GROUP_TUNABLE_CAP01(dgpu_enable, "dgpu_enable",
> +LWMI_ATTR_GROUP_TUNABLE_CAP01(dgpu_enable,
>  			      "Set the dedicated Nvidia GPU enabled status");
> -LWMI_ATTR_GROUP_TUNABLE_CAP01(gpu_mode, "gpu_mode",
> +LWMI_ATTR_GROUP_TUNABLE_CAP01(gpu_mode,
>  			      "Set the GPU mode by power limit");
> -LWMI_ATTR_GROUP_TUNABLE_CAP01(gpu_nv_ac_offset, "gpu_nv_ac_offset",
> +LWMI_ATTR_GROUP_TUNABLE_CAP01(gpu_nv_ac_offset,
>  			      "Set the Nvidia GPU AC total processing power baseline offset");
> -LWMI_ATTR_GROUP_TUNABLE_CAP01(gpu_nv_bpl, "gpu_nv_bpl",
> +LWMI_ATTR_GROUP_TUNABLE_CAP01(gpu_nv_bpl,
>  			      "Set the Nvidia GPU base power limit");
> -LWMI_ATTR_GROUP_TUNABLE_CAP01(gpu_nv_cpu_boost, "gpu_nv_cpu_boost",
> +LWMI_ATTR_GROUP_TUNABLE_CAP01(gpu_nv_cpu_boost,
>  			      "Set the Nvidia GPU to CPU dynamic boost limit");
> -LWMI_ATTR_GROUP_TUNABLE_CAP01(gpu_nv_ctgp, "gpu_nv_ctgp",
> +LWMI_ATTR_GROUP_TUNABLE_CAP01(gpu_nv_ctgp,
>  			      "Set the GPU configurable total graphics power");
> -LWMI_ATTR_GROUP_TUNABLE_CAP01(gpu_nv_ppab, "gpu_nv_ppab",
> +LWMI_ATTR_GROUP_TUNABLE_CAP01(gpu_nv_ppab,
>  			      "Set the Nvidia GPU power performance aware boost limit");
> -LWMI_ATTR_GROUP_TUNABLE_CAP01(gpu_temp, "gpu_temp",
> +LWMI_ATTR_GROUP_TUNABLE_CAP01(gpu_temp,
>  			      "Set the GPU thermal load limit");
> 
>  static struct capdata01_attr_group cd01_attr_groups[] = {
>
This one made my head hurt...but I think it's all good.
Reviewed-by: Mark Pearson <mpearson-lenovo@squebb.ca>
Mark

  reply	other threads:[~2026-11-18 22:19 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18 18:58 [PATCH 0/5] platform/x86: lenovo-wmi-other: Refine firmware_attributes interface Rong Zhang
2026-11-18 18:58 ` [PATCH 1/5] platform/x86: lenovo-wmi-other: Retrieve private data from firmware_attributes device Rong Zhang
2026-11-18 22:19   ` Mark Pearson
2026-11-18 18:58 ` [PATCH 2/5] platform/x86: lenovo-wmi-other: Eliminate attribute-specific callbacks Rong Zhang
2026-11-18 22:17   ` Mark Pearson [this message]
2026-11-18 18:58 ` [PATCH 3/5] platform/x86: lenovo-wmi-other: Factor out tunable_attr_01 definition into a macro Rong Zhang
2026-11-18 22:19   ` Mark Pearson
2026-11-18 18:58 ` [PATCH 4/5] platform/x86: lenovo-wmi-other: Properly implement no_singleton driver Rong Zhang
2026-11-18 22:27   ` Mark Pearson
2026-11-18 18:58 ` [PATCH 5/5] platform/x86: lenovo-wmi-other: Hide unsupported attributes using is_visible() callback Rong Zhang
2026-11-18 22:23   ` Mark Pearson
2026-11-18 22:19 ` [PATCH 0/5] platform/x86: lenovo-wmi-other: Refine firmware_attributes interface Mark Pearson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6eaa6dc3-3997-423d-997d-e673872c3e86@app.fastmail.com \
    --to=mpearson-lenovo@squebb.ca \
    --cc=W_Armin@gmx.de \
    --cc=alok.a.tiwari@oracle.com \
    --cc=derekjohn.clark@gmail.com \
    --cc=hansg@kernel.org \
    --cc=i@rong.moe \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®