From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C7E65282F1B for ; Wed, 1 Jul 2026 18:32:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782930774; cv=none; b=OdqOm1XXKCZeJmekSGHG8rK1e7RI7EKK4F6wYg7LbhDz6Ifkrvf0gRFTG+eAwc9mAHRkLCsQwSh9ZUP7Kuwj0xojqlzfWgi/oIDCVW/A+6+7TbAvA6aZIygwpPGisNh4yNGO5YIgZk2MMhuirjUECasgGet77xrtSP5S9PlDGRE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782930774; c=relaxed/simple; bh=OBzuYLN6vhVIrxWkGb5vsdXFbSF7PtehuCVIUKaFcQI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Txml5uKtQaNwGZew+hc9fvK47cCjn5NTudVkABLQg3FdKYuGtsS4U8byWevxMlFDADqmJsQurJVb2GpxrNoyv0pWSOHJleYJhBGYXw6oBYVImBUy3g2ZlwbHFp9RKtdtsfwZUPu5f2tLJt4iQ7YD4IZfioT/s5SM7sxrtLNBuYk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=QK9FE0NO; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=heCoqK1n; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="QK9FE0NO"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="heCoqK1n" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 661GmrVe1730938 for ; Wed, 1 Jul 2026 18:32:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ga0nOypE+AmSwnDk0QkoIAUCRNWqmLFXP+nFt7njQzA=; b=QK9FE0NOocMaTgn+ JNxvdDEkKUIFibdkaKl+Y5qExEE1q4ZstBMUXYt2wuNfBsJoXe5TW9U/oqCgZK77 K2jV3ZxhzU5n86G0HHnkA+SdHHo9EKzhiT1eKNB7G5BSQ0eSlG/eynwOsVxvFsLy +Mr2iXZgfqvoBrc8aWcVi330gLNqRFmLjfHtYKn4dVMylJhU98+rzYsOL6ql9sB0 lD0utDh2CJEJe68aSPciJtgYA18T57BvNGTGy7UnQYZCP0nUNejL5P62KyS8nI2N pa/ezrFp3OfSijQ+japedljh4xujryXeYDuYu2B2Y+C1O0XVai71ytIpdnXa6vOd +qlH8Q== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f510aj3r8-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 01 Jul 2026 18:32:53 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-37fbdbc4d03so1175305a91.1 for ; Wed, 01 Jul 2026 11:32:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782930772; x=1783535572; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ga0nOypE+AmSwnDk0QkoIAUCRNWqmLFXP+nFt7njQzA=; b=heCoqK1nabs86Nr4mAEX6enFB2cx1pWGJIG6plsZRTosxYDffJb6ibVvkTe1ytAug8 8upC4IfBO425XI+L3uGwkev82ZnyY1MtrwtWcheLuoj4YX+pc3KCGcOUC2wTw2V0Z9zf 5qPDHfqom7UKfmkf/uSNdALCMBD7r3sYXvKQ9bQrb4zeFxTdiemCRJLluUrFufCurP0e AwTIGe46zhFB7UzI/qbhKWD5AO5gAcpCE1PlGvZFqoxDXHhsfVwaitSmPWiRKRpV99OZ d3zrIRp+S8EwvHalT/VRa21T7rEiPXS6ofPtVl7EyrzvQlT1zcmCNptjfceydIhlANds g6MA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782930772; x=1783535572; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ga0nOypE+AmSwnDk0QkoIAUCRNWqmLFXP+nFt7njQzA=; b=rczs+HPqlCaLOHEEs7iJoqw6oVGsu8Ut3P16SO867T1DoW43gbjldS1Pdup82HWjNF pQ0aek6LrCY3jHgNHiFcAykKA1KUhltmdbQ9Z8VkNip3yjvOLpaPO3LKihkHne6zT5Xa UChcriIfpDvqe2ugAXcP4XPPiWI2VNIlPRqoUuQoTEhEbApvZYzeefuI9dJMevKYCBuj HhGNsR68NCNGl9Ni1KYsJ2L2B3FLG1W2DPMqFh87F6upLo5E3cl0ZUUl5p88b1LiG1UR 3SRAqQMQ73SN3RnZnJQ9Jc6l0Kvl91jmVTVsHL/ZgKKW3QtRXHUf57LMtIlYGwEe+lNK JgGw== X-Forwarded-Encrypted: i=1; AHgh+RovbVmTnRdIedt5k2wTa49UdTA2fhF5vlrEbQhJD8AdTkbay3oxh9c3E2PHBMy6Fixg+7cHLaIcztUGye8=@vger.kernel.org X-Gm-Message-State: AOJu0YxAPjZkmTV49GW9fpzUECbPupv/oP79QazkSGBOskMGhxcb+enj nwzWxVsX+2r7rRSJbvVEz4CPn9+LvU8mAshppHvLF76YgFrUYfjSJHivKnxI20jnxsSw8+lIdNH pAzrFGNBdi/jvAei2szuZWdXtHPp9jjL9PG1L+08obanSlnufnLd3pA38ikS345FMK5A= X-Gm-Gg: AfdE7cm0jBpKVcHO9aQw7n9YD7SxluCNNX+FBpZ6CfncbZIdUegfSfnVDEYZKjB5REn JBQqrXRm8/pvUf2Q5A5cZRe0wVj+4TbKxAbPH/xYv7s6VqDRyB/kEPAugzikwV0vRjBxMrLGaAh mfGOsHvoh88nnLRgbDS5Dvgp7lU60YoUMPEPQTPRR4sFeW5Oxv0x4TzQSNp7gEJvvsODKjlLU2Z 0JgjYSoe96PeE/uBh5L0UCiQOI2AHI8l7e6qSzHJishA6Anra1yFG+bTHY1IygoU/5DdB5YOXmX SfN0xXEXc0swK62dYZeKOWRUIxSDPgfM6A5VgeeChyI34sPHGAJt28yaQz3t7OWxEOeXf3wR7ZY edv3veBKQaz7Yhpk0IVw8qfrYCHwkqpvR41L/pgVprtW0jwETX6mkYf5hFjjySfD/P95qcas= X-Received: by 2002:a17:90b:2c86:b0:37f:ef1f:5977 with SMTP id 98e67ed59e1d1-38069c56fb4mr6136230a91.14.1782930772238; Wed, 01 Jul 2026 11:32:52 -0700 (PDT) X-Received: by 2002:a17:90b:2c86:b0:37f:ef1f:5977 with SMTP id 98e67ed59e1d1-38069c56fb4mr6136195a91.14.1782930771779; Wed, 01 Jul 2026 11:32:51 -0700 (PDT) Received: from [10.227.110.203] (i-global254.qualcomm.com. [199.106.103.254]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30f0bb84405sm426784eec.17.2026.07.01.11.32.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Jul 2026 11:32:51 -0700 (PDT) Message-ID: <6ead2507-2306-452c-b08a-96b13b075e14@oss.qualcomm.com> Date: Wed, 1 Jul 2026 11:32:50 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 3/3] wifi: carl9170: fix buffer overflow in rx_stream failover path To: Tristan Madani , Christian Lamparter Cc: Johannes Berg , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, Tristan Madani References: <20260421134929.325662-1-tristmd@gmail.com> <20260421134929.325662-4-tristmd@gmail.com> From: Jeff Johnson Content-Language: en-US In-Reply-To: <20260421134929.325662-4-tristmd@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: vEX9Ny4Bi6gj2p8vJNvUQeF0D9vx2A2m X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzAxMDE5OCBTYWx0ZWRfX9SHGhHEQJWC5 Vj3fu/zUaobHH8JWSJZn+vF7BYxH/c/ecs27XMI56ZESwXpNh8hZnoCSLIWbxtn5yzS0NcN0tcv 8fpjslj65DebOl3Zv+4d1YTPGpxHgLIa9m80Piu9ZYjUL/gFKscseQEQkZzmKghcGtCF9rX8T7i tbu4KdlVImkQgd4ONv8fI2HcSB8Z3Osgz4wO3WUzJQH0X6ePtmsw2uH6cKiRpgoAWtKUyrsLjBN 7kulwik3A8mMfPQI6879xoy3FYYZoFGFHwKf16nlQ8CUOECH6s8SuonFXt9EiQTbMu6ePOvI+pP 5/O7efci673/4sXCbeLdXgoYx7GEZSTDPsMa+McLf29cxrUCZbM9jmlMJD2E22gSprKtNBRVAy5 TRdsoXAHtTw2u3YDN8wb7uGB8VwNGwseGfwuq1XBbJQE9AGGtUI0TGAmKYBDRAlP9pFhhWQJG06 EzB2YCu4BeWWqI2KAdw== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzAxMDE5OCBTYWx0ZWRfXxtP1YxNsI8y4 srLYueeLOC+/M1UoIc0S6TotCqixRXQ/jVIK/RQ41tpPC2NIWXxfKXPwEqNPX3lOMfH5UBr+1AA UwYYzZKzLpVTu19yyJS0+i/iHQBj0Ak= X-Authority-Analysis: v=2.4 cv=JpXBas4C c=1 sm=1 tr=0 ts=6a455d55 cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=J_-Nd1mkAAAA:8 a=4kDpEtFwccDkzV5kScQA:9 a=QEXdDO2ut3YA:10 a=iS9zxrgQBfv6-_F4QbHw:22 a=n8ForQn92ZFaZtFqRdMw:22 X-Proofpoint-ORIG-GUID: vEX9Ny4Bi6gj2p8vJNvUQeF0D9vx2A2m X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-01_04,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 suspectscore=0 malwarescore=0 impostorscore=0 clxscore=1015 spamscore=0 priorityscore=1501 phishscore=0 lowpriorityscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607010198 On 4/21/2026 6:49 AM, Tristan Madani wrote: > From: Tristan Madani > > The failover continuation in carl9170_rx_stream() copies the full tlen > from the second USB transfer instead of capping at rx_failover_missing > bytes. When both transfers are near maximum size, the total exceeds the > 65535-byte failover SKB, triggering skb_over_panic. > > Limit the copy size to the missing byte count. > > Fixes: a84fab3cbfdc ("carl9170: 802.11 rx/tx processing and usb backend") > Signed-off-by: Tristan Madani > --- > Changes in v3: > - Regenerated from wireless-next with proper git format-patch. > > Changes in v2: > - Use min_t() instead of separate if-check, per Christian Lamparter. > > drivers/net/wireless/ath/carl9170/rx.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/ath/carl9170/rx.c b/drivers/net/wireless/ath/carl9170/rx.c > index f6855efc05c0f..ccadc46385240 100644 > --- a/drivers/net/wireless/ath/carl9170/rx.c > +++ b/drivers/net/wireless/ath/carl9170/rx.c > @@ -918,7 +918,9 @@ static void carl9170_rx_stream(struct ar9170 *ar, void *buf, unsigned int len) > } > } > > - skb_put_data(ar->rx_failover, tbuf, tlen); > + skb_put_data(ar->rx_failover, tbuf, > + min_t(unsigned int, tlen, checkpatch complains: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis no need to repost for this, I can fix when applying > + ar->rx_failover_missing)); > ar->rx_failover_missing -= tlen; > > if (ar->rx_failover_missing <= 0) {