From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Andy Yan <andyshrk@163.com>, heiko@sntech.de
Cc: krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-rockchip@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 4/5] dt-bindings: arm: rockchip: Add Cool Pi CM5 EVB
Date: Sun, 10 Dec 2023 12:11:33 +0100 [thread overview]
Message-ID: <6eb1541b-430b-41cf-b297-ebb3d47f5278@linaro.org> (raw)
In-Reply-To: <20231210080607.1667517-1-andyshrk@163.com>
On 10/12/2023 09:06, Andy Yan wrote:
> Add Cool Pi CM5 EVB, a board powered by RK3588
>
> Signed-off-by: Andy Yan <andyshrk@163.com>
>
> ---
>
> Changes in v2:
> - change board compatible from "CoolPi CM5 EVB" to "coolpi,pi-cm5-evb"
>
> Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
> index 11d03035f3db..4da83bbd642a 100644
> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> @@ -95,6 +95,11 @@ properties:
> - const: chipspark,rayeager-px2
> - const: rockchip,rk3066a
>
> + - description: Cool Pi Compute Module 5(CM5) EVB
> + items:
> + - const: coolpi,pi-cm5-evb
If it is module you are maybe missing here module DTSI and compatible.
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-12-10 11:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-10 8:03 [PATCH v2 0/5] Add 2 rk3588 based boards from Cool Pi Andy Yan
2023-12-10 8:03 ` [PATCH v2 1/5] dt-bindings: vendor-prefixes: Add " Andy Yan
2023-12-10 8:04 ` [PATCH v2 2/5] dt-bindings: arm: rockchip: Add Cool Pi 4B Andy Yan
2023-12-10 11:10 ` Krzysztof Kozlowski
2023-12-10 8:05 ` [PATCH v2 3/5] arm64: dts: rockchip: Add support for rk3588s based board " Andy Yan
2023-12-10 11:13 ` Krzysztof Kozlowski
2023-12-11 7:48 ` Andy Yan
2023-12-10 8:06 ` [PATCH v2 4/5] dt-bindings: arm: rockchip: Add Cool Pi CM5 EVB Andy Yan
2023-12-10 11:11 ` Krzysztof Kozlowski [this message]
2023-12-11 7:46 ` Andy Yan
2023-12-10 8:06 ` [PATCH v2 5/5] arm64: dts: rockchip: Add support for rk3588 based board " Andy Yan
2023-12-10 11:12 ` Krzysztof Kozlowski
2023-12-11 9:49 ` Andy Yan
2023-12-11 9:58 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6eb1541b-430b-41cf-b297-ebb3d47f5278@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=andyshrk@163.com \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®