From: Dmitry Osipenko <dmitry.osipenko@collabora.com>
To: Rob Clark <robdclark@gmail.com>, dri-devel@lists.freedesktop.org
Cc: Chia-I Wu <olvaffe@gmail.com>, Ryan Neph <ryanneph@chromium.org>,
Gerd Hoffmann <kraxel@redhat.com>,
Daniel Vetter <daniel@ffwll.ch>,
Rob Clark <robdclark@chromium.org>,
Javier Martinez Canillas <javierm@redhat.com>,
David Airlie <airlied@redhat.com>,
Gurchetan Singh <gurchetansingh@chromium.org>,
"open list:VIRTIO GPU DRIVER"
<virtualization@lists.linux-foundation.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5] drm/virtio: Add option to disable KMS support
Date: Thu, 2 Mar 2023 00:39:33 +0300 [thread overview]
Message-ID: <6eb2cde8-f548-73ba-6091-131c1848690c@collabora.com> (raw)
In-Reply-To: <20230301185432.3010939-1-robdclark@gmail.com>
On 3/1/23 21:54, Rob Clark wrote:
> /* virtgpu_display.c */
> +#if defined(CONFIG_DRM_VIRTIO_GPU_KMS)
> int virtio_gpu_modeset_init(struct virtio_gpu_device *vgdev);
> void virtio_gpu_modeset_fini(struct virtio_gpu_device *vgdev);
> +#else
> +static inline int virtio_gpu_modeset_init(struct virtio_gpu_device *vgdev)
> +{
> + return 0;
> +}
> +static inline void virtio_gpu_modeset_fini(struct virtio_gpu_device *vgdev)
> +{
> +}
> +#endif
In v4 Gerd wanted to keep building the virtgpu_display.o and instead add
the KSM config check to virtio_gpu_modeset_init/fini(). Is there any
reason why you didn't do that?
--
Best regards,
Dmitry
next prev parent reply other threads:[~2023-03-01 21:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-01 18:54 Rob Clark
2023-03-01 21:39 ` Dmitry Osipenko [this message]
2023-03-02 7:25 ` Gerd Hoffmann
2023-03-02 23:33 ` Rob Clark
2023-03-02 7:18 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6eb2cde8-f548-73ba-6091-131c1848690c@collabora.com \
--to=dmitry.osipenko@collabora.com \
--cc=airlied@redhat.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=gurchetansingh@chromium.org \
--cc=javierm@redhat.com \
--cc=kraxel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=olvaffe@gmail.com \
--cc=robdclark@chromium.org \
--cc=robdclark@gmail.com \
--cc=ryanneph@chromium.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®