From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D1FF9148823 for ; Fri, 9 Aug 2024 20:11:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723234264; cv=none; b=fGriDwz8Yl1v87AZEUw+xCQnqGa9m/q3Aqhm5fDZ0NLVOqiwUi5tzWdezDtMJxZNEcbRgbAxXTaw/qqhpkurFrPvnfmYzifVupoGRmXQCsH1snDNEiyMhCFJjTVsbWRNxJqxwD8fa8HGjJAHibnjj2tKg/JI0vrpMaDjV22Q5ww= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723234264; c=relaxed/simple; bh=RXZf7vkTwdMNMIB1Lg640qcRRptGXyS7Rvi9NC+WScM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=HmME3JWJmHqhGqGFb28cFWqyGBxIxpVSzM+jhqFncz0bVa2p3g99hFmWYj7aa1bf6US/L+hbr7TyP7uvenVO4YEBf6gVPtWL6pRM9cryesTOy4/bAgdSdjMRyrTjgVLz595XrqvYs11TRVpvUplFhR/Ghid8GU6+7TY+syVtKrk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=tIN07nqO; arc=none smtp.client-ip=209.85.167.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="tIN07nqO" Received: by mail-lf1-f49.google.com with SMTP id 2adb3069b0e04-52f04c29588so3247292e87.3 for ; Fri, 09 Aug 2024 13:11:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1723234261; x=1723839061; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Pj1EA6fBIZmJ4OF0t8kLT/cba5XWiaDdw7BLVxTuH04=; b=tIN07nqO0JSLBMlzs7u+WKqOUHnwFr3i00aDNxn/oOSEq94jwIPcwOZBrIhRRL+6zT GWe8orSwgMlv+sFtqJqsy0b2Qa5DtElrNxtKIun8Y/EzeUssJfkxgRdzhwS0T0UzGAFQ gLfbO3n7YAsuFD5QWxe/h4FD15ZKIT+iFcarP1MC3lftsOAptFDs+OI6/IVyspJnMGxg u04nDYtz+D8m08DLuZ1VYJeZhigEBiQceERsr18cpxsVGJZ4c5i+kTrln0eYKZtvaQI4 nH7e0eV5Fyt6Wq3fHk8hoh2U/1Ty0fHm8GhGfxwRUiLyiNPZ2Kf3pw/P0QnNasOeM4KK XPPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723234261; x=1723839061; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Pj1EA6fBIZmJ4OF0t8kLT/cba5XWiaDdw7BLVxTuH04=; b=Hxo9VeTfYcmzOYgiCJfoZF0WPqZnZHP5RhwAupGrx7VWQh2yW406/FoxsvEiKBU0hq s8tOFqM7U1kK3QQf/Q/MHfmTpyxs6uR8s4vZwmqmQpnQn0AO45sSbZQvCip+fpOS4EGt guVIaW89RV4kgXRQ6V26x9EJyJm35iUVAdLNHo35xriuBQCTohGTOrDzJ+9F76qkvuwW 0rTdUt5ctCPvAKb6mk5VnBO1QYZNE+n3BEwwvBfK5s5LVg2pJh+mAW0u1HgXceNTHfGt iAV5tWkA+hIEIAILc5rS1IDYrsYb7XE/OuYRvq3OOMBBsBn76ghERb4zBj1Tuw1Ae57j KagA== X-Forwarded-Encrypted: i=1; AJvYcCXnF2j7RDvfjSC81tCes6o+HmMKDdeC+pshgemFQBY1QQswKCafbjM1JS7470L5hfHyju7UtqPPj4jwmo2bCpRFBi4GrqjDZfXQ/qf4 X-Gm-Message-State: AOJu0YyBkxBau2L4mGv31m7b3EpPOWn2kXhirS5WPzHu7OtVmfvUit1m +c9bZKF0Ma7LZOIaRa4ZiprKCQW12OFWRS9C7q3m9FnppcbaVY/fOFOxmaq0QV8= X-Google-Smtp-Source: AGHT+IH/LnHxFTHPrshu46vY7c7WkYZl+9lpQ1usrc5SQkzFaG6QQkaJPPpkMh/UODiY9nwCiBZmfg== X-Received: by 2002:a05:6512:10d0:b0:52e:9f6b:64 with SMTP id 2adb3069b0e04-530ee9ec4f3mr1766990e87.34.1723234260740; Fri, 09 Aug 2024 13:11:00 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a80bb08f6a0sm7187266b.30.2024.08.09.13.10.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Aug 2024 13:11:00 -0700 (PDT) Date: Fri, 9 Aug 2024 23:10:56 +0300 From: Dan Carpenter To: MD Danish Anwar Cc: Jan Kiszka , Andrew Lunn , Vignesh Raghavendra , Javier Carrasco , Diogo Ivo , Jacob Keller , Simon Horman , Richard Cochran , Paolo Abeni , Jakub Kicinski , Eric Dumazet , "David S. Miller" , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, srk@ti.com, Roger Quadros Subject: Re: [PATCH net-next 5/6] net: ti: icss-iep: Move icss_iep structure Message-ID: <6eb3c922-a8c6-4df4-a9ee-ba879e323385@stanley.mountain> References: <20240808110800.1281716-1-danishanwar@ti.com> <20240808110800.1281716-6-danishanwar@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240808110800.1281716-6-danishanwar@ti.com> On Thu, Aug 08, 2024 at 04:37:59PM +0530, MD Danish Anwar wrote: > - struct ptp_clock *ptp_clock; > - struct mutex ptp_clk_mutex; /* PHC access serializer */ > - u32 def_inc; > - s16 slow_cmp_inc; [ cut ] > + struct ptp_clock *ptp_clock; > + struct mutex ptp_clk_mutex; /* PHC access serializer */ > + spinlock_t irq_lock; /* CMP IRQ vs icss_iep_ptp_enable access */ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ The patch adds this new struct member. When you're moving code around, please just move the code. Don't fix checkpatch warnings or do any other cleanups. > + u32 def_inc; > + s16 slow_cmp_inc; > + u32 slow_cmp_count; regards, dan carpenter