From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 15351313E02 for ; Fri, 14 Nov 2025 11:58:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763121511; cv=none; b=HShaM3zvRNVvomkATBt8MKyyHMqIx60afNXTGyqMrb3zgInU67W3UpgrgI6lLbmMm6oQzmRcXIMIY3/GaAJpHELlVdZvuRyauOF0RF/kLO6qmDjC55N3Ls00bA8u6oJ7pXbscQb1qE/8EbK+wxFATEFfMBnDW5cAlaQz1UKhyMA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763121511; c=relaxed/simple; bh=Dt3uOy2VtoFbOLkUEu1yu90om6ClwTmbRrXAEUFSbIU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=b05PmJWMmKsX1byx3sFMRdbgnX7utEy6EBNcmRScNGepTLjVo5Dko3m64S41ArM2+HwnmKvQQImu0Z0eH0vKQ4/HV7WjiPKjzh33kMa2XRsw41kEYZI/AJUUmUMdJl91fJujYV5myqO9K3Y1pPvhs8tBQBerMetPX8c5/BBdBeQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=HQ6QKvYN; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=YzaIjVdm; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="HQ6QKvYN"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="YzaIjVdm" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5AE8DEG31692449 for ; Fri, 14 Nov 2025 11:58:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= GRBPuTN4gFHBJkftAyq/mOmIDHNhSyqYwsTcoxYmiII=; b=HQ6QKvYNoWqSK2sP /PBXAg78g+s2ZxJ/KSthVlkOY17b2ymCBtgWtOyLzXKET01KsSsOV6/uif8Ck4fk ZoXvgzi3pTNy1KuftGT+HpP3g7oCZUVrU/Geti8UI6VtCAMAeApGkUDxFGM3aIjy +1YUCWLxzH9DwwJpqmMuVlxgxH09jCWk5W4Eyl5KL+98xn4+jRx3g1bT3uTlaT58 FXbq8ovnJGl+2e71eiLpLKUkxDXgTdQl+dNvYsitVeYlAHZAykEC3t8o7mFk2NPG VEy1uMG3ko5pLdZqryc2rCW0U4viKhfPLv4AMedDZx3WN+VW7hduMwp5jvWNKrRg rDxqlA== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4adr9g21ts-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 14 Nov 2025 11:58:28 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-341616a6fb7so2503884a91.0 for ; Fri, 14 Nov 2025 03:58:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1763121508; x=1763726308; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=GRBPuTN4gFHBJkftAyq/mOmIDHNhSyqYwsTcoxYmiII=; b=YzaIjVdmCEp6TuTzeQvXMvWMWJ/yt6+J/pxGEhcXrMIHHYpx2a/UnIWPfyYlOzHU8D SEmJ17cKwQi5ST+A8J9MNTq0vtlngTHwTPPBf8/L/b3h8DgFR8Yn2VO8JrSLvpeFLLtk +k5MEUfRVE73l/bNGiH+sULGYH6iD4XK//QaKvttILRrCC7FmdS2+5l4vgyP1i527Puo YcEl4U8HeMlnpSz44hCeIUYudtd01Usi1KlHEGjUJpzN0o53rBBnmqSPhuaBj2V2SAqE MUmydRK+x8UA7FONLmbNzgXKnodP1BBYF9Xa/Z4yv5Sc+b5WQaomwSpn1sb975ukNYy3 2u9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763121508; x=1763726308; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=GRBPuTN4gFHBJkftAyq/mOmIDHNhSyqYwsTcoxYmiII=; b=iZ2zyAYdu0WTvuwR5kMLjg1pX25F4YeTFomss3/TlkgmQhXxlFOLWArX5HqoXhYc0V H1wW9gsqcxaA8Kbbd87nB9Tbf4gX8Txv/uAPyvrXhdo0c7Myr+wzQIIuAFesePeSMnZ8 VruW7fRTeqPzHbSaq5c5N3xGQ28/rP+2qYx/BdXVwiAfF6leOeeWY1hSdVPT5aPtrInY 8v/67iYH/puGtZ1jKRURZzU85Ps9nBTTBv+YFMWBTZfb+q1bsv5gmXxMGJ8rlFLdepjp cfDwGI7F94lWtoxFAspnSC6IEJkO+6C/hftEatBDftriTPMDYrRnl8Ci2uRipYidUXz0 AkkA== X-Forwarded-Encrypted: i=1; AJvYcCVBd6h4SID1Qu0Wbvwqt+xifqsLCYWrsloV0QVUshOrjmHQV6DJFLYs+Zl5IgInYNz8HMKrnqRYE62TxtE=@vger.kernel.org X-Gm-Message-State: AOJu0YxlahE9ehJF+4f87Sf5b6t+ti+ws5OLtE9ztmY7Fzhhj6Br59Be oDOgrLRRm1OXarykXkLsaitxXf8zfH02wAEbGhshCztJpLQd+jEm9gQaKgx5k66U03ieXIjfU67 6wLLw7asrJ01g8o4iktjfBVrvHRY425vF9P74WlTPaW7fzkO81ubnAIbVo8AP54Mr0pA= X-Gm-Gg: ASbGncvzcZ8ryrxQbLIfvrv/MNSE0JXgrfepALKo7tVX8n53bzpryyFH7+oq+GMKTb+ LjDEqu/aVIYNvs+DWDmegs6d13XvvsIQPJRnEhznGy/JL+AQDuQxWJyGyS04le3iQz68sifQ1Z5 49iNk8y48A2iNnCbQhakVTDFlzzA79uLSYYNe/ULUMhgRnQp8ljbvNjwZX7KdiOZ1fmuq/bqUKG EVWP8NJYvWt5fHnOv13FMc0Qf0NjoiZ1Oy1Lh/7bpx5+sj1FrBPVXDzqcSFfAH2pv/2gsEF+5mO DCykdlnOXzpuxL+e+uqaqUKWuIJHWCC+YtVNtWUzY3Om6jo7MvV+52BRGiV9+HEXdJRoeOT8w+P 1zK15xhzqifGYWVuqe2girNc= X-Received: by 2002:a17:90b:5803:b0:343:653d:31c with SMTP id 98e67ed59e1d1-343f9d901bemr2963734a91.5.1763121507776; Fri, 14 Nov 2025 03:58:27 -0800 (PST) X-Google-Smtp-Source: AGHT+IGFHpQSCtLNHukFVLbxrD8xU34y4COtLfmBvJC0TqavNqnfl88QPHSsjjzeWJeLQ2nAehx0+Q== X-Received: by 2002:a17:90b:5803:b0:343:653d:31c with SMTP id 98e67ed59e1d1-343f9d901bemr2963689a91.5.1763121507270; Fri, 14 Nov 2025 03:58:27 -0800 (PST) Received: from [192.168.1.8] ([106.222.229.203]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-343eac93449sm2826717a91.3.2025.11.14.03.58.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 Nov 2025 03:58:26 -0800 (PST) Message-ID: <6ebe07ad-cbfe-47e2-99ee-06ad7670e699@oss.qualcomm.com> Date: Fri, 14 Nov 2025 17:28:18 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/6] dt-bindings: display/msm: gpu: Document A612 GPU To: Krzysztof Kozlowski Cc: Rob Clark , Sean Paul , Konrad Dybcio , Dmitry Baryshkov , Abhinav Kumar , Marijn Suijten , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Jessica Zhang , Dan Carpenter , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20251107-qcs615-spin-2-v2-0-a2d7c4fbf6e6@oss.qualcomm.com> <20251107-qcs615-spin-2-v2-2-a2d7c4fbf6e6@oss.qualcomm.com> <20251110-wise-lurking-roadrunner-f0cec3@kuoka> Content-Language: en-US From: Akhil P Oommen In-Reply-To: <20251110-wise-lurking-roadrunner-f0cec3@kuoka> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: Yb-HjYeO9rmB6QaVelhDBr8g90eTza7R X-Proofpoint-ORIG-GUID: Yb-HjYeO9rmB6QaVelhDBr8g90eTza7R X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTE0MDA5NSBTYWx0ZWRfXwI3/1py09gJ3 AzS9ezuAOKSkuNL/UJz2LmIqArN1ydYwDkDQZbym5dyY9AaxggJj+eEFYEFJOSlgMoll2XtKkwv XOJVG/pSwYpx1MVkFCuADkZZT/pEz7ZWYZ8iuijY6AYVR6Rmk0deDqNXeNoT2PEYgLKmJqmj4qO GLvqYsGIFztmyw5QX0xyb0HFxK9JK7q/G6IKFixQIhTT4B9CassplkEHcih6NqlVdbJmHR28AWL Ucw+qEKOgx6Dt5af0SkgiXQnI5O8w6snZQX2nrvjr0Cj2zbO5FxvVxeva6oKSwnHSoKxyPzdxjf 0MhyJp8uIB5dpFI6ews5NBIGoaxNZnjww4M9PkXPLTVRoWKLljUq7dYZLt7QiJrHNZxntPc8OH4 9drA9Cg9XL7lXdMvb5LLNWeMUF75Pw== X-Authority-Analysis: v=2.4 cv=IM8PywvG c=1 sm=1 tr=0 ts=69171964 cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=UUXEStRZTiKyGgBwSCQbmw==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=PLUc99ambSscJNFV4OcA:9 a=QEXdDO2ut3YA:10 a=iS9zxrgQBfv6-_F4QbHw:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-14_03,2025-11-13_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 clxscore=1015 malwarescore=0 suspectscore=0 lowpriorityscore=0 adultscore=0 impostorscore=0 phishscore=0 priorityscore=1501 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511140095 On 11/10/2025 1:18 PM, Krzysztof Kozlowski wrote: > On Fri, Nov 07, 2025 at 02:20:07AM +0530, Akhil P Oommen wrote: >> A612 GPU has a new IP called RGMU (Reduced Graphics Management Unit) >> which replaces GMU. But it doesn't do clock or voltage scaling. So we >> need the gpu core clock in the GPU node along with the power domain to >> do clock and voltage scaling from the kernel. Update the bindings to >> describe this GPU. >> >> Signed-off-by: Akhil P Oommen >> --- >> .../devicetree/bindings/display/msm/gpu.yaml | 32 ++++++++++++++++++++-- >> 1 file changed, 30 insertions(+), 2 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/display/msm/gpu.yaml b/Documentation/devicetree/bindings/display/msm/gpu.yaml >> index 826aafdcc20b..a6bbc88e6a24 100644 >> --- a/Documentation/devicetree/bindings/display/msm/gpu.yaml >> +++ b/Documentation/devicetree/bindings/display/msm/gpu.yaml >> @@ -45,11 +45,11 @@ properties: >> - const: amd,imageon >> >> clocks: >> - minItems: 2 >> + minItems: 1 >> maxItems: 7 >> >> clock-names: >> - minItems: 2 >> + minItems: 1 >> maxItems: 7 >> >> reg: >> @@ -387,6 +387,34 @@ allOf: >> required: >> - clocks >> - clock-names >> + >> + - if: >> + properties: >> + compatible: >> + contains: >> + const: qcom,adreno-612.0 >> + then: >> + properties: >> + clocks: >> + items: >> + - description: GPU Core clock >> + >> + clock-names: >> + items: >> + - const: core >> + >> + reg: >> + items: >> + - description: GPU Reg memory >> + >> + reg-names: >> + items: >> + - const: kgsl_3d0_reg_memory > > What happened with the second entry? Please describe the hardware > COMPLETELY (see writing bindings doc). We can describe cx_mem and cx_dbgc too here. Then it matches the common schema described at the top of this file. In that case, do we need to re-describe it here or we can just remove both reg and reg-names properties here? -Akhil. > > Best regards, > Krzysztof >