From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4BCA223EA9B for ; Fri, 17 Jul 2026 00:56:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784249777; cv=none; b=mDt+X+UQVRAi8PB70cakk5p0cN/CrFKEfk4TripaggIOzoT7Hs9xXYw7+M652KrPi46rAXqD7vEhx5otwQVDE8ohbOlmDr5+WSfNIhKauLSYgAVRgmDrA7H1i+BBlZMHN51Pky8sDfE5VlokQ2vfb5IwGkH6AiRBExpjbmbBxIo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784249777; c=relaxed/simple; bh=ILiF8+Rcm1mefft9y9zDjqPEx9ACF570hRlq1Kk/6k4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=mJVrAU2l3US3hIupww6Jmy+mPKWBsyRXAh36HSJxdvkCqXgsFS2HOS2qv3YE7/LxKOc4TRrVmsZ4aK6v/r5oaAbHUFoQwEVpy2dpi+F5UPmCv8rsD38eNaHgccChxKNNcn1g35CIPLns5t5VN5avP2q0m2JXMInTF2QNuL/njNc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=hhFU0ykd; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=B00nGoH5; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="hhFU0ykd"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="B00nGoH5" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1784249775; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rHqYR7r+HsXp1+8aTKfJipuPeP0SacjoivPvFJAlmZo=; b=hhFU0ykdsA1fsASKnltgyyWD2WfH2mvza8hV0pHkUm96kCPlZIQ5Mx5D0tCQid8JOP2O/q 1dGVwcX39nl68lp3MsR8iR5SrUNrMizWbaZpukDr+7ODlnT6FNGQ0cvIlnnXEFfjULZXqn SGBrJGDTbBeccswUTZcdj5MJhpDJxJ0= Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-384-lhVKjTgWM9SWpJc2M0HEFA-1; Thu, 16 Jul 2026 20:56:13 -0400 X-MC-Unique: lhVKjTgWM9SWpJc2M0HEFA-1 X-Mimecast-MFC-AGG-ID: lhVKjTgWM9SWpJc2M0HEFA_1784249772 Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-381250979d5so4614175a91.0 for ; Thu, 16 Jul 2026 17:56:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1784249772; x=1784854572; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=rHqYR7r+HsXp1+8aTKfJipuPeP0SacjoivPvFJAlmZo=; b=B00nGoH53VYZNiyS8vZ5UNpsOcN60DwXNsrSUWIhXyYJdAE/Km6/fMi3awQ6ASQYla GsHZLYp3wxTHdBCgtqp3eqZZqC/v1losX0NFDXWr3LI26O2UeFiFj5vJ7ROAzv0RLxBr p8M2SCc2sP+aigL56ZVoBLI0uenFRnP5ReUfD2g3i/rVbL4sjyJ4DuofPjwwK0BEPD2C UtjD0ivD5Dq/2+C4btUWG8vwnS3iYlOPNOIhbPin5Bl1qBUsNo0uGIOBVlc1qjfr8b1M zmEjjYld6265ac/kw1/ZjOWJ8SFuV3ZCSj5zuM5SrOEjMGXUAeMBgoFHTrNsSniFetHA Fjfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784249772; x=1784854572; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=rHqYR7r+HsXp1+8aTKfJipuPeP0SacjoivPvFJAlmZo=; b=mDzmtgOmfaISJxXoE7j1Iun/zqFCXAI8DnInqmTm6ICpPpp8RLYYqFTRFmqnHDJ1Rb FyLG8ZeTjBItA9vqKN7X4t8BKbEcbgUrsYBrBjNdtgCr8LG5lWISn4FdYOBSHBrTlwzY Wdl+gLbXJTEQrDr9I7JsDrTb6uGeeUiaT6TZM1JCb5hCxQ8tmKUwYhO3CeJBKh13njwf FJr4lcq8DWupgvO1/wYieTTSCst8+H+a1e3lyDNWUL6o2QB9DXTtxnN0otmNhHyV6dot 1IfkDE2WDAdo2w8XFFSpFyvnN1O/ni6VQQNE+rW2enRudmsMQV1pLG2xZPOtfQBdGGoQ YooQ== X-Forwarded-Encrypted: i=1; AHgh+RoNVPYUCnmHOK9vduY8RdbbmyJqJV83mp61zpye+PraEOpReggh3yyr/kix+S45mr8+V30nd3kj5A1lnIo=@vger.kernel.org X-Gm-Message-State: AOJu0YzrlgLtW0WFfPuMIaN0f6CS/jslb+SL2MhYqjl6F0BX19lDuvGp Ew8L2RzUsxvETu8j2PYZt94Rx0baTogZqyNiv+EkxnArLEOB1CyX1te0aUiKoD6Gr0Rfcv5o6l3 PHdo9HLThEl1UxYPQ6VQM5bk7FEorvISA5Vb97Xaxa/Y9PqfE/VUw69vfelYyViVUL7AUstJdrQ == X-Gm-Gg: AfdE7clqOhiBcOA8ssoG/Lz3HKxyWYD3Yt/G6bxFnV5/9kuQQ+1jcFNLKR8tJqHhdi8 gI+lIpFDSbWPfEnjkrjZyB11X4tDtodSwKRLhmx0f1k4QqQ0q2qAutjKYlD1OHJv0U2TsbyClBT Bjjz+BSQxe4gxTQ76PTNVtFS7hdR0isyjLrDgq9D154ZI858CrmmjBbueVgOiqra00mJPKhlQrS 3GeMHypy3CiTpocWjTJ8xNtYtvV8qSwNdG+61CCTCz3h3ViWj34HkKp2IRSEx4ppAYD4UxYOX+Q y2h7xU44mBmkp30WADdZvO3GqubAHwsk+VjU8SOo8eacTEX6PVoRi9gWQxGQhx84ogQRrCtgFUN m5roOIl+JPiLq3dY25a3GmqGZoKlTKwL4tEWcxG3M68U= X-Received: by 2002:a17:90b:2f0f:b0:387:e0db:bc31 with SMTP id 98e67ed59e1d1-38e4b56ed5fmr335283a91.39.1784249772369; Thu, 16 Jul 2026 17:56:12 -0700 (PDT) X-Received: by 2002:a17:90b:2f0f:b0:387:e0db:bc31 with SMTP id 98e67ed59e1d1-38e4b56ed5fmr335258a91.39.1784249771894; Thu, 16 Jul 2026 17:56:11 -0700 (PDT) Received: from [192.168.68.51] (n175-34-8-244.mrk21.qld.optusnet.com.au. [175.34.8.244]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38e4aff1cd3sm151477a91.6.2026.07.16.17.56.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Jul 2026 17:56:11 -0700 (PDT) Message-ID: <6ebeb62e-853d-4ffe-becd-340195983bb8@redhat.com> Date: Fri, 17 Jul 2026 10:56:06 +1000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 04/11] arm_mpam: Add missing mon_sel locking in MBWU restore To: Ben Horgan Cc: james.morse@arm.com, reinette.chatre@intel.com, fenghuay@nvidia.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, dave.martin@arm.com, andre.przywara@arm.com References: <20260710115546.29644-1-ben.horgan@arm.com> <20260710115546.29644-5-ben.horgan@arm.com> Content-Language: en-US From: Gavin Shan In-Reply-To: <20260710115546.29644-5-ben.horgan@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 7/10/26 9:55 PM, Ben Horgan wrote: > The mon_sel_lock is used to protect the mbwu_state, as well as h/w accesses > that use MPAMCFG_MON_SEL. However, in mpam_restore_mbwu_state() mbwu_state > is accessed without holding the mon_sel_lock. > > Add the missing locking. > > Fixes: 41e8a14950e1 ("arm_mpam: Track bandwidth counter state for power management") > Signed-off-by: Ben Horgan > --- > drivers/resctrl/mpam_devices.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > Reviewed-by: Gavin Shan