From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B20D2EB5CD for ; Fri, 9 Jan 2026 13:10:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767964237; cv=none; b=mOsi0Cb0Y/7sBPSCuKBOTP+UD8T+8FIfao1KJUK/a9V42WA2dfkQQ6z+w5NFk5Wjw90GVR6PhVHYNpU9oDu0Xq7r8L2FdkRzdFZP2+yqvWq9RNfNAeLi9LERGWHqH8SK69CvOeuQ58gzYWc/iQWIgRlvq6KyCFom1+WDCcE8ZoI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767964237; c=relaxed/simple; bh=niAPPiQQQPX1D5kNh+Jjyf6MXYDSDaZSYDRJGQC5eJo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=UZcTMkxqwbnV3acx2DZXfNGvC1ZI6NJ5Kzx+5X+o4kWUGZH0Xl7qHi/ErbhkCSg9jdG7RLYmsfizUOjqArL1ZVOSSMCI412lbjdB/6rWItV62hhzRTBVFZ0U+iN8Fx752S1b0rgw5uHuuqNakCoBhlxTz9qG/YenqQ9XydFBatQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=KgoWrSH1; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=cj0C6FLD; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="KgoWrSH1"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="cj0C6FLD" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6098RAYl2327455 for ; Fri, 9 Jan 2026 13:10:35 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= jl3U4fYvP7BjbY7tR3WG+iIwGmMIyHgCmvFUBV6UyrQ=; b=KgoWrSH15VfHWdKm clYQA0cALEbOxYBeTqOR3dmLQ4zIp7enOHYYtADswN1lgMCVfO4fxxixLsTgeqKN fPVBu3u6XxrbRuDicmrsiyV/MfjyEWLgZEBtrrDKSAG6nLeaJtzu0vTpQGYurSUt 27qPVjr6WtecXVNYTdr7VJN4ze7hba023oDUPDNfAiBNm7ho3hTWvZNcBO83Smnx BCz67MPqHebdQyGEjWdf6kI1SCkfYlbfsMUiCWORnFIrJl73R54bzOpJKMlh+2qF FYZ2IkdYRf9Swy+RcniHw7r1ky1hXcw8vk0CvjkyZYiqhyPHqNtLYUAPFtkoIRI2 Dn3/nA== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bjfdabd0e-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 09 Jan 2026 13:10:35 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-29f1f79d6afso60309025ad.0 for ; Fri, 09 Jan 2026 05:10:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1767964234; x=1768569034; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=jl3U4fYvP7BjbY7tR3WG+iIwGmMIyHgCmvFUBV6UyrQ=; b=cj0C6FLD4NOuxEIX6tPDJcbH+lnpn9LNKOX687RGUQdrP6+R7J+eJP44ctVp9lLQGI pQHzRcTcGd6PXJNAFbpm0NTrL9CHOZBCGbinRx5RiHWqsHQhXrB7thAslU9dAc1SSJnT asMWeETUMnZgsLX+aagQrhvzQOiY1RKldGGanoTcAPGOSK8Aux4cdX91aqBmcohqqCMZ tl6NLgiFKVHh4y1Ro5w5uwAjwtpA9ybNdCSsitd/Oyzj2Oz1Y25gjzfNYFu4KRtv8CiP AAbqYQn2gqYiqEUzem0zOjXJnzRqy2dZ5zGcf580DQC1ZgfoHALrR35pPviKkwJmxu6p FJZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767964234; x=1768569034; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jl3U4fYvP7BjbY7tR3WG+iIwGmMIyHgCmvFUBV6UyrQ=; b=g8yVJni4U2vqS6bjTNcMQA5QOcT/hILJ0ZISUpoiD/Rawqm17aGs5wNtYKqA8RXFq9 Tj1H83SO21fZnIwFsknSyImH7qU6eTn7uRvT8EOqePisDQeR4tu96Cu/M3hF+KcySpaS g0zBcEHzhRcM424+uurhLfefmZBthQ5iKfPZMfxH/tWUUrXRjUmqF+VF8Rrj3fg5oycR ExIf+BtN7ME9S+8f4z7U9gJGB9ue7CRBMHlN65VGGeKaoM2QHXl4Gw+EMoWBuYchFjJw kh3Va7RFXTbJlbKsqLOKM1KCf8pUQG6PeDrG9+pkVslxfu5W9I892kuLmqQ381cAyehk tSkg== X-Forwarded-Encrypted: i=1; AJvYcCVD1PjyZ8AjuG3PXyNgQRY6JhVU5mCPDCnM9pDbaSkrqZcAMXXzsEC721G7wa9VaUsb8AjczP2fgj0QvTU=@vger.kernel.org X-Gm-Message-State: AOJu0YwkrLF2A3Py3fCEb4X0wG004D+8lDbYNCMaOB+8VHv0nTvSVn+r C9Nx0SwlK+NpIu4wl7cpzrZeB3JB2FVGZOcPXqZ4f+yTSrWwMWelBqrVlPTtMUecGRg2zfz5fKp C+mzTXCDaBX5VTMicz5n3HC98JBr8nexz/7PLhnavCpWda720Tkw7aLeOZLMTSV+IGEY= X-Gm-Gg: AY/fxX4M/H4tmSTE9JILoGgQ4G4aK3wepaM4QZSp3wUOtQQKeM3bGYKl3JGvev1Rfv3 qwEVvhPZQCv/DyQgrCfXiH5xw1xn4eqqibXNwtS0mIPrMIfJ5vwdLtx1n5iF/QSvL5x4/l+HPjM F+LuTmXh2gSoNlpAvyulk5EgoyB7xhQmrQ6HisaKXHcZz9Kbgmr+lFcAF5STXTme2pY7PtGZSBx HBfCKyS4XS6uMW2XOVl9cq67sjFz70YcadTL3PPVPhtEqzu7UsTkaxgkFuRbxATh2bopEEKbduO VK8sd7wqH/0pDr3/uQoAdEC+L1QH8d5VmDDWGWs9eALdpAV3+jb99xZXTB8K2Sk2IeBSOHXFAqq SYTj9A7f36RzkcE4LVoxH2d6KwGsPKgO7aB40qqietQ== X-Received: by 2002:a17:902:daca:b0:2a0:da38:96d8 with SMTP id d9443c01a7336-2a3ee443bf0mr100105335ad.25.1767964234139; Fri, 09 Jan 2026 05:10:34 -0800 (PST) X-Google-Smtp-Source: AGHT+IGrtGRjsnFeOWIo+8GBd5wdKaNe0W+5SXLW8YyqmBR006Uahe80W9Y7w4vCN+q28MK4q8OVgA== X-Received: by 2002:a17:902:daca:b0:2a0:da38:96d8 with SMTP id d9443c01a7336-2a3ee443bf0mr100104825ad.25.1767964233610; Fri, 09 Jan 2026 05:10:33 -0800 (PST) Received: from [10.218.4.221] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a3e3cb2b4dsm108346675ad.54.2026.01.09.05.10.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Jan 2026 05:10:32 -0800 (PST) Message-ID: <6ebf45af-2236-4335-a2b4-6c75142bbd5e@oss.qualcomm.com> Date: Fri, 9 Jan 2026 18:40:27 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 2/2] arm64: dts: qcom: qcs6490-rb3gen2: Enable CAN bus controller To: Marc Kleine-Budde Cc: mani@kernel.org, thomas.kopp@microchip.com, mailhol@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, andersson@kernel.org, konradybcio@kernel.org, linux-can@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, mukesh.savaliya@oss.qualcomm.com, anup.kulkarni@oss.qualcomm.com References: <20260108125200.2803112-1-viken.dadhaniya@oss.qualcomm.com> <20260108125200.2803112-3-viken.dadhaniya@oss.qualcomm.com> <20260109-agile-bear-of-fascination-cc4680-mkl@pengutronix.de> Content-Language: en-US From: Viken Dadhaniya In-Reply-To: <20260109-agile-bear-of-fascination-cc4680-mkl@pengutronix.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=Ue1ciaSN c=1 sm=1 tr=0 ts=6960fe4b cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=2KV3BzIYt2orMVJPxDMA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-ORIG-GUID: QUte6YPHgxWxAjhmfHSvpIZMd8ArynKJ X-Proofpoint-GUID: QUte6YPHgxWxAjhmfHSvpIZMd8ArynKJ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTA5MDA5NyBTYWx0ZWRfX8OLO48ZFbS/o UVtSHZ2cxSC4KGTRmttIbUzR7Ro2gcRNzn4eYPpPhKAx+l40JL4HxmKbhT7CEmqiikMPNo00nxk jifWodZwmvTGzw8mFBgNidfSlDJQ45YFyWB6mi7oYk8BPM2uMHKBRxp6j8B4ejJFHB0wPYwmwd9 gQObi/80ta+y/wwE7wH1+BVyZOA1Zo2BKy43pU5/Vns+TZgDv//1JjecDqX5GSHTnLP6zP9EWsf 55FlA9QOBpeAxLtiIsW9/3GJ9qASPrSetkc53ixmr6l133s25mJR1PLJItMFgBceLqt0/7BDBo4 NVutYDP3XwB7NBiaKWRTT76LB8dHnMgkxZ+CtdewwNLj62FjP7R2tb4iaSK604ykVGXnulLMxqi o4Dpc6jfpQzqNJB+kS9GBQaHjm0Oax7xu8qfBGF7bW+8KO/D6LOitjW6BIeMczrNSKlVGqo4UWn vTP6hrdP/e8Ff01jyeA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-09_04,2026-01-08_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 lowpriorityscore=0 clxscore=1015 priorityscore=1501 bulkscore=0 suspectscore=0 phishscore=0 spamscore=0 malwarescore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601090097 On 1/9/2026 2:22 PM, Marc Kleine-Budde wrote: > On 08.01.2026 18:22:00, Viken Dadhaniya wrote: >> Enable the MCP2518FD CAN controller on the QCS6490 RB3 Gen2 platform. >> The controller is connected via SPI3 and uses a 40 MHz oscillator. >> A GPIO hog for GPIO0 is included to configure the CAN transceiver in >> Normal mode during boot. >> >> Signed-off-by: Viken Dadhaniya >> --- >> arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 30 ++++++++++++++++++++ >> 1 file changed, 30 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts >> index e3d2f01881ae..f2f2925e645a 100644 >> --- a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts >> +++ b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts >> @@ -44,6 +44,14 @@ chosen { >> stdout-path = "serial0:115200n8"; >> }; >> >> + clocks { >> + mcp2518fd_osc: can-clk { >> + compatible = "fixed-clock"; >> + clock-frequency = <40000000>; >> + #clock-cells = <0>; > > Is the #clock-cells property needed? Yes, #clock-cells is required for all clock providers, including fixed-clock. For fixed-clock, it must be <0> since there are no arguments. Omitting it will lead to schema validation errors and may break consumers expecting a proper clock provider node. > >> + }; >> + }; >> + >> dp-connector { >> compatible = "dp-connector"; >> label = "DP"; >> @@ -1151,6 +1159,28 @@ platform { >> }; >> }; >> >> +&spi3 { >> + status = "okay"; >> + >> + can@0 { >> + compatible = "microchip,mcp2518fd"; >> + reg = <0>; >> + interrupts-extended = <&tlmm 7 IRQ_TYPE_LEVEL_LOW>; >> + clocks = <&mcp2518fd_osc>; >> + spi-max-frequency = <10000000>; >> + vdd-supply = <&vreg_l11c_2p8>; >> + gpio-controller; >> + #gpio-cells = <2>; >> + >> + gpio0-hog { >> + gpio-hog; >> + gpios = <0 GPIO_ACTIVE_LOW>; >> + output-high; >> + line-name = "mcp251xfd-gpio0"; > > If the CAN transceiver is connected to GPIO0, why not reflect that in > the name of the line? Ack, will update the GPIO line name in v2 to reflect the CAN transceiver connection. > > Marc >