From: "Jin, Yao" <yao.jin@linux.intel.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: jolsa@kernel.org, peterz@infradead.org, mingo@redhat.com,
alexander.shishkin@linux.intel.com, Linux-kernel@vger.kernel.org,
ak@linux.intel.com, kan.liang@intel.com, yao.jin@intel.com
Subject: Re: [PATCH] perf tool: Return all events as auto-completions after comma
Date: Mon, 25 Dec 2017 10:57:48 +0800 [thread overview]
Message-ID: <6ecfe925-19c6-163a-8c37-03e57c839882@linux.intel.com> (raw)
In-Reply-To: <20171222121427.GQ21971@kernel.org>
> One other thing you may want to look at:
>
> $ $ perf record -e cycles/<TAB>
>
> Should present the modifiers, i.e. these:
>
> /*
> * Update according to parse-events.l
> */
> static const char *config_term_names[__PARSE_EVENTS__TERM_TYPE_NR] = {
> [PARSE_EVENTS__TERM_TYPE_USER] = "<sysfs term>",
> [PARSE_EVENTS__TERM_TYPE_CONFIG] = "config",
> [PARSE_EVENTS__TERM_TYPE_CONFIG1] = "config1",
> [PARSE_EVENTS__TERM_TYPE_CONFIG2] = "config2",
> [PARSE_EVENTS__TERM_TYPE_NAME] = "name",
> [PARSE_EVENTS__TERM_TYPE_SAMPLE_PERIOD] = "period",
> [PARSE_EVENTS__TERM_TYPE_SAMPLE_FREQ] = "freq",
> [PARSE_EVENTS__TERM_TYPE_BRANCH_SAMPLE_TYPE] = "branch_type",
> [PARSE_EVENTS__TERM_TYPE_TIME] = "time",
> [PARSE_EVENTS__TERM_TYPE_CALLGRAPH] = "call-graph",
> [PARSE_EVENTS__TERM_TYPE_STACKSIZE] = "stack-size",
> [PARSE_EVENTS__TERM_TYPE_NOINHERIT] = "no-inherit",
> [PARSE_EVENTS__TERM_TYPE_INHERIT] = "inherit",
> [PARSE_EVENTS__TERM_TYPE_MAX_STACK] = "max-stack",
> [PARSE_EVENTS__TERM_TYPE_OVERWRITE] = "overwrite",
> [PARSE_EVENTS__TERM_TYPE_NOOVERWRITE] = "no-overwrite",
> [PARSE_EVENTS__TERM_TYPE_DRV_CFG] = "driver-config",
> };
>
> :-)
>
> - Arnaldo
>
Hi Arnaldo,
Currently, in my understanding, the modifiers appended to an event are:
u/k/h/I/G/H/p/...
For example,
perf stat -e cycles:u
Does perf support the modifiers like "cycles/config" or
"cycles/config1", or ..., "cycles/driver-config" now?
I tried some command lines but they were failed. Maybe my used format
was not correct.
Or do you mean the format like "cpu/xxx"? For example,
perf stat -e cpu/event=0x0e,umask=0x1,inv/ -a sleep 1
Anyway, if we want to implement the auto-completion for the modifiers,
it'd better expose them by an interface (e.g. perf list --xx) rather
than hardcode them in auto-completion script. That's my initial idea.
Thanks
Jin Yao
next prev parent reply other threads:[~2017-12-25 2:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-22 10:57 Jin Yao
2017-12-22 12:14 ` Arnaldo Carvalho de Melo
2017-12-25 2:57 ` Jin, Yao [this message]
2017-12-28 15:36 ` [tip:perf/core] perf tools: " tip-bot for Jin Yao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ecfe925-19c6-163a-8c37-03e57c839882@linux.intel.com \
--to=yao.jin@linux.intel.com \
--cc=Linux-kernel@vger.kernel.org \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@intel.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=yao.jin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome